Review main Merged

90453[TASK] Make methods and properties in final ViewHelpers private

Simon Schaufelberger CR +2 V +2 Normal +94 −95 updated 08/19/25, 18:38

Commit message

Methods and properties that do not extend an abstract class can be made
private for ViewHelpers which are final as they cannot be extended.

This change was done with the help of TYPO3 Rector.

Applied rules:
- PrivatizeFinalClassMethodRector
- PrivatizeFinalClassPropertyRector

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Simon Praetorius +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Simon Praetorius +1
    • core-ci +1 CI

Issues 1

Files 44

Show 24 more files

Review log 79

  1. Simon Schaufelberger uploaded patch set 1 08/19/25, 10:03

  2. core-ci voted on patch set 1 V +1 08/19/25, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83603

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 08/19/25, 10:27

  4. Simon Schaufelberger uploaded patch set 2 CR +1 V +1 08/19/25, 10:33

  5. core-ci voted on patch set 2 V +1 08/19/25, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83607

  6. Simon Praetorius voted on patch set 2 CR +1 V +1 08/19/25, 13:11

  7. Oliver Klee voted on patch set 2 CR +1 V +1 08/19/25, 14:18

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 08/19/25, 18:38

  9. Christian Kuhn merged patch set 3 08/19/25, 18:38