Review main Merged

90458[BUGFIX] Fix access control for sys_file_metadata

Oli Bartsch CR +2 V +2 Easy +7 −3 updated 08/21/25, 21:09

Commit message

The doc header buttons for a file metadata
record do now also work for non-admins.

Respect `ignoreRootLevelRestriction` for
root-level records in `ElementInformationController`.

Properly use TCA schema EditLock capability instead
of direct field access for the editlock check in
`ElementHistoryController`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 710

  1. Oli Bartsch uploaded patch set 1 08/19/25, 16:05

  2. Oli Bartsch uploaded patch set 2 08/19/25, 16:15

  3. core-ci voted on patch set 1 V +1 08/19/25, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83619

  4. core-ci voted on patch set 2 V -1 08/19/25, 16:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83621

  5. Oli Bartsch uploaded patch set 3 V -1 08/19/25, 20:42

  6. core-ci voted on patch set 3 V +1 08/19/25, 20:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83634

  7. Simon Schaufelberger voted on patch set 3 CR +1 V +1 08/20/25, 07:53

  8. Garvin Hicking voted on patch set 3 CR +1 V +1 08/21/25, 19:40

  9. Oli Bartsch voted on patch set 3 CR +2 V +2 08/21/25, 21:09

  10. Oli Bartsch merged patch set 4 08/21/25, 21:09