Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
90461[WIP][BUGFIX] Allow to set context in test mail environment
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 7
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/61/90461/7 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/61/90461/7 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -1 Needs a vote
- Stefan Froemken -1
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/install/module/environment/mail-test.ts+38 −1
- typo3/sysext/core/Resources/Private/Layouts/SystemEmail.html+4 −1
- typo3/sysext/install/Classes/Controller/EnvironmentController.php2+77 −7
- typo3/sysext/install/Resources/Private/Templates/Environment/MailTest.html8+33 −0
- typo3/sysext/install/Resources/Public/JavaScript/module/environment/mail-test.js+1 −1
Review log 2128
Show 3 earlier messages
-
core-ci voted on patch set 1 V +1 08/20/25, 20:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83677
-
core-ci voted on patch set 2 V +1 08/20/25, 20:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83678
-
Garvin Hicking uploaded patch set 3
V +108/20/25, 22:09 -
core-ci voted on patch set 3 V -1 08/20/25, 22:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83679
-
Garvin Hicking uploaded patch set 4
V -108/20/25, 22:21 -
Garvin Hicking uploaded patch set 5 08/20/25, 22:27
-
core-ci voted on patch set 4 V -1 08/20/25, 22:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83680
-
core-ci voted on patch set 5 V +1 08/20/25, 22:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83681
-
Mathias Brodala commented on patch set 5 08/21/25, 06:44
-
Garvin Hicking commented on patch set 5 08/21/25, 07:25
MailTest.html:47ReplyUnsure here because of code duplication and people maybe not being able to understand what the differentiation is. I'm open to this though, don't have a strong opinion about split or single. -
Mathias Brodala commented on patch set 5 08/21/25, 07:39
MailTest.html:47ReplyAlso I'd propose moving this to a dedicated module outside of the Maintenance Area. You mentioned that this may be relevant for integrators, so they should be able to easily access it accordingly. That cannot be expected with the Maintenance Area normally. -
Garvin Hicking commented on patch set 5 08/21/25, 08:16
MailTest.html:47Reply"My" integrators previously used this card so those people would know where to find it. introducing a new module would be overhead and more maintenance work for the core so I tend to not do this. Also I think we don't have an existing module where we could place it, and a complete own module icon just for this would be unneccessary bloaty for the menu IMO. Where would you put it and how would you name that module, what would be in it? -
Mathias Brodala commented on patch set 5 08/21/25, 08:25
MailTest.html:47ReplyGiven that you mentioned integrators it could be placed in the "Web" module area. But yeah, the module would be extremely spartanic, given that it basically contains only a single button and a success/error flash message. So I guess a dedicated module does not make much sense (yet). Still I'm not too fond of simulating a BE environment for Fluid mail testing within the Install Tool, even if optional. -
Garvin Hicking commented on patch set 5 08/21/25, 08:45
MailTest.html:47ReplyMy "plan" is actually this: We should integrate per-site mail config. Then we could open the popup from the site config of a specific site and already feed that with specific configuration. Then it would also be where integrators expect it, and then the install tool can be completely freed from fluidmail specifics and really do low level mail testing (site-unspecific). I understand this approach also has "caveats" but IMO its a better solution than missing the possibility to test fluidmail, and kröte I'm willing to eat. 😅 -
Garvin Hicking commented on patch set 5 08/21/25, 08:46
MailTest.html:47Reply(so this patch would be an interrim version; site-specific settings take much work. It doesn't add terribly much maintenance and we can drop it then) -
Garvin Hicking uploaded patch set 6
V +108/21/25, 18:18 -
Garvin Hicking commented on patch set 6 08/21/25, 18:19
This change is ready for review.MailTest.html:47Reply UnresolvedI've changed the labels now and also implemented the JS to hide the options unless FluidMail is implemented. IMO this makes the initial card much less complex. Would you find this agreeable? -
core-ci voted on patch set 6 V +1 08/21/25, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83707
-
Stefan Froemken updated the commit message in patch set 7
V +108/22/25, 07:37 -
core-ci voted on patch set 7 V +1 08/22/25, 07:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83745
-
Stefan Froemken commented on patch set 7 CR -1 08/22/25, 07:52
Sorry. I don't think we should merge/use this solution. You just add the needed environment to get f:translate to work. What, if user adds f:cObject next time, or checks for Frontend- or BackendGroup restrictions? IMO there will and should never be a full blown environment available in install tool.EnvironmentController.php:244Can we use Locales::getActiveLanguages() here instead? -
Garvin Hicking commented on patch set 7 08/22/25, 08:09
Reply
What is your solution to test this then? I would argue that the usual SystemEnail template does not do this in most cases, specifically not the default template. Most projects I know only do f:translate and css changes. They should be able to easily test the system mail then without executing actual password resets or so, or needign to creating custom backend modules. We need a solution here and IMo this is the best we can get. Otherwise please do create an alternate solution. -
Stefan Froemken commented on patch set 7 08/22/25, 08:59
Reply
Installtool only checks, if MAIL configuration is correct and has absolutely nothing to do with translated fluid based system mails. -
Garvin Hicking commented on patch set 7 08/22/25, 09:23
Reply Unresolved
Hm. I'm not fine with taking people away functionality that they use, just for situations that many devleopers will never face. just removing this is not acceptable to me.EnvironmentController.php:244Reply UnresolvedWill check -
Benni Mack marked it work in progress 04/21/26, 15:15
MailTest.html:47