Review main Merged

90468[FOLLOWUP] Workspace stage handling details

Christian Kuhn CR +2 V +2 Easy +3 −6 updated 08/22/25, 10:46

Commit message

Adapt two details of the main patch that popped up during
testing the v13 backport and have been fixed there already:
The preview mixed up the 'previous stage' button, and the
'info' modal showed broken previous & next buttons for users
that don't have write access to the stage.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Froemken +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Christian Kuhn uploaded patch set 1 08/21/25, 20:21

  2. core-ci voted on patch set 1 V +1 08/21/25, 20:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83713

  3. Stefan Froemken commented on patch set 1 08/22/25, 06:35

    There is a "label_PrevStage" in record-information.ts where its type is declared to "string". It's a little bit misleading to set this property to bool "false" here.
  4. Christian Kuhn commented on patch set 1 08/22/25, 10:23

    Reply

    yeah. but this recreates the state we had before the main patch. i'll keep it for now to prevent falsely labeled 'false' buttons.
  5. Christian Kuhn uploaded patch set 2 V +1 08/22/25, 10:33

  6. Stefan Froemken voted on patch set 2 CR +1 08/22/25, 10:43

  7. core-ci voted on patch set 2 V +1 08/22/25, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83752

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 08/22/25, 10:46

  9. Christian Kuhn merged patch set 3 08/22/25, 10:46