Review main Abandoned

90470[TASK] Changes if/else for the same value as assigned to ternary

Simon Schaufelberger CR 0 V 0 Hard +120 −606 updated 06/05/26, 00:07

Commit message

Apply SimplifyIfElseToTernaryRector with some manual changes

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Files 87

Show 67 more files

Review log 1317

  1. Simon Schaufelberger uploaded patch set 1 08/21/25, 20:48

  2. Simon Schaufelberger marked it work in progress 08/21/25, 20:49

  3. core-ci voted on patch set 1 V +1 08/21/25, 20:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83716

  4. Simon Schaufelberger uploaded patch set 2 V +1 08/21/25, 20:58

  5. core-ci voted on patch set 2 V +1 08/21/25, 21:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83718

  6. Simon Schaufelberger uploaded patch set 3 V +1 08/21/25, 21:11

  7. Simon Schaufelberger commented on patch set 3 08/21/25, 21:11

    DatabaseRecordList.php:1511 Unresolved

    This is a rector & manual change suggested by phpstorm

    GeneralUtility.php:2059 Unresolved

    if early return would be used there, the whole block below could be unindented

    AbstractEscapingBaseViewHelper.php:31 Unresolved

    manually simplified
  8. core-ci voted on patch set 3 V +1 08/21/25, 21:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83719

  9. Simon Schaufelberger marked it ready for review 08/22/25, 09:56

  10. Stefan Froemken commented on patch set 3 08/22/25, 09:59

    This is my first time seeing a PR with NO forge ticket assigned. Is that correct?!?!
  11. Simon Schaufelberger commented on patch set 3 08/22/25, 10:11

    Reply

    I first of all want to get a feedback if such a patch is welcome or not. Stefan Bürk and Lolli are not so positive about it and would rather not have this. Just to keep the forge issues clean, I didn't create an issue for nothing.
  12. Markus Klein commented on patch set 3 08/22/25, 10:32

    Reply

    I'd say the cases, where the condition is simple and the assigned expression is too would be fine. But I tend to add such changes only when touching the code for other reasons anyway.
  13. Benni Mack marked it work in progress 09/29/25, 09:51

  14. Simon Schaufelberger uploaded patch set 4 V +1 05/09/26, 18:00

  15. core-ci voted on patch set 4 V +1 05/09/26, 18:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101754

  16. Christian Kuhn commented on patch set 4 06/05/26, 00:07

    hey. i hope it is ok to abandon here for now: ternary vs. if/else is often rather matter of taste, it is hard to decide on and to put into a good cgl rule everyone could follow. Markus said a similar thing "i would only touch this when i'm in the same area", if at all. as such, and considering the change didn't get too much attention, and is pending for quite a while: i hope it's ok to close here for now.
  17. Christian Kuhn abandoned the change 06/05/26, 00:07