90472[FEATURE] Add new AfterRichtextConfigurationPreparedEvent
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 9
- Build/phpstan/phpstan-baseline.neon2+0 −6
- typo3/sysext/core/Classes/Configuration/Event/AfterRichtextConfigurationPreparedEvent.phpnew+33 −0
- typo3/sysext/core/Classes/Configuration/Richtext.php2+6 −4
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107322-NewPSR-14AfterRichtextConfigurationPreparedEvent.rst2new+53 −0
- typo3/sysext/core/Tests/Functional/Configuration/RichtextTest.phpnew+88 −0
- typo3/sysext/core/Tests/Unit/Configuration/RichtextTest.php+19 −0
- typo3/sysext/rte_ckeditor/Classes/Configuration/CKEditor5Migrator.phprenamed+5 −8
- typo3/sysext/rte_ckeditor/Classes/EventListener/AfterRichtextConfigurationPreparedEventListener.php2new+31 −0
- typo3/sysext/rte_ckeditor/Tests/Unit/Configuration/CKEditor5MigratorTest.phprenamed+2 −2
Review log 1930
Show 35 earlier messages
-
Andreas Nedbal uploaded patch set 1 08/22/25, 09:48
-
core-ci voted on patch set 1 V -1 08/22/25, 09:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83749
-
Andreas Nedbal uploaded patch set 2
V -108/22/25, 10:05 -
core-ci voted on patch set 2 V -1 08/22/25, 10:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83750
-
Andreas Nedbal uploaded patch set 3
V -108/22/25, 10:38
-
core-ci voted on patch set 3 V -1 08/22/25, 10:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83753
-
Andreas Nedbal uploaded patch set 4
V -108/22/25, 12:43 -
core-ci voted on patch set 4 V -1 08/22/25, 12:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83760
-
Andreas Nedbal uploaded patch set 5
V -108/22/25, 12:56 -
core-ci voted on patch set 5 V +1 08/22/25, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83761
-
Garvin Hicking commented on patch set 5 V +1 08/22/25, 18:44
Richtext.php:82Could we use DI for eventDispatcher here to prevent GUmI?Feature-107322-NewPSR-14AfterRichtextConfigurationPreparedEvent.rst:41```suggestion $config = $event->getConfiguration(); $config['someSetting'] = 'someValue'; $event->setConfiguration($config); ``` maybe that would make it clearer and also involve the getter. Even better if you figure out a good config value to change here (maybe with dynamic evaluation of something to showcase why having this can be cool...?)AfterRichtextConfigurationPreparedEventListener.php:24```suggestion final readonly class AfterRichtextConfigurationPreparedEventListener ``` -
Andreas Nedbal uploaded patch set 6
V +108/25/25, 11:52 -
Andreas Nedbal commented on patch set 6 08/25/25, 11:54
phpstan-baseline.neon:643ReplyDoneRichtext.php:82ReplyDoneFeature-107322-NewPSR-14AfterRichtextConfigurationPreparedEvent.rst:41ReplyDoneAfterRichtextConfigurationPreparedEventListener.php:24ReplyDone -
core-ci voted on patch set 6 V -1 08/25/25, 12:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83845
-
Andreas Nedbal uploaded patch set 7
V -108/25/25, 13:15 -
core-ci voted on patch set 7 V -1 08/25/25, 13:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83849
-
Andreas Nedbal uploaded patch set 8
V -108/29/25, 09:14 -
core-ci voted on patch set 8 V +1 08/29/25, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83973
-
Oli Bartsch commented on patch set 8 08/29/25, 09:33
AfterRichtextConfigurationPreparedEventTest.php:24IMO we can skip this test and should instead add a test to `RichtextTest`, which acutally verifies, that the event is dispatched and updated configuration is used. See `*EventIsCalled` for similar tests in the code base. -
Andreas Nedbal uploaded patch set 9
V +108/29/25, 10:39 -
core-ci voted on patch set 9 V -1 08/29/25, 10:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83974
-
Andreas Nedbal uploaded patch set 10
V -108/29/25, 11:24 -
core-ci voted on patch set 10 V +1 08/29/25, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83976
-
Andreas Nedbal commented on patch set 10 08/29/25, 11:35
AfterRichtextConfigurationPreparedEventTest.php:24ReplyDone -
Garvin Hicking commented on patch set 10 CR +1 V +1 08/29/25, 20:50
\o/ -
Garvin Hicking rebased onto patch set 11
CR +1V +108/29/25, 21:04 -
Garvin Hicking commented on patch set 11 CR +1 V +1 08/29/25, 21:09
Sorry, git-fail on my part, never mind the relation chain (I promise to try harder) -
core-ci voted on patch set 11 V +1 08/29/25, 21:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84016
-
Benni Mack voted on patch set 11 CR +2 V +2 09/02/25, 12:06
-
Benni Mack merged patch set 12 09/02/25, 12:06
phpstan-baseline.neon:643