Review main Merged Breaking

90473[!!!][TASK] Remove workspace 'Freeze Editing'

Christian Kuhn CR +2 V +2 Nightmare +2815 −2798 updated 08/22/25, 13:44

Commit message

Workspaces has a feature to mark single workspaces as frozen
to prevent further editing of records. The patch drops this
feature altogether:

While the feature may be theoretically useful, its implementation
is so half-done and sparse that we either have the option to put
a lot of time and effort into it to render it usable, or to remove
it for now in favor of other workspace related features that should
receive love. Asking in the community revealed no single actual
user of the feature, there is only one forge issue exists that
points out a major flaw, and zero work has been put into the
feature since the initial introduction of workspaces.

Some details:
* A frozen workspace can not be published. When a frozen workspace
  means "this has been fully reviewed, do not edit anymore", then
  publishing is the only option that actually *should* be possible.
* Only admins can freeze a workspace. We'd expect owners should be
  able to do this.
* The *only* attached functionality are early checks in DataHandler
  that prevent writing records. They return early and write a log
  entry. There is zero notification whatsoever to the user: There
  are no flash messages during editing that records can't be saved,
  there is no information in the workspace module this workspace
  is frozen, record fields are not readonly, all 'edit pencils'
  are still shown. This turns this feature into a UX disaster.
* A proper "only certain persons can publish a workspace" can be
  realized using custom stages in combination with a list of
  'responsible persons', 'Publish only content in publish stage'
  and 'Restrict publishing to workspace owners'. This is not fully
  documented (which we can change), but ends up in a more flexible
  feature than the half implemented 'Freeze Editing' toggle.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Stefan Froemken +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Stefan Froemken +1
    • core-ci +1 CI

Issues 2

Files 928

Show 908 more files

Review log 710

  1. Christian Kuhn uploaded patch set 1 08/22/25, 11:05

  2. Christian Kuhn uploaded patch set 2 08/22/25, 11:14

  3. core-ci voted on patch set 1 V -1 08/22/25, 11:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83754

  4. core-ci voted on patch set 2 V +1 08/22/25, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83755

  5. Christian Kuhn uploaded patch set 3 V +1 08/22/25, 12:30

  6. core-ci voted on patch set 3 V +1 08/22/25, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83757

  7. Stefan Bürk voted on patch set 3 CR +1 V +1 08/22/25, 13:26

  8. Stefan Froemken commented on patch set 3 CR +1 V +1 08/22/25, 13:41

    Hi all. Yes, I really have clicked through all 929 files. Interesting that this freeze feature was more a "DataHandler will stop doing anything, if this checkbox is set" thingy and nothing more. Thank you for removing that unfinished "feature"
  9. Christian Kuhn voted on patch set 3 CR +2 V +2 08/22/25, 13:43

  10. Christian Kuhn merged patch set 4 08/22/25, 13:44