Review main Merged

90474[BUGFIX] Do not cast PID of file reference to int in HTML

Georg Großberger CR +2 V +2 Easy +1 −1 updated 08/22/25, 13:45

Commit message

The value of the PID of a new file reference may not be
an integer, but a string with a "NEW..." reference. This
can happen if a file is added to a page field, like "media",
when that page was not saved yet.

Instead write the value as as string, with htmlspecialchars
applied. This is the same behaviour as the InlineRecordContainer

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Georg Großberger uploaded patch set 1 08/22/25, 12:37

  2. Georg Großberger updated the commit message in patch set 2 08/22/25, 12:37

  3. core-ci voted on patch set 1 V +1 08/22/25, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83758

  4. core-ci voted on patch set 2 V +1 08/22/25, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83759

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 08/22/25, 13:22

  6. Christian Kuhn voted on patch set 2 CR +2 V +2 08/22/25, 13:27

  7. Stefan Bürk voted on patch set 2 CR +1 V +1 08/22/25, 13:29

  8. Christian Kuhn merged patch set 3 08/22/25, 13:45