Review 12.4 Merged

90475[BUGFIX] Do not calculate negative cache lifetime

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 08/22/25, 14:15

Commit message

This has been fixed in v13 & main with #105776 already. The
change should be fine without too many risks in v12 and can
prevent crashes depending on the configured page cache backend.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Froemken +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Froemken +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 710

  1. Christian Kuhn uploaded patch set 1 08/22/25, 13:06

  2. core-ci voted on patch set 1 V +1 08/22/25, 13:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83762

  3. Christian Kuhn uploaded patch set 2 V +1 08/22/25, 13:29

  4. Garvin Hicking updated the commit message in patch set 3 08/22/25, 13:36

  5. Garvin Hicking voted on patch set 3 CR +1 V +1 08/22/25, 13:36

  6. core-ci voted on patch set 2 V +1 08/22/25, 13:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83765

  7. core-ci voted on patch set 3 V +1 08/22/25, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83767

  8. Stefan Froemken commented on patch set 3 CR +1 V +1 08/22/25, 14:09

    The missing starttime is somewhere in future, so you can always subtract the current timestamp without any problems. Having just endtime here, is OK for me.
  9. Christian Kuhn voted on patch set 3 CR +2 V +2 08/22/25, 14:15

  10. Christian Kuhn merged patch set 4 08/22/25, 14:15