Review main Merged

90485[TASK] Remove bw compat for $GLOBALS['TCA'] in base TCA files

Nikita Hovratov CR +2 V +2 Easy +33 −4 updated 09/02/25, 14:27

Commit message

When loading base TCA files, it is not needed to store them
temporarily into $GLOBALS['TCA']. This is only needed for TCA overrides
as they write into this array.

Up until now, this was only done for backward compatibility reasons.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 911

  1. Nikita Hovratov uploaded patch set 1 08/25/25, 13:05

  2. core-ci voted on patch set 1 V +1 08/25/25, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83848

  3. Oliver Klee voted on patch set 1 CR +1 08/25/25, 16:42

  4. Oli Bartsch commented on patch set 1 09/02/25, 12:07

    Hi Nikita, I wonder wheater there are any side effect for e.g. content blocks due to this? Otherwise I don't think we should backport this to v13. I would love to get some background information about it 😊
  5. Nikita Hovratov commented on patch set 1 09/02/25, 12:15

    Reply

    Hi Oli, the only side-effect is, when extensions use `$GLOBALS['TCA']` in their **base** TCA files. See News extensions, where we fixed it: https://github.com/georgringer/news/commit/b0f3c243315056b7c2bc0cb274cf4f8880aaba60 I agree, this could be too intrusive for v13 backport. Should we maybe add an Important rst, as well?
  6. Nikita Hovratov uploaded patch set 2 CR +1 V +1 09/02/25, 12:39

  7. core-ci voted on patch set 2 V +1 09/02/25, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84245

  8. Oli Bartsch commented on patch set 2 09/02/25, 14:18

    Reply

    Oke yes sounds good. Thank you!
  9. Oli Bartsch voted on patch set 2 CR +1 V +1 09/02/25, 14:18

  10. Georg Ringer voted on patch set 2 CR +2 V +2 09/02/25, 14:27

  11. Georg Ringer merged patch set 3 09/02/25, 14:27