Review main Merged

90486[TASK] Use strict types in ext:scheduler CronCommand classes

Torben Hansen CR +2 V +2 Normal +45 −101 updated 08/26/25, 09:04

Commit message

The `CronCommand` and `NormalizeCommand` classes in
ext:scheduler have been hardened by introducing strict
type declarations. All relevant method signatures have
been updated to include explicit type hints for parameters
and return types.

Additionally, tests have been adjusted to only test for
input as string, because `NormalizeCommand::normalize()`
internally always transforms the given input to a string.
Tests testing for integer value evaluation have been
removed.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 811

  1. Torben Hansen uploaded patch set 1 08/25/25, 16:48

  2. core-ci voted on patch set 1 V +1 08/25/25, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83850

  3. Oliver Klee commented on patch set 1 V +1 08/25/25, 17:17

    CronCommand.php:121

    This change seems unrelated. Is this removal intentional?

    NormalizeCommand.php:218

    I think keeping this line would be beneficial as it documents the expected format of the parameter.

    NormalizeCommand.php:263

    I think keeping would help the reader see the output format to expect.
  4. Torben Hansen uploaded patch set 2 V +1 08/26/25, 06:26

  5. Torben Hansen commented on patch set 2 08/26/25, 06:26

    CronCommand.php:121 Reply

    This was intentional, since it is superfluous. The whole class is defined as `@internal`, so there is no need to define it for single methods of the class too.

    NormalizeCommand.php:218 Reply

    Done

    NormalizeCommand.php:263 Reply

    Done
  6. core-ci voted on patch set 2 V +1 08/26/25, 06:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83869

  7. Oliver Klee commented on patch set 3 V +1 08/26/25, 07:49

    Published edit on patch set 2.
  8. Oliver Klee voted on patch set 3 CR +1 V +1 08/26/25, 07:50

  9. core-ci voted on patch set 3 V +1 08/26/25, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83870

  10. Georg Ringer voted on patch set 3 CR +2 V +2 08/26/25, 09:04

  11. Georg Ringer merged patch set 4 08/26/25, 09:04