90486[TASK] Use strict types in ext:scheduler CronCommand classes
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Klee +1
-
Verified V +2 Done
- Georg Ringer +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/scheduler/Classes/CronCommand/CronCommand.php2+9 −25
- typo3/sysext/scheduler/Classes/CronCommand/NormalizeCommand.php4+24 −50
- typo3/sysext/scheduler/Tests/Unit/CronCommand/AccessibleProxies/NormalizeCommandAccessibleProxy.php+10 −10
- typo3/sysext/scheduler/Tests/Unit/CronCommand/NormalizeCommandTest.php+2 −16
Review log 811
-
Torben Hansen uploaded patch set 1 08/25/25, 16:48
-
core-ci voted on patch set 1 V +1 08/25/25, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83850
-
Oliver Klee commented on patch set 1 V +1 08/25/25, 17:17
NormalizeCommand.php:218I think keeping this line would be beneficial as it documents the expected format of the parameter.NormalizeCommand.php:263I think keeping would help the reader see the output format to expect. -
Torben Hansen uploaded patch set 2
V +108/26/25, 06:26 -
Torben Hansen commented on patch set 2 08/26/25, 06:26
CronCommand.php:121ReplyThis was intentional, since it is superfluous. The whole class is defined as `@internal`, so there is no need to define it for single methods of the class too.NormalizeCommand.php:218ReplyDoneNormalizeCommand.php:263ReplyDone -
core-ci voted on patch set 2 V +1 08/26/25, 06:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83869
-
Oliver Klee commented on patch set 3
V +108/26/25, 07:49Published edit on patch set 2. -
Oliver Klee voted on patch set 3 CR +1 V +1 08/26/25, 07:50
-
core-ci voted on patch set 3 V +1 08/26/25, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83870
-
Georg Ringer voted on patch set 3 CR +2 V +2 08/26/25, 09:04
-
Georg Ringer merged patch set 4 08/26/25, 09:04
CronCommand.php:121