Review main Merged

90489[FEATURE] Modernized translation workflow

Benjamin Kott CR +2 V +2 Nightmare +5758 −1091 updated 11/14/25, 07:13

Commit message

This change introduces a modernized and extensible translation
workflow. The new architecture replaces the monolithic localization
implementation with a step-based wizard system that guides editors
through the translation process.

The backend now consistently opens the new translation wizard
whenever users initiate a translation operation, providing a
unified experience across all modules. The wizard guides users
through the translation process in multiple steps, automatically
advancing when no user input is required.

Users can choose between two translation modes: Translate (creates
a connected translation) and Copy (creates an independent copy).
To maintain consistency, the wizard will only offer the translation
mode that matches existing translations for a record, preventing
mixed modes.

The refactoring introduces a handler registry pattern that allows
different translation strategies to be registered via autoconfiguration,
making the system extensible for specialized workflows such as
integration with translation services or AI-powered translation tools.

Additionally, the translation finisher concept has been implemented
to support different completion behaviors, such as redirecting to
specific pages or reloading the current view after translation
operations complete.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 64

Show 44 more files

Review log 154242

Show 134217 earlier messages
  1. Benjamin Kott uploaded patch set 1 08/26/25, 11:59

  2. core-ci voted on patch set 1 V -1 08/26/25, 12:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83875

  3. Benjamin Kott uploaded patch set 2 V -1 08/29/25, 12:27

  4. core-ci voted on patch set 2 V -1 08/29/25, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83983

  5. Benjamin Kott uploaded patch set 3 V -1 08/29/25, 13:04

  6. Benjamin Kott uploaded patch set 4 09/01/25, 13:31

  7. core-ci voted on patch set 4 V -1 09/01/25, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84158

  8. Benjamin Kott uploaded patch set 5 V -1 09/04/25, 13:04

  9. Benjamin Kott uploaded patch set 6 09/04/25, 13:17

  10. core-ci voted on patch set 5 V -1 09/04/25, 13:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84381

  11. core-ci voted on patch set 6 V -1 09/04/25, 13:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84382

  12. Benjamin Kott uploaded patch set 7 V -1 09/08/25, 08:32

  13. core-ci voted on patch set 7 V -1 09/08/25, 08:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84608

  14. Benjamin Kott uploaded patch set 8 V -1 09/09/25, 08:26

  15. core-ci voted on patch set 8 V -1 09/09/25, 09:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84678

  16. Benjamin Kott uploaded patch set 9 V -1 10/14/25, 09:05

  17. core-ci voted on patch set 9 V -1 10/14/25, 09:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86606

  18. Benjamin Kott uploaded patch set 10 V -1 10/16/25, 10:07

  19. core-ci voted on patch set 10 V -1 10/16/25, 10:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86800

  20. Benjamin Kott uploaded patch set 11 V -1 10/16/25, 12:35

  21. core-ci voted on patch set 11 V -1 10/16/25, 12:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86809

  22. Benjamin Kott uploaded patch set 12 V -1 10/17/25, 07:38

  23. core-ci voted on patch set 12 V -1 10/17/25, 07:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86870

  24. Benjamin Kott uploaded patch set 13 V -1 10/17/25, 09:43

  25. core-ci voted on patch set 13 V -1 10/17/25, 10:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86886

  26. Jasmina Ließmann uploaded patch set 14 V -1 10/27/25, 14:43

  27. core-ci voted on patch set 14 V -1 10/27/25, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87667

  28. Jasmina Ließmann uploaded patch set 15 V -1 10/27/25, 15:53

  29. Jasmina Ließmann uploaded patch set 16 10/27/25, 16:02

  30. core-ci voted on patch set 15 V -1 10/27/25, 16:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87675

  31. core-ci voted on patch set 16 V -1 10/27/25, 16:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87677

  32. Jasmina Ließmann uploaded patch set 17 V -1 10/27/25, 17:20

  33. core-ci voted on patch set 17 V -1 10/27/25, 17:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87692

  34. Jasmina Ließmann uploaded patch set 18 V -1 10/27/25, 18:01

  35. core-ci voted on patch set 18 V -1 10/27/25, 18:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87706

  36. Jasmina Ließmann uploaded patch set 19 V -1 10/28/25, 10:00

  37. core-ci voted on patch set 19 V -1 10/28/25, 10:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87787

  38. Jasmina Ließmann uploaded patch set 20 V -1 10/28/25, 13:00

  39. Jasmina Ließmann uploaded patch set 21 10/28/25, 13:00

  40. Jasmina Ließmann uploaded patch set 22 10/28/25, 13:13

  41. core-ci voted on patch set 20 V -1 10/28/25, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87821

  42. core-ci voted on patch set 21 V -1 10/28/25, 13:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87822

  43. core-ci voted on patch set 22 V -1 10/28/25, 13:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87823

  44. Jasmina Ließmann uploaded patch set 23 V -1 10/28/25, 14:05

  45. core-ci voted on patch set 23 V -1 10/28/25, 14:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87831

  46. Benni Mack uploaded patch set 24 V -1 10/28/25, 16:08

  47. core-ci voted on patch set 24 V -1 10/28/25, 16:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87859

  48. Benjamin Kott commented on patch set 24 10/28/25, 17:18

    _form-check.scss:383

    we should not mix existing things with special form styling, if we need this it has to work independed from the existing card layouts and stylings - but it can look similar. that means there chould be no card anything classes in the markup. if this is introduced it also needs to be prepared as example in the styleguide extension.

    CopyProvider.php:55

    i am unsure about this, the mode is actually not a label. in addition this is a technical term that should be hidden from the user.
  49. Benjamin Kott commented on patch set 24 10/28/25, 17:21

    localization-wizard.ts:624

    still open how to redirect to some useful place
  50. Benjamin Kott commented on patch set 24 10/28/25, 17:22

    CopyProvider.php:171

    check if correct

    CopyProvider.php:187

    check if correct

    CopyProvider.php:203

    check if correct
  51. Jasmina Ließmann uploaded patch set 25 V -1 10/28/25, 18:25

  52. Jasmina Ließmann uploaded patch set 26 10/28/25, 18:33

  53. core-ci voted on patch set 25 V -1 10/28/25, 18:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87871

  54. Jasmina Ließmann commented on patch set 25 10/28/25, 18:40

    CopyProvider.php:55 Reply

    "Connected Mode", "Free Mode" and "Mixed Mode" aren't displayed in the wizard but are shown as a badge in the "Language Comparison" view. In contrast, the labels "Translate" and "Copy" are only visible as methods/providers in the wizard. To make the relation clearer for the user, I would also display the mode in the wizard.
  55. Jasmina Ließmann commented on patch set 26 10/28/25, 18:45

    _form-check.scss:383 Reply

    I did this on my first attempt, but I wasn't sure if duplicating the card styles was a good idea: https://review.typo3.org/c/Packages/TYPO3.CMS/+/90489/13..14/Build/Sources/Sass/component/forms/_form-check.scss I can rebuild it that way.
  56. core-ci voted on patch set 26 V -1 10/28/25, 18:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87872

  57. Jasmina Ließmann uploaded patch set 27 V -1 10/28/25, 20:27

  58. Jasmina Ließmann uploaded patch set 28 10/28/25, 20:37

  59. core-ci voted on patch set 27 V -1 10/28/25, 20:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87885

  60. core-ci voted on patch set 28 V -1 10/28/25, 20:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87887

  61. Jasmina Ließmann uploaded patch set 29 V -1 10/28/25, 21:14

  62. core-ci voted on patch set 29 V -1 10/28/25, 21:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87890

  63. Benni Mack commented on patch set 29 10/29/25, 06:21

    CopyProvider.php:55 Reply

    @typo3@minapok.eu: I think the idea is to use a PHP Enum, and then based on the enum we render labels... @benjamin.kott@outlook.com I hope this is what you meant, even though it was a bit cryptic to understand
  64. Benjamin Kott commented on patch set 29 10/29/25, 06:43

    CopyProvider.php:55 Reply

    Yes and no, my problem here is that i see no reason to place it at these elements at all. First I agree with Benni that if you use these, we should prefer an Enum. On the other hand the mode the user is entering is not related to copy or localize action at all, it may be the result for a single record but does not reflect the whole situation. When translating a page and the content elements the mode is defined of the sum of actions happened before. That means if a user translated some and copied some the page itself is in a mixed mode. But none of them alone can define the mode. The same goes for translating any record in the system. We need to explain to the user what happens, also for example when the user reaches a point of mixed mode, that no one really was we need to extend the checks and disallow the other. That means if a user decided to translate some record, we should now allow copying the others. This is currently not handled by the checks and would need to be added in some way or the other. Also this was intended to be the entrypoint for third party extensions like deepl or any other translation service. so you can choose, translate (manually), copy and write new content (manually) or translate it via deepl. In this case deepl also needs to define a mode here.
  65. Benjamin Kott commented on patch set 29 10/29/25, 06:48

    CopyProvider.php:55 Reply

    In addition here, we need to have the wizard as painless as possible, this means that the user needs to be able to always hit next without looking at the contents, and the system needs to make the best choice for the user in this case translate of propably when deepl is installed deepl.
  66. Benjamin Kott commented on patch set 29 10/29/25, 07:20

    localization-wizard.ts:448

    this part is still not converted to the new modal api and needs to be adjusted.

    provider-step.ts:121

    the card style display currently works for 2 records really good, but we have to keep in mind, that we will see more entries here in the future as this is the extension point for integrations like deepl or other translation services.
  67. Benjamin Kott commented on patch set 29 10/29/25, 07:23

    localization-wizard.ts:635

    this is using step.title thats comming, thats defined in the interface and currently contains hardcoded titles for steps.
  68. Benjamin Kott commented on patch set 29 10/29/25, 07:25

    alert-element.ts:30

    we should not extend the interface here. the alert should be simple and have dedicated styling, allowing to add anything makes the component more unreliable. If there is a need to display more information we should reconsider the information display at the place we are rendering them.
  69. Benni Mack uploaded patch set 30 V -1 10/29/25, 10:16

  70. core-ci voted on patch set 30 V -1 10/29/25, 10:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87931

  71. Jasmina Ließmann uploaded patch set 31 V -1 10/29/25, 10:53

  72. core-ci voted on patch set 31 V -1 10/29/25, 11:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87940

  73. Benjamin Franzke commented on patch set 31 10/30/25, 08:48

    localization-wizard.ts:522

    I'd love to see a fast-forward button for advanced users, to go to the last slide that does not require a decision (currently always the last one).

    confirm-step.ts:50

    The record information is somewhat confusing. When content elements on a page are translated, the translated page is shown as the record here. That is technically correct, but too generic to be helpful for a user.

    content-record-selection-step.ts:134

    This button is not noticable to be toggable and is visually distracting in its placement/style.

    LocalizationProviderInterface.php:21

    I don't think that our current translation modes (Connected/Copy) should be providers, since possible providers like Deepl or other tools need to use these modes. That means we should ideally have one default core provider (or maybe two if we want to make it configurable): * DefaultTranslationProvider * (PrefixedTranslationProvider) …and have a separate interface (or whatever) for the mode selection.
  74. Benjamin Kott uploaded patch set 32 V -1 10/30/25, 13:58

  75. core-ci voted on patch set 32 V -1 10/30/25, 14:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88148

  76. Benjamin Kott uploaded patch set 33 V -1 11/03/25, 16:04

  77. core-ci voted on patch set 33 V -1 11/03/25, 16:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88396

  78. Benjamin Kott commented on patch set 33 11/03/25, 16:19

    alert-element.ts:30 Reply

    Done

    localization-wizard.ts:448 Reply

    Done

    provider-step.ts:121 Reply

    Done
  79. Benjamin Kott commented on patch set 33 11/03/25, 16:19

    _form-check.scss:383 Reply

    Done
  80. Benjamin Kott commented on patch set 33 11/03/25, 16:20

    localization-wizard.ts:624 Reply

    Done
  81. Benjamin Kott uploaded patch set 34 V -1 11/04/25, 07:22

  82. core-ci voted on patch set 34 V -1 11/04/25, 07:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88439

  83. Benjamin Kott uploaded patch set 35 V -1 11/04/25, 08:09

  84. core-ci voted on patch set 35 V -1 11/04/25, 08:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88440

  85. Benjamin Kott uploaded patch set 36 V -1 11/04/25, 09:17

  86. core-ci voted on patch set 36 V -1 11/04/25, 09:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88444

  87. Benjamin Kott uploaded patch set 37 V -1 11/04/25, 10:07

  88. core-ci voted on patch set 37 V -1 11/04/25, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88448

  89. Benjamin Kott uploaded patch set 38 V -1 11/04/25, 10:39

  90. core-ci voted on patch set 38 V -1 11/04/25, 10:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88451

  91. Benjamin Kott uploaded patch set 39 V -1 11/04/25, 10:59

  92. core-ci voted on patch set 39 V -1 11/04/25, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88456

  93. Benjamin Kott uploaded patch set 40 V -1 11/04/25, 13:10

  94. core-ci voted on patch set 40 V -1 11/04/25, 13:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88461

  95. Benjamin Kott uploaded patch set 41 V -1 11/04/25, 13:58

  96. core-ci voted on patch set 41 V -1 11/04/25, 14:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88465

  97. Benjamin Kott uploaded patch set 42 V -1 11/05/25, 10:20

  98. core-ci voted on patch set 42 V -1 11/05/25, 10:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88501

  99. Benjamin Kott uploaded patch set 43 V -1 11/05/25, 11:01

  100. Benjamin Kott uploaded patch set 44 11/05/25, 11:09

  101. core-ci voted on patch set 43 V -1 11/05/25, 11:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88506

  102. Benjamin Kott uploaded patch set 45 11/05/25, 11:19

  103. core-ci voted on patch set 44 V -1 11/05/25, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88508

  104. Benjamin Kott uploaded patch set 46 11/05/25, 11:28

  105. core-ci voted on patch set 45 V -1 11/05/25, 11:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88509

  106. Benjamin Kott uploaded patch set 47 11/05/25, 11:39

  107. core-ci voted on patch set 46 V -1 11/05/25, 11:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88510

  108. Benjamin Kott uploaded patch set 48 11/05/25, 11:47

  109. core-ci voted on patch set 47 V -1 11/05/25, 11:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88511

  110. core-ci voted on patch set 48 V -1 11/05/25, 12:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88514

  111. Benjamin Kott uploaded patch set 49 V -1 11/05/25, 12:06

  112. core-ci voted on patch set 49 V -1 11/05/25, 12:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88515

  113. Benjamin Kott uploaded patch set 50 V -1 11/05/25, 13:41

  114. core-ci voted on patch set 50 V -1 11/05/25, 13:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88519

  115. Benjamin Kott uploaded patch set 51 V -1 11/05/25, 14:01

  116. core-ci voted on patch set 51 V -1 11/05/25, 14:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88520

  117. Benjamin Kott uploaded patch set 52 V -1 11/05/25, 15:28

  118. Benjamin Kott commented on patch set 52 11/05/25, 15:29

    localization-wizard.ts:522 Reply

    Done

    confirm-step.ts:50 Reply

    Done

    LocalizationProviderInterface.php:21 Reply

    Done

    CopyProvider.php:55 Reply

    Done
  119. core-ci voted on patch set 52 V -1 11/05/25, 15:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88525

  120. Benjamin Kott uploaded patch set 53 V -1 11/05/25, 15:47

  121. Benjamin Kott updated the commit message in patch set 54 11/05/25, 15:51

  122. core-ci voted on patch set 53 V -1 11/05/25, 16:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88527

  123. core-ci voted on patch set 54 V -1 11/05/25, 16:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88528

  124. Benjamin Kott uploaded patch set 55 V -1 11/05/25, 16:05

  125. core-ci voted on patch set 55 V -1 11/05/25, 16:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88531

  126. Benjamin Kott uploaded patch set 56 V -1 11/05/25, 16:31

  127. core-ci voted on patch set 56 V -1 11/05/25, 16:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88533

  128. Benjamin Franzke commented on patch set 56 11/06/25, 09:35

    icons.ts:59

    Mark `@internal` for now and let's move as metadata into `@typo3/icons` at some point.
  129. Benjamin Franzke uploaded patch set 57 V -1 11/06/25, 09:57

  130. core-ci voted on patch set 57 V -1 11/06/25, 10:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88559

  131. Benjamin Franzke commented on patch set 57 11/06/25, 10:38

    localization-button.ts:21

    This button needs to transport additional module context information, to be used as hint for the translation-done-redirect target.

    localization-wizard.ts:47

    Try to use `unknown` instead of `any`.

    localization-wizard.ts:64

    Try to use `unknown` instead of `any`.

    localization-wizard.ts:219

    This should probably be a aria-live region.

    content-record-selection-step.ts:140

    content-record-selection-step.ts:171

    Try to use `unknown` instead of `any`.

    content-record-selection-step.ts:309

    Use live()

    handler-selection-step.ts:183

    Should use lit directive `live()` – may not be needed right now, but will be hard to detect, if the state is changed "externally" at some point.

    Services.yaml:68

    Note to myself: Migrate to use autoconfiguration.
  132. Benjamin Franzke uploaded patch set 58 V -1 11/06/25, 12:17

  133. Benjamin Franzke commented on patch set 58 11/06/25, 12:17

    localization-wizard.ts:47 Reply

    Done

    localization-wizard.ts:64 Reply

    Done

    localization-wizard.ts:219 Reply

    Done

    content-record-selection-step.ts:140 Reply

    Done

    content-record-selection-step.ts:171 Reply

    Done
  134. core-ci voted on patch set 58 V -1 11/06/25, 12:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88567

  135. Benjamin Franzke uploaded patch set 59 V -1 11/06/25, 13:58

  136. Benjamin Kott commented on patch set 59 11/06/25, 14:02

    localization-wizard.ts:635 Reply

    Done
  137. core-ci voted on patch set 59 V -1 11/06/25, 14:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88578

  138. Benjamin Franzke commented on patch set 59 11/07/25, 10:45

    localization-button.ts:28

    We do not want to handle this pseudo button behavior over and over again, please rebase on > 91214: [BUGFIX] Streamline pseudo button behavior | https://review.typo3.org/c/Packages/TYPO3.CMS/+/91214

    localization-button.ts:51

    noop

    localization-button.ts:56

    Makes no sense when render root is `this`.
  139. Benjamin Kott uploaded patch set 60 V -1 11/07/25, 17:41

  140. Benjamin Kott commented on patch set 60 11/07/25, 17:44

    LocalizationController.php:265

    when already having a connected mode with a translation from a language, and not having all elements translated. translating again and changing the source language can create a mixed mode. this is relevant for tt_content translations. we should think about that when a record for a language already exists we may need to prevent the translation source changed for a second one.
  141. core-ci voted on patch set 60 V -1 11/07/25, 17:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88664

  142. Benjamin Franzke uploaded patch set 61 V -1 11/08/25, 20:26

  143. Benjamin Franzke commented on patch set 61 11/08/25, 20:26

    icons.ts:59 Reply

    Done

    localization-button.ts:28 Reply

    Done

    localization-button.ts:51 Reply

    Done

    localization-button.ts:56 Reply

    Done

    content-record-selection-step.ts:309 Reply

    Done

    handler-selection-step.ts:183 Reply

    Done
  144. core-ci voted on patch set 61 V -1 11/08/25, 20:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88716

  145. Benjamin Kott uploaded patch set 62 V -1 11/10/25, 09:37

  146. Benjamin Kott commented on patch set 61 11/10/25, 09:37

    Services.yaml:68 Reply

    Done
  147. core-ci voted on patch set 62 V -1 11/10/25, 09:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88809

  148. Benjamin Kott uploaded patch set 63 V -1 11/10/25, 10:07

  149. Benjamin Kott uploaded patch set 64 11/10/25, 10:08

  150. Benjamin Kott commented on patch set 64 11/10/25, 10:15

    content-record-selection-step.ts:134 Reply

    i´ve checked additional options here i think the placement is the best we can do right now without using more space than we actually need. Also, the display is the best i can currently Imagine, due to the lack of better ideas. I´ve removed the color switching to keep it visually more stable and keep the intention the same. But for now, i would keep it like that, this is something we can adjust at a later point.
  151. Benjamin Kott commented on patch set 64 11/10/25, 10:15

    content-record-selection-step.ts:134 Reply

    Done
  152. core-ci voted on patch set 63 V -1 11/10/25, 10:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88816

  153. core-ci voted on patch set 64 V -1 11/10/25, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88817

  154. Benjamin Kott uploaded patch set 65 V -1 11/10/25, 14:27

  155. core-ci voted on patch set 65 V -1 11/10/25, 14:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88856

  156. Benjamin Kott uploaded patch set 66 V -1 11/10/25, 15:27

  157. core-ci voted on patch set 66 V -1 11/10/25, 15:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88868

  158. Benjamin Kott uploaded patch set 67 V -1 11/10/25, 16:08

  159. core-ci voted on patch set 67 V -1 11/10/25, 16:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88876

  160. Benni Mack commented on patch set 67 11/10/25, 20:51

    LocalizationController.php:186

    didn't we have this code in the Enum already?

    LocalizationController.php:482

    we can use $this->getLanguageService() instead of $GLOBALS[LANG]

    LocalizationMode.php:25

    This enum seems quite dirty. We have hidden dependencies to $GLOBALS[LANG] and TSconfig, which will never get out of this code anymore.

    ManualLocalizationHandler.php:232

    this only works when we have one element to translate. In addition, we have to check the permissions for web_layout + web_list unfortunately. This action feels a bit that we need to clarify the distinction between 1) a page with everything 2) a content element 3) multiple CEs 4) other records and how this can be configured / Steered. Maybe I don't get it 100%
  161. Oli Bartsch commented on patch set 67 11/10/25, 20:54

    NoopLocalizationFinisher.php:43

    Why not use `reload-finisher.js`?
  162. Benjamin Kott commented on patch set 67 11/11/25, 07:22

    NoopLocalizationFinisher.php:43 Reply

    even they share the same / reload. i wanted to keep it separated. to allow us to change display and behavior here.
  163. Benjamin Kott uploaded patch set 68 V -1 11/11/25, 07:38

  164. Benjamin Kott commented on patch set 68 11/11/25, 07:38

    LocalizationController.php:482 Reply

    Done
  165. core-ci voted on patch set 68 V -1 11/11/25, 07:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88944

  166. Benjamin Kott uploaded patch set 69 V -1 11/11/25, 07:55

  167. Benjamin Kott commented on patch set 69 11/11/25, 07:57

    LocalizationController.php:186 Reply

    Done

    LocalizationMode.php:25 Reply

    Done

    ManualLocalizationHandler.php:232 Reply

    currently you can only translate a single record at a time. the only difference here is that pages also translate it´s children.
  168. Oli Bartsch commented on patch set 68 11/11/25, 08:00

    content-record-selection-step.ts:57

    Here it behaves similar as described in the handler step but looks even more worse. In case I translate a page and use a language which does not have content, the select elements step is skipped but when going back it is displayed with zero records, having the toggles without any functionality.

    handler-selection-step.ts:28

    Sometimes this step is skipped on initially walking through the wizard. When going back in the wizard the step is shown (even if only one option available) and going back further, the step is then always displayed when moving forward again. Is this behaviour intended?

    AfterPageColumnsSelectedForLocalizationEvent.php:55

    We need to either keep this as noop or make this a breaking change.

    NoopLocalizationFinisher.php:30

    I still don't understand, why we need to step through the whole wizard to finally get a noop. In case I have localized a page already and afterwards go to translate content, but deselect all elements, in my opinion, this must then end the wizard "instantly". It makes no sense to show "Select localization mode" , etc.
  169. core-ci voted on patch set 69 V -1 11/11/25, 08:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88946

  170. Benjamin Kott commented on patch set 69 11/11/25, 08:31

    handler-selection-step.ts:28 Reply

    Each step depends on the selections made in previous steps, so the relevant data only becomes available when that step is rendered — and only if you’ve adjusted things accordingly. Our goal was to build a dependable, easy-to-follow workflow. That means some decisions can’t be made earlier because they rely on parameters we don’t yet have. Whether an action occurs is ultimately up to the handler, but the handler first needs the configuration set before it can decide to act. We deliberately chose the current back-navigation behavior: on the first run we skip steps that have only a single option to allow a fast-forward experience. But when the user navigates back, they must be able to see which steps were skipped and then click through each step individually.
  171. Benjamin Kott uploaded patch set 70 V -1 11/11/25, 10:18

  172. core-ci voted on patch set 70 V -1 11/11/25, 10:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88971

  173. Benjamin Kott uploaded patch set 71 V -1 11/11/25, 11:41

  174. core-ci voted on patch set 71 V -1 11/11/25, 11:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88988

  175. Benjamin Kott uploaded patch set 72 V -1 11/11/25, 12:53

  176. core-ci voted on patch set 72 V +1 11/11/25, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88994

  177. Benjamin Kott uploaded patch set 73 V +1 11/11/25, 13:38

  178. Benjamin Kott commented on patch set 73 11/11/25, 13:42

    NoopLocalizationFinisher.php:43 Reply

    Done
  179. Benjamin Kott uploaded patch set 74 11/11/25, 13:46

  180. Benjamin Kott commented on patch set 74 11/11/25, 13:48

    content-record-selection-step.ts:57 Reply

    see: https://review.typo3.org/c/Packages/TYPO3.CMS/+/90489/comment/340e5ff3_8b1de1e6/ the toggle button was removed when there are not elements that can be selected.
  181. core-ci voted on patch set 73 V +1 11/11/25, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89003

  182. core-ci voted on patch set 74 V +1 11/11/25, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89007

  183. Oli Bartsch commented on patch set 74 11/11/25, 16:32

    Finalized my in detail review. First off, this is already a solid piece of work with great architectural foundations. Especially handler/finisher extensibility is great and I also think that the separation between frontend and backend is clean. However there are a couple of things which still feel odd when navigating thourgh the wizard. I've added comments to the places where I thought they belong to. I also added a couple of notes regarding the PHP impelementation, since this can IMO be improved a lot with just a little bit of "extra" work.

    localization-wizard.ts:100

    While the store is typed as `Record<string, unknown>` there is no runtime type safety. While type augmentation provides hints, it doesn't prevent runtime type errors. The steps use `setValue(null as any)` to bypass type checking and there is also no validation that stored values match expected types. I suggest to use a proper typed interface or discriminated union: ``` interface WizardDataStore { targetLanguage?: number; sourceLanguage?: number; selectedRecordUids?: number[]; localizationMode?: string; localizationHandler?: string; } @state() private dataStore: WizardDataStore = {}; ```

    localization-wizard.ts:318

    should use `actions-arrow-end-alt`?

    localization-wizard.ts:332

    Moving forward works correctly as all intermediate steps are validated. backwards resets steps but doesn't properly reset internal flags like 'hasDispatchedAutoAdvance`. This causes "auto-advance" to fail when I go to Step 5 => back to Step 3 => forward to Step 5 again. Also the fact that steps with single options don't auto-advance on second pass is still kind of confusing ..

    localization-wizard.ts:404

    We should remove this element again in `disconnectedCallback()`

    content-record-selection-step.ts:65

    this manual tracking via those flags feels odd. Why not use lit's reactive model instead of manual dependency tracking? I mean `shouldRun` basically reimplements framework features. And this also leads to other problems already described, like rendering toggles with no action, e.g. when navigating back to this step with zero element available. Also auto-advance doesn't re-trigger prperly then.

    content-record-selection-step.ts:94

    This manual task re-run logic defeats the purpose of `@lit/task`. The `args` function should track the dependencies. alrdey.

    content-record-selection-step.ts:116

    When navigating backward to this step with zero elements, `hasDispatchedAutoAdvance` is still true (not reset) and auto-advance do not fire. So the buttons don't work.

    content-record-selection-step.ts:131

    IMO we should not render any selection in case no elements are to be selected.

    content-record-selection-step.ts:180

    Not quite sure but `setValue()` already calls `setStoreData()`, so this is redundant?

    finisher-step.ts:38

    When localization has happenend ("success" message is being displayed) and I "close" the modal by clicking out of the modal (not on finish and not the "x"). The finisher is not executed. So e.g. page is not reloaded. When I then open the wizard again I have a wrong state. If I try to localize the same element again (because it is offered to do so) I end up with: ``` Failed to complete localization: [1.6]: Localization failed: There already are localizations (XXXX) for language X of the "tt_content" record XXXX ```

    finisher-step.ts:73

    Let's use `TaskStatus` instead of those numbers.

    LocalizationController.php:55

    I highly suggest to split this into dedicated services, following single responsibility principle. This otherwise is just another god-like class. Suggestion: ``` LocalizationMetadataController - getRecord() - getTargets() - getSources() - getModes() LocalizationContentController - getContent() - Extract LayoutStructureBuilder as service LocalizationExecutionController - localize() - process() ```

    LocalizationController.php:72

    Actually we should IMO try to avoid those "helper" and rely on PSR-17 factories instead.

    LocalizationController.php:88

    Please always use Schema API for accessing TCA.

    LocalizationController.php:104

    We should add a factory method to the LocalizationContext DTO, sth. like `createFromRequest()`. This IMO should also implement some kind of input validation.

    LocalizationController.php:173

    Let's move this to a function. One Day(tm) we can then replace all those function by some service injection.

    LocalizationController.php:173

    This check is done at multiple places and could be moved to a dedicated method.

    LocalizationController.php:253

    Service should be injected.

    LocalizationController.php:265 Reply

    Yes please let's always prevent this. Maybe we can finally get rid of "mixed mode"...

    LocalizationController.php:304

    The above 40 lines are the same as in `getTargets()`, could/should be moved to a dedicated function.

    LocalizationController.php:331

    How does -1 end up here in the first place?

    LocalizationController.php:502

    We should extract all this layout structure stuff to a separate service. It has nothing to do with localization in the first place.

    LocalizationController.php:599

    If som, we should centralize this instead of duplicating code. However, since this should only check the mode, I think it is not necessary to do select calls. We should optimize this with count queries. sth. like: ``` // Check if ANY connected records exist (short-circuit) $hasConnected = (bool)$queryBuilder ->count('uid') ->from('tt_content') ->where( $queryBuilder->expr()->eq('pid', $pageId), $queryBuilder->expr()->eq($languageField, $targetLanguage), $queryBuilder->expr()->gt($transOrigPointerField, 0) ) ->setMaxResults(1) ->executeQuery() ->fetchOne(); // Only if connected found, check for free (to detect mixed) if ($hasConnected) { $hasFree = (bool)$queryBuilder ->count('uid') // ... eq($transOrigPointerField, 0) ->setMaxResults(1) ->executeQuery() ->fetchOne(); return $hasFree ? LocalizationMode::TRANSLATE : LocalizationMode::TRANSLATE; } // No connected, check if any free exist $hasFree = // ... same query return $hasFree ? LocalizationMode::COPY : null; ``` We could even improve this by adding some caching?

    LocalizationFinisherInterface.php:58

    It's not clear how the labels get into the frontend. Actually one would need to do this on their own if implementing custom finisher.

    NoopLocalizationFinisher.php:33

    Requiring calling code to pass such service eels wrong. The finishers should inject this on their own. Suggest to just use `$GLOBALS['LANG']`.

    ReloadLocalizationFinisher.php:33

    Maybe this is more an identifier than a "type"?

    LocalizationHandlerInterface.php:25

    Let's replace those getter for meta information via the AsLocalizationHandler Attribute.

    LocalizationHandlerInterface.php:68

    So this is the "main type", not the "record type", which would be "header" or "form_formframework". Will this ever be something else then the table name? If not, I suggest we name this `$tableName`.

    LocalizationHandlerInterface.php:76

    Please let's use a LocalizationContext DTO instead of all those parameters. This way we can add more info in the future without breaking the interface.

    LocalizationHandlerRegistry.php:48

    I think the functions body can be inlined in __construct

    LocalizationHandlerRegistry.php:60

    Should use `$this->hasHandler()`

    LocalizationHandlerRegistry.php:83

    Do you plan to add a configuration module provider? Otherwise I would remove this method to not encourage usage over `getAvailableHandlers()`

    LocalizationHandlerRegistry.php:101

    Here is also a good example why LocalizationContext makes sense.

    LocalizationMode.php:68

    What's the reason for those numbers? Why start with such "high" numbers?

    LocalizationResult.php:81

    What would be the use case for having success === TRUE and hasErrors !== []? IMO this is a misconfig and should throw an exception. $success is defined as "Whether the localization was successful" here.

    ManualLocalizationHandler.php:36

    Please let's register this via `AsLocalizationHandler` => ``` #[\Attribute(\Attribute::TARGET_CLASS)] class AsLocalizationHandler { public const TAG_NAME = 'backend.localization.handler'; public function __construct( public string $identifier, public string $$label = '', public string $description = '', public string $iconIdentifier = '', ) {} } ``` We should then register a CompilerPass which adds them to the registry using a LocalizationHandlerManifest. Check reactions for an example of such implementation.

    ManualLocalizationHandler.php:104

    Should we use some kind of error codes as array keys for better differentiation. Currently we just have string arrays..

    ManualLocalizationHandler.php:105

    use named parameter here as well?

    ManualLocalizationHandler.php:137

    Actually, those errors from DH are often not suited for display to the user. We might want to add some kind of `transformErrorMessage`?

    ManualLocalizationHandler.php:170

    ```suggestion if (empty($pageTranslations)) { ``` let's remove `!$pageTranslationExists` as this is double negated and really hard to read.

    ManualLocalizationHandler.php:176

    We should somehow handle the fact that a user actively selected e.g. "copy" in the wizard. What I want to say, we maybe should skip the mode selection for pages translations only (when no content is affected) as this might be misleading otherwise.

    ManualLocalizationHandler.php:193

    I still think that this is bad UX wise. as user who wants to translate pages that already exists, opening the wizard and deselecting all content elements has to click through 7 steps to accomplish nothing.

    ManualLocalizationHandler.php:212

    This doesn't look right.

    ManualLocalizationHandler.php:226

    Localization request might has been triggered in record list. We preserve this in the LocalizationContext object.

    ManualLocalizationHandler.php:250

    Why `web_list` without any additional context?

    DatabaseRecordList.php:2212

    Could we use ComponentFactory?

    AjaxRoutes.php:401

    Why is this inherited? I think the wizard is not bound to web_layout?
  184. Benjamin Kott uploaded patch set 75 V +1 11/12/25, 09:11

  185. Benjamin Kott commented on patch set 74 11/12/25, 09:11

    localization-wizard.ts:318 Reply

    Done

    localization-wizard.ts:332 Reply

    this is as mentioned a design decision; it should not auto advance when a step previously has advanced, it works as expected.

    localization-wizard.ts:404 Reply

    Done

    content-record-selection-step.ts:116 Reply

    as mentioned this is by design

    finisher-step.ts:73 Reply

    Done

    AjaxRoutes.php:401 Reply

    Done
  186. core-ci voted on patch set 75 V +1 11/12/25, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89179

  187. Oli Bartsch commented on patch set 75 11/12/25, 09:42

    content-record-selection-step.ts:116 Reply

    I understand the auto-advance decision. But rendering a non working button can not be intended.
  188. Benjamin Kott uploaded patch set 76 V +1 11/12/25, 09:44

  189. Benjamin Kott commented on patch set 75 11/12/25, 09:44

    LocalizationFinisherInterface.php:58 Reply

    Done

    NoopLocalizationFinisher.php:33 Reply

    Done
  190. core-ci voted on patch set 76 V -1 11/12/25, 09:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89223

  191. Benjamin Kott uploaded patch set 77 V -1 11/12/25, 11:19

  192. Benjamin Kott commented on patch set 76 11/12/25, 11:19

    localization-wizard.ts:100 Reply

    previously the store could handle any was configure from the PHP side. As we hardcode the steps for now, we can also adjust the interface.

    DatabaseRecordList.php:2212 Reply

    would not just use the component factory because we can, would keep it like that.
  193. core-ci voted on patch set 77 V -1 11/12/25, 11:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89277

  194. Benjamin Kott uploaded patch set 78 V -1 11/12/25, 11:35

  195. Benjamin Kott commented on patch set 77 11/12/25, 11:36

    content-record-selection-step.ts:180 Reply

    currently it´s still needed for the wizard to work - would need further investigation - i removed the todo for now.

    handler-selection-step.ts:28 Reply

    Done
  196. core-ci voted on patch set 78 V -1 11/12/25, 11:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89291

  197. Benjamin Kott commented on patch set 78 11/12/25, 11:45

    content-record-selection-step.ts:116 Reply

    The toggle button was removed, and autoadvance is disabled by design when navigating back, it´s only triggered the first time when a step can be skipped. All buttons back and next work as intended.
  198. Benjamin Kott uploaded patch set 79 V -1 11/12/25, 11:50

  199. Benjamin Kott commented on patch set 78 11/12/25, 11:50

    finisher-step.ts:38 Reply

    It is intended that you can skip the finalize action and avoid beeing redirected or having the view refreshed. i´ve set the modal to static so you need to close the x button or press escape to avoid accidental closing.

    LocalizationController.php:55 Reply

    this feels like over abstraction for now. we still need to figure out where this path is going, splitting this now for the sake of splitting seems not nessesary.
  200. Benjamin Kott commented on patch set 79 11/12/25, 11:52

    ManualLocalizationHandler.php:232 Reply

    as mentioned, we only support a single record for now.
  201. Benjamin Kott commented on patch set 79 11/12/25, 11:54

    localization-button.ts:21 Reply

    As discussed, we will move this to further enhancements down the road. We will start with predefined targets for now.

    CopyProvider.php:171 Reply

    Done

    CopyProvider.php:187 Reply

    Done

    CopyProvider.php:203 Reply

    Done
  202. core-ci voted on patch set 79 V -1 11/12/25, 11:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89293

  203. Benjamin Kott uploaded patch set 80 V -1 11/12/25, 12:03

  204. core-ci voted on patch set 80 V +1 11/12/25, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89305

  205. Jasmina Ließmann wrote 11/12/25, 12:18

    Removed cc Jasmina Ließmann.
  206. Benjamin Kott uploaded patch set 81 V +1 11/12/25, 13:15

  207. Benjamin Kott commented on patch set 80 11/12/25, 13:16

    ReloadLocalizationFinisher.php:33 Reply

    Done

    ManualLocalizationHandler.php:36 Reply

    i do not see a benefit here, the code gets way more complex and i see no benefit, as they need to be available all the time.

    ManualLocalizationHandler.php:170 Reply

    Done

    ManualLocalizationHandler.php:176 Reply

    i think this is a problem in the current behavior and cannot be solved here. it´s a general question why the page needs to be always localized. i think it´s fine we keep the current state for now, as the user currently does the same selection. We should have a look at a later point why we cannot respect the users choice here.

    ManualLocalizationHandler.php:193 Reply

    this is an edge case, that`s not clear on behavior, even we are currently returning a noop, a different handler could do something different here. for the case where no translation is possible, the button should not be available.

    ManualLocalizationHandler.php:212 Reply

    Done

    ManualLocalizationHandler.php:250 Reply

    Done
  208. Benjamin Kott uploaded patch set 82 11/12/25, 13:24

  209. Benjamin Kott commented on patch set 82 11/12/25, 13:25

    LocalizationHandlerInterface.php:25 Reply

    Done

    LocalizationHandlerRegistry.php:60 Reply

    Done

    LocalizationHandlerRegistry.php:83 Reply

    dropped as it is unused currently.

    LocalizationMode.php:68 Reply

    liked to start higher, to have more room, as this is not extensible - i reduced them to 10/20

    LocalizationResult.php:81 Reply

    Acknowledged
  210. core-ci voted on patch set 81 V -1 11/12/25, 13:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89318

  211. core-ci voted on patch set 82 V -1 11/12/25, 13:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89322

  212. Benjamin Kott uploaded patch set 83 V -1 11/12/25, 13:43

  213. Benjamin Kott commented on patch set 82 11/12/25, 13:43

    Reply

    Acknowledged

    content-record-selection-step.ts:131 Reply

    Done

    LocalizationController.php:88 Reply

    Done

    LocalizationController.php:253 Reply

    Done

    LocalizationHandlerRegistry.php:48 Reply

    Done
  214. core-ci voted on patch set 83 V -1 11/12/25, 13:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89327

  215. Benjamin Kott uploaded patch set 84 V -1 11/12/25, 14:26

  216. Benjamin Kott commented on patch set 83 11/12/25, 14:27

    LocalizationController.php:173 Reply

    Done

    LocalizationController.php:173 Reply

    i would opt int to keep it like that for now, as it´s also returning the page and not only checks for the access, I've switched to the Permission bitmask to better show what is actually checked. i am not aware we have a better api to only check for access without retrieving the record. even naming would be hard, usually you would like to have a simple "hasAccess" check and then retrieve the nessesary data. as i´ts mixed for now a function would be hard to name and i rather avoid it. moving it to a function would require to check the access first and then retrieve the record so we only evaluate the access and split it from the record fetching.

    LocalizationController.php:502 Reply

    we have similar functionality buried across the codebase, that is not reusable, it would have been another i need to cleanup task to make it reusable that i tried to avoid here. i kept it here so we do not have to tackle this task right now. In general, i agree we should have better architecture here and we need to clean this up at some point and unify all the renderings. this should be done when we touch the page module, as we need to rebuild the structure to improve the rendering.

    LocalizationController.php:599 Reply

    i´ve simplified it to a single query and checking the results afterwards.
  217. core-ci voted on patch set 84 V -1 11/12/25, 14:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89338

  1. Benjamin Kott uploaded patch set 85 V -1 11/12/25, 14:50

  2. Benjamin Kott commented on patch set 84 11/12/25, 14:50

    AfterPageColumnsSelectedForLocalizationEvent.php:55 Reply

    i´ve reverted the changes here. we are not using them to render the view, it will not make a difference if we keep them in the event or not.

    LocalizationHandlerInterface.php:68 Reply

    i would really like to avoid talking about $tableNames, if feels not good.

    ManualLocalizationHandler.php:104 Reply

    i think we should not adjust this for now, i agree that errorcodes, exceptions could be better - but we would need to introduce them systemwide to make any sense. this should be a task on its own. i would keep it like that for now and take care of this as soon as we check how datahandler reports errors or we create new entrypoints for the translation aside from datahandler.

    ManualLocalizationHandler.php:105 Reply

    Done

    ManualLocalizationHandler.php:137 Reply

    usually the user should not be confronted with an error, as we try to catch most of them in advance, we do not have a strategy how to handle this correctly. just transforming datahandler errors is also not helpful - so for the time beeing i would keep it like that.
  3. core-ci voted on patch set 85 V -1 11/12/25, 15:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89345

  4. Oli Bartsch commented on patch set 85 11/12/25, 15:20

    LocalizationHandlerInterface.php:68 Reply

    fine for me but we should at least correct the description. It's the "main type".
  5. Benni Mack commented on patch set 85 CR -1 11/12/25, 19:45

    on it
  6. Benni Mack uploaded patch set 86 CR -1 V -1 11/12/25, 20:15

  7. Benni Mack commented on patch set 86 11/12/25, 20:16

    LocalizationController.php:72 Reply

    Should be done separately. IMHO we should build our own response factory.

    LocalizationController.php:104 Reply

    Done

    LocalizationHandlerInterface.php:68 Reply

    Done

    LocalizationHandlerInterface.php:76 Reply

    Done

    LocalizationHandlerRegistry.php:101 Reply

    Done

    ManualLocalizationHandler.php:226 Reply

    I suggest to add this separately
  8. Benni Mack commented on patch set 86 11/12/25, 20:16

    LocalizationController.php:72 Reply

    Done
  9. Benni Mack voted on patch set 86 CR +1 V +1 11/12/25, 20:18

  10. core-ci voted on patch set 86 V -1 11/12/25, 20:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89396

  11. Benni Mack uploaded patch set 87 CR +1 V +1 11/12/25, 21:23

  12. core-ci voted on patch set 87 V +1 11/12/25, 21:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89403

  13. Benni Mack voted on patch set 87 CR +1 V +1 11/12/25, 22:37

  14. Benjamin Kott commented on patch set 87 11/13/25, 07:02

    content-record-selection-step.ts:65 Reply

    the navigation of the steps is working as intended, i´ve had a long discussion with bnf and this section would need more review and is actively tracking for changes itself. while it could be possible to handle it via the task - we faced problems before because lit does not detect changes in objects. in other instances we needed to add proxies to objects to have the rendering handled in one way or the other correctly by lit. we will keep the current solution for now as it´s working as intended.
  15. Benjamin Kott commented on patch set 87 11/13/25, 07:02

    content-record-selection-step.ts:94 Reply

    Acknowledged
  16. Benjamin Kott uploaded patch set 88 CR +1 V +1 11/13/25, 11:58

  17. Benjamin Kott commented on patch set 88 11/13/25, 11:58

    LocalizationController.php:265 Reply

    Done

    LocalizationController.php:304 Reply

    Acknowledged

    LocalizationController.php:331 Reply

    Acknowledged
  18. core-ci voted on patch set 88 V +1 11/13/25, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89484

  19. Benjamin Franzke commented on patch set 88 CR +1 V +1 11/13/25, 13:52

    localization.ts:14

    I'm not sure whether it's good to have the button available globally, since dependencies should be explicit. But that is a detail, that we can change – and there are more details that *could* be done differently, but I think this patch is already in a very good shape and way to big and it doesn't help to apply another 20 patchsets. Instead we should get it in, knowing there will still be some rough edges, but we should collect that in "public" review via `main` branch…
  20. Andreas Kienast uploaded patch set 89 CR +1 V +1 11/14/25, 06:44

  21. Andreas Kienast commented on patch set 89 CR +1 V +1 11/14/25, 06:44

    LocalizationController.php:457

    Note: `$backendLayout` might be `null` here.
  22. core-ci voted on patch set 89 V +1 11/14/25, 06:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89650

  23. Benjamin Franzke voted on patch set 89 CR +1 V +1 11/14/25, 07:12

  24. Benni Mack voted on patch set 89 CR +2 V +2 11/14/25, 07:13

  25. Benni Mack merged patch set 90 11/14/25, 07:13