90491[DOCS] Mark up BE template API examples as code
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Oliver Klee +1
-
Verified V +2 Done
- Garvin Hicking +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 12
- typo3/sysext/backend/Classes/Template/Components/Buttons/Action/ShortcutButton.php4+3 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/DropDownDivider.php+4 −0
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/DropDownHeader.php+4 −0
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/DropDownItem.php+4 −0
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/DropDownRadio.php+3 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/DropDownToggle.php+4 −0
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDownButton.php+4 −0
- typo3/sysext/backend/Classes/Template/Components/Buttons/FullyRenderedButton.php+3 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/GenericButton.php+4 −0
- typo3/sysext/backend/Classes/Template/Components/Buttons/InputButton.php+3 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/LinkButton.php+3 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/SplitButton.php+3 −1
Review log 1518
-
Mathias Brodala uploaded patch set 1 08/27/25, 08:22
-
Oliver Klee voted on patch set 1 CR +1 V +1 08/27/25, 08:24
-
Lina Wolf voted on patch set 1 CR +1 V +1 08/27/25, 08:26
-
Oliver Klee commented on patch set 1 08/27/25, 08:27
-
core-ci voted on patch set 1 V +1 08/27/25, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83895
-
Mathias Brodala commented on patch set 1 08/27/25, 08:30
ShortcutButton.php:42ReplyI wouldn't mind unless someone objects. I'd assume the default code role to be "php" on api.typo3.org though. -
Lina Wolf commented on patch set 1 08/27/25, 08:32
ShortcutButton.php:42ReplyIt is possible but unnessesary as we assume PHP to be the default language It would be advisable to do this with other languages like JavaScript or TypoScript however. -
Garvin Hicking commented on patch set 1 08/27/25, 08:43
I would prefer to label this as DOCS or TASK as it doesn't affect TYPO3 as code. -
Oli Bartsch commented on patch set 1 08/27/25, 08:46
Reply
Yes, no bugfix I think. -
Oliver Klee commented on patch set 1 08/27/25, 08:54
ShortcutButton.php:42ReplyAcknowledged -
Mathias Brodala updated the commit message in patch set 2
CR +1V +108/27/25, 09:37 -
core-ci voted on patch set 2 V +1 08/27/25, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83898
-
Garvin Hicking updated the commit message in patch set 3
V +108/27/25, 09:53 -
Garvin Hicking commented on patch set 3 CR +1 V +1 08/27/25, 09:54
Reply
I think for the API docs we also would need 13.4 and 12.4 backports to render them properly on supported LTS versions, sorry 😅 - changed accordingly already. -
Oliver Klee voted on patch set 3 CR +1 V +1 08/27/25, 09:55
-
core-ci voted on patch set 3 V +1 08/27/25, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83899
-
Garvin Hicking voted on patch set 3 CR +2 V +2 08/27/25, 16:07
-
Garvin Hicking merged patch set 4 08/27/25, 16:07
ShortcutButton.php:42