Review 13.4 Merged

90501[TASK] Enhance Extbase file upload consistency checks

Oliver Hader CR +2 V +2 Hard +271 −48 updated 08/28/25, 19:03

Commit message

The file upload handling has a `MimeTypeValidator` which internally
also performs a file extension to mime-type consistency check.
However, in case the `mimeType` validator is not explicitly set,
the consistency check won't be executed either.

This change introduces the `FileExtensionMimeTypeConsistencyValidator`
which performs a generic file extension to mime-type consistency check
(in contrast, `MimeTypeValidator` would compare the assumed mime-types
to the configured allowed mime-types additionally).

In addition the `FileExtensionValidator` is added, allowing to check
for specific file extensions. This is considered a missing feature.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 2

Files 10

Review log 34

  1. Oliver Hader uploaded patch set 1 08/28/25, 18:55

  2. core-ci voted on patch set 1 V +1 08/28/25, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83942

  3. Oliver Hader voted on patch set 1 CR +2 V +2 08/28/25, 19:02

  4. Oliver Hader merged patch set 2 08/28/25, 19:03