Review main Merged

90511[BUGFIX] Always clone policy in CSP's Policy::prepare

Oliver Hader CR +2 V +2 Easy +0 −5 updated 08/29/25, 16:46

Commit message

`\TYPO3\CMS\Core\Security\ContentSecurityPolicy\Policy::prepare`
had an optimization to only clone the policy in case directives
have been purged.

Other additional adjustments for `SourceKeyword::strictDynamic`
were not applied unless a directive has been purged before.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Markus Klein +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Markus Klein +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oliver Hader uploaded patch set 1 08/29/25, 15:08

  2. core-ci voted on patch set 1 V +1 08/29/25, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83997

  3. Benni Mack voted on patch set 1 CR +1 V +1 08/29/25, 15:19

  4. Markus Klein voted on patch set 1 CR +1 V +1 08/29/25, 15:38

  5. Oliver Hader voted on patch set 1 CR +2 V +2 08/29/25, 16:45

  6. Oliver Hader merged patch set 2 08/29/25, 16:46