90514[FEATURE] Introduce Fluid page title ViewHelper
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 7
- typo3/sysext/core/Classes/PageTitle/RecordTitleProvider.phprenamed+1 −3
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-106232-ProvideRecordTitleProvider.rstrenamed+5 −5
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107358-IntroduceFluidPageTitleViewHelper.rst3new+52 −0
- typo3/sysext/core/ext_localconf.php+9 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Page/TitleViewHelper.phpnew+43 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Page/TitleViewHelperTest.phpnew+93 −0
- typo3/sysext/seo/ext_localconf.php1+0 −4
Review log 2127
Show 12 earlier messages
-
Benni Mack uploaded patch set 1 08/29/25, 16:31
-
core-ci voted on patch set 1 V +1 08/29/25, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84001
-
Oliver Hader voted on patch set 1 CR +1 08/29/25, 16:54
-
Oliver Hader commented on patch set 1 08/29/25, 17:16
I guess it should be noted, that new page-title providers need to be registered via TypoScript, e.g. ``` config.pageTitleProviders.fluidPageTitle { provider = TYPO3\CMS\Fluid\PageTitle\FluidPageTitleProvider before = recordTitle,seo,record } ``` -
Oliver Hader commented on patch set 1 08/29/25, 17:16
Reply
(unresolve) -
Chris Müller commented on patch set 1 09/01/25, 15:11
Feature-107358-IntroduceFluidPageTitleViewHelper.rst:44Since v14 a generic "RecordTitleProvider" is available, so no need to create a custom one for each extension anymore: Maybe this should be mentioned here as an alternative for achieving the same programatically (and vice versa)? https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/14.0/Feature-106232-ProvideSEORecordTitleProvider.html#feature-106232-provide-seo-record-title-provider -
Benni Mack commented on patch set 1 09/01/25, 15:12
Feature-107358-IntroduceFluidPageTitleViewHelper.rst:44Replymain problem with this one is that it is currently within EXT:seo... maybe we need to move it then? -
Benni Mack uploaded patch set 2
CR +1V +109/02/25, 06:13 -
core-ci voted on patch set 2 V -1 09/02/25, 06:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84216
-
Benni Mack uploaded patch set 3
V -109/02/25, 06:41 -
core-ci voted on patch set 3 V -1 09/02/25, 06:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84217
-
Benni Mack commented on patch set 4
V -109/02/25, 07:02Published edit on patch set 3. -
Benni Mack commented on patch set 5 09/02/25, 07:04
Published edit on patch set 4. -
core-ci voted on patch set 4 V +1 09/02/25, 07:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84221
-
core-ci voted on patch set 5 V +1 09/02/25, 07:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84222
-
Benni Mack commented on patch set 5 09/02/25, 07:24
Reply
DoneFeature-107358-IntroduceFluidPageTitleViewHelper.rst:44Replymoved it -
Stefan Bürk voted on patch set 5 CR +1 09/02/25, 08:15
-
Stefan Bürk voted on patch set 5 V +1 09/02/25, 08:41
-
Garvin Hicking commented on patch set 6
CR +1V +109/02/25, 11:04Published edit on patch set 5. -
Garvin Hicking voted on patch set 6 CR +1 09/02/25, 11:05
-
Stefan Bürk voted on patch set 6 CR +1 V +1 09/02/25, 11:05
-
core-ci voted on patch set 6 V +1 09/02/25, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84238
-
Garvin Hicking voted on patch set 6 V +1 09/02/25, 16:31
-
Benni Mack voted on patch set 6 CR +2 V +2 09/02/25, 16:33
-
Benni Mack merged patch set 7 09/02/25, 16:33
-
Lina Wolf commented on patch set 7 09/06/25, 09:13
Review of documentation would be helpful: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/pull/6004 https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-ViewHelper/pull/173 -
Lina Wolf commented on patch set 7 09/06/25, 09:24
ext_localconf.php:40UnresolvedIt seems like currently the order is not strictly dedefined as both seo and recordTitle have record in their `before` parameter. Should we not set this to seo { before = recordTitle } To have a clear definition of how these are ordered?