Review main Merged

90514[FEATURE] Introduce Fluid page title ViewHelper

Benni Mack CR +2 V +2 Normal +203 −15 updated 04/21/26, 15:04

Commit message

Extbase plugins can now set page titles directly from
their Fluid templates using <f:page.title>, eliminating
the need for custom Page Title Providers in detail views.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 2127

Show 12 earlier messages
  1. Benni Mack uploaded patch set 1 08/29/25, 16:31

  2. core-ci voted on patch set 1 V +1 08/29/25, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84001

  1. Oliver Hader voted on patch set 1 CR +1 08/29/25, 16:54

  2. Oliver Hader commented on patch set 1 08/29/25, 17:16

    I guess it should be noted, that new page-title providers need to be registered via TypoScript, e.g. ``` config.pageTitleProviders.fluidPageTitle { provider = TYPO3\CMS\Fluid\PageTitle\FluidPageTitleProvider before = recordTitle,seo,record } ```
  3. Oliver Hader commented on patch set 1 08/29/25, 17:16

    Reply

    (unresolve)
  4. Chris Müller commented on patch set 1 09/01/25, 15:11

    Feature-107358-IntroduceFluidPageTitleViewHelper.rst:44

    Since v14 a generic "RecordTitleProvider" is available, so no need to create a custom one for each extension anymore: Maybe this should be mentioned here as an alternative for achieving the same programatically (and vice versa)? https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/14.0/Feature-106232-ProvideSEORecordTitleProvider.html#feature-106232-provide-seo-record-title-provider
  5. Benni Mack commented on patch set 1 09/01/25, 15:12

    Feature-107358-IntroduceFluidPageTitleViewHelper.rst:44 Reply

    main problem with this one is that it is currently within EXT:seo... maybe we need to move it then?
  6. Benni Mack uploaded patch set 2 CR +1 V +1 09/02/25, 06:13

  7. core-ci voted on patch set 2 V -1 09/02/25, 06:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84216

  8. Benni Mack uploaded patch set 3 V -1 09/02/25, 06:41

  9. core-ci voted on patch set 3 V -1 09/02/25, 06:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84217

  10. Benni Mack commented on patch set 4 V -1 09/02/25, 07:02

    Published edit on patch set 3.
  11. Benni Mack commented on patch set 5 09/02/25, 07:04

    Published edit on patch set 4.
  12. core-ci voted on patch set 4 V +1 09/02/25, 07:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84221

  13. core-ci voted on patch set 5 V +1 09/02/25, 07:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84222

  14. Benni Mack commented on patch set 5 09/02/25, 07:24

    Reply

    Done

    Feature-107358-IntroduceFluidPageTitleViewHelper.rst:44 Reply

    moved it
  15. Stefan Bürk voted on patch set 5 CR +1 09/02/25, 08:15

  16. Stefan Bürk voted on patch set 5 V +1 09/02/25, 08:41

  17. Garvin Hicking commented on patch set 6 CR +1 V +1 09/02/25, 11:04

    Published edit on patch set 5.
  18. Garvin Hicking voted on patch set 6 CR +1 09/02/25, 11:05

  19. Stefan Bürk voted on patch set 6 CR +1 V +1 09/02/25, 11:05

  20. core-ci voted on patch set 6 V +1 09/02/25, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84238

  21. Garvin Hicking voted on patch set 6 V +1 09/02/25, 16:31

  22. Benni Mack voted on patch set 6 CR +2 V +2 09/02/25, 16:33

  23. Benni Mack merged patch set 7 09/02/25, 16:33

  24. Lina Wolf commented on patch set 7 09/06/25, 09:24

    ext_localconf.php:40 Unresolved

    It seems like currently the order is not strictly dedefined as both seo and recordTitle have record in their `before` parameter. Should we not set this to seo { before = recordTitle } To have a clear definition of how these are ordered?