90515[FEATURE] Introduce BeforePersistingReportEvent for CSP violations
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Garvin Hicking +1
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Garvin Hicking +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Middleware/AbstractContentSecurityPolicyReporter.php+11 −3
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/Event/BeforePersistingReportEvent.php2new+44 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-102079-IntroduceBeforePersistingReportEventForCSPViolations.rstnew+85 −0
- typo3/sysext/core/Tests/Functional/Security/ContentSecurityPolicy/Reporting/BeforePersitingReportEventTest.phpnew+196 −0
- typo3/sysext/core/Tests/Unit/Security/ContentSecurityPolicy/Event/BeforePersistingReportEventTest.phpnew+94 −0
Review log 2027
Show 2 earlier messages
-
core-ci voted on patch set 2 V +1 08/29/25, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84006
-
Oliver Hader uploaded patch set 3
V +108/29/25, 17:29 -
core-ci voted on patch set 3 V +1 08/29/25, 17:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84009
-
Simon Schaufelberger commented on patch set 3 08/29/25, 21:52
-
Oliver Hader uploaded patch set 4
V +108/30/25, 08:23 -
Oliver Hader commented on patch set 4 08/30/25, 08:23
BeforePersistingReportEvent.php:36ReplyThanks. I've adjusted the comments. -
core-ci voted on patch set 4 V +1 08/30/25, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84043
-
Simon Schaufelberger voted on patch set 4 CR +1 V +1 08/30/25, 10:39
-
Georg Ringer voted on patch set 4 CR +1 V +1 08/30/25, 14:36
-
Garvin Hicking commented on patch set 4 08/30/25, 15:37
Maybe add an event test like for the other PSR-14 additions? -
Georg Ringer uploaded patch set 5
CR +1V +102/07/26, 09:09 -
core-ci voted on patch set 5 V +1 02/07/26, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95375
-
Benni Mack uploaded patch set 6
V +102/18/26, 21:30 -
Benni Mack commented on patch set 6 CR +1 V +1 02/18/26, 21:30
Reply
Done -
core-ci voted on patch set 6 V +1 02/18/26, 21:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96194
-
Garvin Hicking commented on patch set 6 CR -1 02/19/26, 06:14
Reply
Hang on, I meant a test that checks the event is actually dispatched and the "outer" workflow works, nit nust a getter/setter DTO test. I'll add one. -
Garvin Hicking uploaded patch set 7
CR +1V +102/19/26, 09:40 -
Garvin Hicking commented on patch set 7 CR +1 V +1 02/19/26, 09:44
Reply
I added a functional test for what I meant. That was more complex than anticipated because I have to jump through the middleware hoops and abstract class implementation. But I'd argue this is very helpful to now have the abstract class be subject to a proper test. Due to this I also found out that the wrong $report was actually persisted, which is now fixed :-D -
core-ci voted on patch set 7 V -1 02/19/26, 09:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96223
-
Garvin Hicking uploaded patch set 8
CR +1V +102/19/26, 10:06fix namespace -
core-ci voted on patch set 8 V +1 02/19/26, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96225
-
Benni Mack voted on patch set 8 CR +1 V +1 02/19/26, 10:19
-
Garvin Hicking voted on patch set 8 CR +1 V +1 02/19/26, 10:26
-
Oliver Hader commented on patch set 8 CR +2 V +2 02/19/26, 13:36
Thx folks 😊 -
Oliver Hader merged patch set 9 02/19/26, 13:36
BeforePersistingReportEvent.php:36