Review main Merged

90518[FEATURE] Introduce Fluid page meta ViewHelper

Benni Mack CR +2 V +2 Hard +353 −0 updated 11/15/25, 13:07

Commit message

Extbase plugins can now set meta tags directly from
their Fluid templates using `<f:page.meta>`, utilizing
TYPO3's MetaTagManager API for SEO optimization.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Lina Wolf +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Lina Wolf +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1216

  1. Benni Mack uploaded patch set 1 08/29/25, 17:21

  2. core-ci voted on patch set 1 V -1 08/29/25, 17:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84008

  3. Garvin Hicking commented on patch set 1 08/29/25, 17:48

    Feature-107359-IntroduceFluidPageMetaViewHelper.rst:35

    I believe we wouldcneed to call it "X / Twitter" here, like in thr SEO docs?
  4. Georg Ringer commented on patch set 1 08/30/25, 14:07

    this is not really related to extbase only? could also be used by e.g. userfunc or in the page template using pageview?
  5. Garvin Hicking rebased onto patch set 2 V -1 11/14/25, 20:00

  6. Garvin Hicking commented on patch set 3 11/14/25, 20:01

    Published edit on patch set 2.
  7. Garvin Hicking commented on patch set 3 11/14/25, 20:01

    Feature-107359-IntroduceFluidPageMetaViewHelper.rst:35 Reply

    Done
  8. Garvin Hicking commented on patch set 3 11/14/25, 20:02

    Reply

    I would argue this is differentiated enough with "This is especially useful in Extbase", so that doesn't say it's exclusively in extbase context.
  9. core-ci voted on patch set 2 V -1 11/14/25, 20:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89722

  10. core-ci voted on patch set 3 V -1 11/14/25, 20:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89723

  11. Garvin Hicking uploaded patch set 4 V -1 11/14/25, 21:02

  12. core-ci voted on patch set 4 V +1 11/14/25, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89727

  13. Garvin Hicking voted on patch set 4 CR +1 V +1 11/14/25, 21:15

  14. Lina Wolf commented on patch set 4 CR +1 V +1 11/15/25, 09:14

    I tried this out with a custom site package and it worked well. Code looks good
  15. Garvin Hicking voted on patch set 4 CR +2 V +2 11/15/25, 13:06

  16. Garvin Hicking merged patch set 5 11/15/25, 13:07