Review main Merged

90520[TASK] Add request to ModifyNewContentElementWizardItemsEvent

Sebastian Fischer CR +2 V +2 Easy +23 −1 updated 09/02/25, 11:51

Commit message

With this it's now possible to modify wizard items based on
values from queryParams in the request object. This is usefull
if you want to add dynamic defaultValues similar to the
tt_content_defValues in the TSconfig wizardItem config.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 912

  1. Sebastian Fischer uploaded patch set 1 08/29/25, 19:04

  2. core-ci voted on patch set 1 V +1 08/29/25, 19:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84014

  3. Simon Schaufelberger commented on patch set 1 08/29/25, 20:21

    What speaks against getting the request via `$GLOBALS['TYPO3_REQUEST']`? if people want to do something with the request, then other events should also be adjusted but since the `$GLOBALS['TYPO3_REQUEST']` is always(?) available, this shouldn't be a problem and getting the request via globals is not deprecated or dirty.
  4. Benni Mack updated the commit message in patch set 2 V +1 08/31/25, 11:28

  5. Benni Mack commented on patch set 2 08/31/25, 11:28

    I took the liberty of adding the request as a "task" at it is not a feature IMHO.
  6. core-ci voted on patch set 2 V +1 08/31/25, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84090

  7. Garvin Hicking commented on patch set 3 V +1 08/31/25, 19:54

    Published edit on patch set 2.
  8. core-ci voted on patch set 3 V +1 08/31/25, 20:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84101

  9. Benni Mack voted on patch set 3 CR +1 V +1 09/02/25, 10:04

  10. Stefan Bürk commented on patch set 3 CR +1 V +1 09/02/25, 11:23

    Reply

    `$GLOBALS['TYPO3_REQUEST']` is not deprecated yet, right. However, it was always a workaround for the meanwhile to access it where it has not been passed down but makes sense to access. It make sense to hand it over in events, specially when the dispatching part has the request available, and use-cases exists to make request based decisions in a connected event listener. You are correct that other PSR-14 may also benefit from addint the request as part of the event, which raises up if use-cases are there for it and dispatching code has it already available. > What speaks against getting the request $GLOBALS['TYPO3_REQUEST'] .. Nothing (yet) and it also does not speak anything against adding/passing it as part of the event. Adding it is a good thing to allo reducing usage of the global access. Special for sub-request handling that may be important and overall at some point the global needs to vanish - but that will still take a lot more time to have the request everywhere it make sense. The global is in place in case it is not available otherwise, requesting to add it is a valid use case. Resolving this comment now.
  11. Stefan Bürk voted on patch set 3 CR +2 V +2 09/02/25, 11:30

  12. Stefan Bürk merged patch set 4 09/02/25, 11:51