Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
90533[!!!][WIP][FEATURE] Store OnlineMedia preview images in FAL storage
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 2
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/33/90533/2 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/33/90533/2 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Files 9
- typo3/sysext/core/Classes/Resource/OnlineMedia/Helpers/AbstractOnlineMediaHelper.php1+132 −0
- typo3/sysext/core/Classes/Resource/OnlineMedia/Helpers/OnlineMediaHelperInterface.php1+25 −0
- typo3/sysext/core/Classes/Resource/OnlineMedia/Helpers/VimeoHelper.php+25 −0
- typo3/sysext/core/Classes/Resource/OnlineMedia/Helpers/YouTubeHelper.php+27 −0
- typo3/sysext/core/Classes/Resource/OnlineMedia/Processing/PreviewProcessing.php+12 −1
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-12345-OnlineMediaHelperInterfaceExtended.rstnew+112 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-12345-OnlineMediaPreviewImagesInFAL.rstnew+74 −0
- typo3/sysext/core/ext_tables.sql+10 −1
- typo3/sysext/install/Classes/Updates/OnlineMediaPreviewMigrationUpgrade.phpnew+175 −0
Review log 46
-
Benni Mack uploaded patch set 1 09/01/25, 15:08
-
core-ci voted on patch set 1 V +1 09/01/25, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84168
-
Benni Mack marked it work in progress 10/16/25, 19:36
-
Benni Mack rebased onto patch set 2
V +110/16/25, 19:36 -
core-ci voted on patch set 2 V +1 10/16/25, 19:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86842
-
Garvin Hicking commented on patch set 2 10/24/25, 13:29
(just a node, I know WIP and such, but I had to see what clau(w)d its way into the code ;) )AbstractOnlineMediaHelper.php:272UnresolvedThere is a specific get() method for this, utilize that one? Also, since this came up for me quite a few times today: Do we want makeInstance() for these kind of calls, or do we prefer inject() methods? Or "getters" that wrap around makeInstance calls? Above, also ConnectionPool is handled like this. I do think Claude/AI has the tendency to prefer makeInstance.OnlineMediaHelperInterface.php:81UnresolvedI think this `@return` is obsolete, also something that Claude often auto-adds (might be part of a "Guidelines" basic prompt to not do this)