Review main Merged

90534[BUGFIX] Check site set paths for potential xlf files

Georg Ringer CR +2 V +2 Normal +94 −13 updated 10/09/26, 16:17

Commit message

The LanguagePackService must also check the path
`Configuration/Sets/*/*.xlf` for potential files to
know if the extension got any xlf files. Otherwise an
extension shipping labels in site sets only is never
offered for language pack downloads, although the
LabelFileResolver already picks up such translations.

Both classes now share the list of label directories
via LabelFileResolver::LABEL_DIRECTORIES.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 2228

Show 23 earlier messages
  1. Georg Ringer uploaded patch set 1 09/01/25, 18:13

  2. Georg Ringer commented on patch set 1 09/01/25, 18:13

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 09/01/25, 18:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84181

  1. Garvin Hicking voted on patch set 1 CR +1 V +1 09/01/25, 18:52

  2. Benni Mack voted on patch set 1 CR +1 V +1 09/02/25, 07:08

  3. Stefan Bürk commented on patch set 1 CR -1 09/02/25, 09:29

    Checking ...
  4. Stefan Bürk voted on patch set 1 CR 0 09/02/25, 10:21

  5. Stefan Bürk commented on patch set 1 V -1 09/02/25, 10:34

    If a extension does not have a `Configuration/Sets/` folder this excepts out ``` The ".../typo3/sysext/core/Configuration/Sets/" directory does not exist. ``` I guess the same for Resources anyway. We should check if base folder exists (colllected in an array) and if some paths are in there scan for it or early return.
  6. Stefan Bürk commented on patch set 1 09/02/25, 10:35

    Reply

    Note that with this "change" for an extension not having a sets folder **no** files are found and the extension **skipped** ending in not downloading any packs for that extension anymore, for exampe `EXT:core`.
  7. Stefan Bürk commented on patch set 1 09/02/25, 10:46

    Reply

    On it ...
  8. Stefan Bürk uploaded patch set 2 CR +1 V +1 09/02/25, 10:54

  9. Stefan Bürk commented on patch set 2 09/02/25, 11:01

    Reply

    ... done. (See other comment for fix). Beside allow additional base bath for scanning, the sets folder translation files are not in the downloaded files or displayed on crowdin .... albeit there are already some within the core: * typo3/sysext/seo/Configuration/Sets/Sitemap/labels.xlf * typo3/sysext/redirects/Configuration/Sets/redirects/labels.xlf * ... See https://ibb.co/6772n4LY I would say that that needs to be checked first, something translated and having it in language pack so it can be really tested if it works.

    Reply

    Done.
  10. core-ci voted on patch set 2 V +1 09/02/25, 11:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84237

  11. Stefan Bürk commented on patch set 2 09/02/25, 11:04

    Reply

    Oh .. and I could not find any changelog or documentation explaining language files in sitestes folders, except that TYPO3 is shiping label.xlf files already.
  12. Stefan Bürk commented on patch set 2 09/02/25, 11:26

  13. Benni Mack updated the commit message in patch set 3 V +1 04/22/26, 06:56

  14. core-ci voted on patch set 3 V -1 04/22/26, 11:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100838

  15. Benni Mack uploaded patch set 4 V -1 05/05/26, 15:45

  16. core-ci voted on patch set 4 V +1 05/05/26, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101566

  17. Benni Mack marked it work in progress 07/27/26, 20:27

  18. Benni Mack uploaded patch set 5 V +1 10/02/26, 16:55

  19. Benni Mack marked it ready for review 10/02/26, 16:56

  20. core-ci voted on patch set 5 V -1 10/02/26, 17:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109977

  21. Georg Ringer uploaded patch set 6 V -1 10/05/26, 20:13

  22. core-ci voted on patch set 6 V +1 10/05/26, 20:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110151

  23. Garvin Hicking voted on patch set 6 CR +1 V +1 10/06/26, 04:52

  24. Benni Mack commented on patch set 6 CR +2 V +2 10/09/26, 16:17

    Reply

    This has been solved now
  25. Benni Mack merged patch set 7 10/09/26, 16:17