90549[!!!][TASK] Remove circular dependency between ProcessedFile and Task
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Garvin Hicking +1
- Stefan Froemken +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Garvin Hicking +1
- Stefan Froemken +1
- core-ci +1 CI
Issues 1
Files 13
- typo3/sysext/backend/Classes/Resource/Processing/DeferredBackendImageProcessor.php+1 −1
- typo3/sysext/core/Classes/Resource/Processing/AbstractTask.php13+13 −1
- typo3/sysext/core/Classes/Resource/Processing/LocalImageProcessor.php2+15 −1
- typo3/sysext/core/Classes/Resource/Processing/SvgImageProcessor.php3+12 −1
- typo3/sysext/core/Classes/Resource/Service/FileProcessingService.php1+5 −3
- typo3/sysext/core/Classes/Resource/ProcessedFile.php+0 −47
- typo3/sysext/core/Classes/Resource/ProcessedFileRepository.php4+17 −25
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-107397-CircularDependencyBetweenProcessedFileAndTaskRemoved.rst2new+100 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodArgumentDroppedMatcher.php+5 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodArgumentRequiredMatcher.php+5 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodArgumentUnusedMatcher.php+5 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallArgumentValueMatcher.php+5 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+19 −0
Review log 3747
Show 1722 earlier messages
-
Benni Mack uploaded patch set 1 09/02/25, 18:50
-
core-ci voted on patch set 1 V -1 09/02/25, 19:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84276
-
Benni Mack uploaded patch set 2
V -109/02/25, 19:56 -
core-ci voted on patch set 2 V +1 09/02/25, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84277
-
C. Gogolin commented on patch set 2 CR +1 V +1 09/03/25, 04:50
I think the separation of ProcessedFile and Task is very good. -
Stefan Froemken commented on patch set 2 CR -1 09/05/25, 10:40
$processedFile->isProcessed() will be called from AbstractTask, FileProcessingService, ImageProcessingService and ContentObjectRenderer. Only for AbstractTask the earlier Checksum check was kept. For all other classes the checksum check is gone. I will remove my -1, if you can explain me why that will not be a problem.AbstractTask.php:149If this is called the checksum check will not be validated anymoreAbstractTask.php:157Comment is only valid on checksum missmatch. I prefer something like: "File needs processing on checksum mismatch"AbstractTask.php:159What about just: return $checksum && $this->getConfigurationChecksum() !== $checksum;LocalCropScaleMaskHelper.php:180This is OK for me as all core classes implementing from TaskInterface are also extending AbstractTask.FileProcessingService.php:70Awesome. Everything is already here to create a new task. Bye bye ->getTask(). -
Garvin Hicking commented on patch set 2 09/05/25, 11:27
more specifically, ProcessedFileRepository?ProcessedFileRepository.php:300This disables XClassing, right? Not that I would suggest doing xclassing with a processedFile, but we might want to mention this specifically in an RST? -
Stefan Froemken commented on patch set 2 09/05/25, 12:15
ProcessedFileRepository.php:300ReplyI saw that, too, but we instantiate ProcessedFile with new three times in whole core. -
Garvin Hicking commented on patch set 2 09/05/25, 13:01
ProcessedFileRepository.php:300ReplyThis is done only in tests and not actual core code yet. So for now you could use XCLass with it, I believe. -
Garvin Hicking commented on patch set 2 09/05/25, 14:17
AbstractTask.php:157ReplyIMO we could even remove the whole comment here; the "if" here is declarative enough that it checks checksum (mis)match?!AbstractTask.php:159ReplyPersonally I find it easier to read that "false" is the default method's return. That way I don't need to "grok" an expression to easily recognize it.LocalCropScaleMaskHelper.php:180ReplyAgreed. -
Benni Mack uploaded patch set 3
CR +1V +109/08/25, 09:11 -
core-ci voted on patch set 3 V +1 09/08/25, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84611
-
Markus Klein commented on patch set 3 09/08/25, 10:05
ProcessedFileRepository.php:300ReplyThen you need to xclass this file here instead to replace the create-method. -
Markus Klein commented on patch set 3 09/08/25, 10:09
AbstractTask.php:191I'd prefer this for readability: ``` $file = $this->getTargetFile()->getOriginalFile(); return implode('_', [ $file->getNameWithoutExtension(), $file->getUid(), $this->getConfigurationChecksum(), ]); ```SvgImageProcessor.php:173wouldn't it be better to adjust the type hint of the method right away? It's a breaking change already, so take the chance? -
Benni Mack commented on patch set 3 09/08/25, 13:51
SvgImageProcessor.php:173Replyit's a protected method. IMHO this method will hopefully vanish completely, but I haven't been that far in the API refactoring process yet. -
Garvin Hicking commented on patch set 3 09/08/25, 14:32
Breaking-107397-CircularDependencyBetweenProcessedFileAndTaskRemoved.rst:98Missing extension scanner entries -
Garvin Hicking commented on patch set 3 CR -1 09/10/25, 11:09
on it -
Garvin Hicking uploaded patch set 4
CR -1V +109/10/25, 11:13 -
core-ci voted on patch set 4 V +1 09/10/25, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84773
-
Garvin Hicking uploaded patch set 5
V +109/10/25, 12:16 -
Garvin Hicking commented on patch set 5 09/10/25, 12:19
Reply
DoneAbstractTask.php:159ReplyDoneAbstractTask.php:191ReplyDoneSvgImageProcessor.php:173ReplyI would agree to leave this for further refactoring.Breaking-107397-CircularDependencyBetweenProcessedFileAndTaskRemoved.rst:98ReplyI fell into a rabbit-hole here and figured out the hard way that listing `add` and `update` methods does not work. I left a note for future me. Hope it's ok to do this as a drive-by here. -
core-ci voted on patch set 5 V +1 09/10/25, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84774
-
Benni Mack commented on patch set 5 09/10/25, 15:58
We should get rid of ProcessedFile->isOutdated while we're at it. -
Markus Klein uploaded patch set 6
V +109/10/25, 16:07 -
Markus Klein commented on patch set 6 09/10/25, 16:07
only rebased -
Garvin Hicking commented on patch set 6 09/10/25, 16:11
Reply
(unresolving) -
core-ci voted on patch set 6 V -1 09/10/25, 16:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84789
-
Georg Ringer uploaded patch set 7
V -109/10/25, 18:04 -
core-ci voted on patch set 7 V +1 09/10/25, 18:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84793
-
Markus Klein commented on patch set 7 09/11/25, 20:04
AbstractTask.php:157Replyagreed -
Markus Klein commented on patch set 7 09/11/25, 20:05
LocalImageProcessor.php:305introducing the uid here is really bad for multi-head installations (load balancing) -
Benni Mack uploaded patch set 8
V +109/12/25, 20:29 -
Benni Mack commented on patch set 8 09/12/25, 20:30
AbstractTask.php:149Replywhat does that mean? Can you elaborate? If the file is not (yet) processed, it needs processing...AbstractTask.php:157ReplyDone -
Benni Mack commented on patch set 8 09/12/25, 20:30
LocalImageProcessor.php:305ReplyDone -
Benni Mack commented on patch set 8 09/12/25, 20:30
Reply
we can keep it for the time being. -
core-ci voted on patch set 8 V -1 09/12/25, 20:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84929
-
Benni Mack uploaded patch set 9
V -109/12/25, 20:47 -
Benni Mack commented on patch set 9 09/12/25, 20:47
AbstractTask.php:149ReplyDone -
core-ci voted on patch set 9 V -1 09/12/25, 21:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84931
-
Benni Mack commented on patch set 9 09/12/25, 21:02
AbstractTask.php:149ReplyWith the latest change, the tests fail again due to the checksum validation of the deferred backend image processing. -
Stefan Froemken uploaded patch set 10
V -109/18/25, 23:06 -
core-ci voted on patch set 10 V +1 09/18/25, 23:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85137
-
Stefan Froemken commented on patch set 10 CR +1 V +1 09/19/25, 07:17
I have replaced exe file with pdf, and pdf with png in fileadmin. Further I have add 1 then 2 and then 3 files into CEs and played around with columns to initialize new image resizing. Looks good. -
Georg Ringer voted on patch set 10 CR +1 V +1 09/19/25, 08:14
-
Garvin Hicking voted on patch set 10 CR +1 V +1 09/19/25, 08:58
-
Benni Mack voted on patch set 10 CR +2 V +2 09/19/25, 08:58
-
Benni Mack merged patch set 11 09/19/25, 08:58