90551[BUGFIX] Ensure additional cache tags are applied for localized pages
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
- Stefan Froemken +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Froemken +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+11 −4
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+6 −0
- typo3/sysext/frontend/Tests/Functional/Controller/DataSet/LiveDefaultPages.csv+1 −0
- typo3/sysext/frontend/Tests/Functional/Controller/TypoScriptFrontendControllerTest.php+28 −0
Review log 1623
-
Elias Häußler uploaded patch set 1 09/03/25, 07:55
-
Elias Häußler marked it work in progress 09/03/25, 07:56
-
core-ci voted on patch set 1 V +1 09/03/25, 08:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84304
-
Elias Häußler uploaded patch set 2
V +109/03/25, 08:06 -
Elias Häußler uploaded patch set 3 09/03/25, 08:06
-
Elias Häußler updated the commit message in patch set 4 09/03/25, 08:09
-
core-ci voted on patch set 2 V -1 09/03/25, 08:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84307
-
core-ci voted on patch set 3 V +1 09/03/25, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84308
-
core-ci voted on patch set 4 V +1 09/03/25, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84309
-
Elias Häußler uploaded patch set 5
V +109/03/25, 08:57 -
core-ci voted on patch set 5 V +1 09/03/25, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84310
-
Elias Häußler marked it ready for review 09/03/25, 09:09
-
Benni Mack voted on patch set 5 CR +1 09/03/25, 14:49
-
Benni Mack updated the commit message in patch set 6
CR +1V +109/05/25, 09:22 -
Stefan Froemken commented on patch set 6 09/05/25, 09:28
Thank you for that patch. I like the example. I would appreciate, if you extend the example with previous handling and new handling. I have contacted Benni about TYPO3 12.4. He has removed it. TYPO3 12.4 will only get security and critical backports. -
core-ci voted on patch set 6 V +1 09/05/25, 09:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84447
-
Elias Häußler uploaded patch set 7
V +109/10/25, 18:26 -
Elias Häußler commented on patch set 7 09/10/25, 18:26
Reply
Can you have a second look, please? -
core-ci voted on patch set 7 V +1 09/10/25, 18:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84794
-
Stefan Froemken commented on patch set 7 CR +1 V +1 09/12/25, 07:43
Reply
DoneThank you for taking care of that. In earlier versions the cache identifiers differs while keeping the same cache tag. After the patch the identifier for translated content gets an additional cache tag with the Page UID of the translated page. Perfect. The clear this pages cache button in list-view will remove all entries of the page, also the entries with the new cache tag. Perfect. I have created a new page with TCEMAIN.clearCacheCmd = cacheTag:pageId_18 to test, ig that will also remove ALL cache entries of the other page. Works. Perfect. I have also tested with workspacing, but that does not make sense, as your are logged in into TYPO3 BE and in that case no cache entry will be generated. -
Christian Kuhn voted on patch set 7 CR +1 10/09/25, 13:08
-
Benni Mack voted on patch set 7 CR +2 V +2 10/09/25, 13:18
-
Benni Mack merged patch set 8 10/09/25, 13:18