Review main Abandoned

90554[TASK] Add runtime caching to reduce the number of DB queries

TYPO3com CR -1 V 0 Easy +11 −1 updated 06/11/26, 00:25

Commit message

Review

  • Code review CR -1
    • Christian Kuhn -1
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. TYPO3com uploaded patch set 1 09/03/25, 11:54

  2. core-ci voted on patch set 1 V +1 09/03/25, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84319

  3. Benni Mack commented on patch set 1 09/03/25, 13:16

    BackendConfigurationManager.php:274 Unresolved

    I assume we should put the permsClause also in the cacheIdentifier (just to be safe)
  4. Christian Kuhn commented on patch set 1 CR -1 09/03/25, 13:20

    this needs good reasoning why its needed: usually, extbase modules should call the be-configuration manager exactly once per request, neglecting the need runtime caching the pid calculation. i think the change should not be accepted until the use cases have been outlined and evaluated to be legitimate or not.
  5. Christian Kuhn commented on patch set 1 09/03/25, 13:21

    Reply Unresolved

    unresolved.
  6. Benni Mack wrote 04/21/26, 14:59

    Removed cc Benni Mack.
  7. Christian Kuhn commented on patch set 1 06/11/26, 00:24

    hey. let's abandon here for now: this didn't gain traction. let's start fresh in case a use case is communicated.
  8. Christian Kuhn abandoned the change 06/11/26, 00:25