90555[!!!][FEATURE] Add PSR-14 Event before form deletion
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Mogens Fiebrandt +1
- Josua Vogel +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Josua Vogel +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-107382-RemovedBeforeFormDeleteHook.rstnew+40 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107382-IntroducePSR14BeforeFormIsDeletedEvent.rst6new+59 −0
- typo3/sysext/form/Classes/Controller/FormManagerController.php+31 −24
- typo3/sysext/form/Classes/Event/BeforeFormIsDeletedEvent.php4new+39 −0
- typo3/sysext/form/Tests/Functional/Controller/Fixtures/Folders/fileadmin/form_definitions/test_form.form.yamlnew+8 −0
- typo3/sysext/form/Tests/Functional/Controller/FormManagerControllerTest.php3+64 −3
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php2+6 −0
Review log 2330
Show 45 earlier messages
-
Josua Vogel uploaded patch set 1 09/03/25, 12:32
-
Josua Vogel commented on patch set 1 09/03/25, 12:34
open: Should we provide an option to prevent deletion? -
core-ci voted on patch set 1 V +1 09/03/25, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84320
-
Mogens Fiebrandt commented on patch set 1 CR -1 09/05/25, 21:21
Feature-107382-IntroducePSR14BeforeFormIsDeletedEvent.rst:51I think here is a small copy-paste error. Should say something like "... it's now possible to execute custom code/script before a form is deleted". -
Josua Vogel uploaded patch set 2
CR -1V +109/07/25, 10:20
-
Josua Vogel commented on patch set 2 09/07/25, 10:25
Feature-107382-IntroducePSR14BeforeFormIsDeletedEvent.rst:51ReplyDone -
core-ci voted on patch set 2 V +1 09/07/25, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84567
-
Simon Schaufelberger commented on patch set 2 09/07/25, 11:18
Reply
I guess that would make sense as I don't know what could be a useful usecase what to do just with the identifier. -
Josua Vogel uploaded patch set 3
V +109/08/25, 06:07 -
Josua Vogel uploaded patch set 4 09/08/25, 06:10
-
core-ci voted on patch set 3 V -1 09/08/25, 06:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84599
-
core-ci voted on patch set 4 V -1 09/08/25, 06:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84600
-
Josua Vogel uploaded patch set 5
V -109/08/25, 06:45 -
Josua Vogel commented on patch set 5 09/08/25, 06:47
Reply
Done -
core-ci voted on patch set 5 V +1 09/08/25, 06:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84603
-
Simon Schaufelberger voted on patch set 5 CR +1 V +1 09/08/25, 08:14
-
Oli Bartsch commented on patch set 5 09/09/25, 09:01
Feature-107382-IntroducePSR14BeforeFormIsDeletedEvent.rst:22`$preventDeletion` is not readonly.Feature-107382-IntroducePSR14BeforeFormIsDeletedEvent.rst:54And to add custom logic based on the delete action.BeforeFormIsDeletedEvent.php:21Actually the benefit is: Getting the identifier, are able to stop deletion and add custom login e.g. cleanup etc.BeforeFormIsDeletedEvent.php:24I suggest to make the event stoppable, based on `$preventDeletion`. So whenever this is set to `true`, no further listener is called.FormManagerControllerTest.php:533Please use: $this->importCSVDataSet(__DIR__ . '/../Fixtures/be_users.csv'); $this->setUpBackendUser(1); instead.ArrayDimensionMatcher.php:1216We usually always add new entries at the bottom to make resolving merge conflicts easier. -
Oli Bartsch commented on patch set 5 09/09/25, 09:21
FormManagerControllerTest.php:533ReplyShould also be updated in `beforeFormIsCreatedEventIsTriggered` as drive-by. -
Simon Schaufelberger voted on patch set 5 CR 0 V 0 09/09/25, 09:46
-
Josua Vogel uploaded patch set 6
V +109/09/25, 14:09 -
Josua Vogel commented on patch set 6 09/09/25, 14:10
Feature-107382-IntroducePSR14BeforeFormIsDeletedEvent.rst:22ReplyDoneFeature-107382-IntroducePSR14BeforeFormIsDeletedEvent.rst:54ReplyDoneBeforeFormIsDeletedEvent.php:21ReplyDoneBeforeFormIsDeletedEvent.php:24ReplyDoneFormManagerControllerTest.php:533ReplyDoneArrayDimensionMatcher.php:1216ReplyDone -
core-ci voted on patch set 6 V -1 09/09/25, 14:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84711
-
Oli Bartsch uploaded patch set 7
V -109/09/25, 14:33 -
core-ci voted on patch set 7 V +1 09/09/25, 14:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84714
-
Josua Vogel voted on patch set 7 CR +1 V +1 09/09/25, 14:43
-
Oli Bartsch voted on patch set 7 CR +1 V +1 09/09/25, 14:54
-
Garvin Hicking voted on patch set 7 CR +1 V +1 09/09/25, 16:10
-
Oli Bartsch voted on patch set 7 CR +2 V +2 09/09/25, 17:36
-
Oli Bartsch merged patch set 8 09/09/25, 17:36
-
Mogens Fiebrandt voted on patch set 8 CR +1 09/11/25, 14:23