Review main Abandoned

90556[TASK] Utilize `PHP_IDE_CONFIG` in `runTests.sh` with xdebug enabled

Elias Häußler CR -1 V 0 Easy +4 −1 updated 06/11/26, 03:06

Commit message

Running `Build/Scripts/runTests.sh` for a test suite which supports
xdebug, it is now possible to utilize the environment variable
`PHP_IDE_CONFIG`, which is commonly used in IDEs to identify and connect
an incoming xdebug request to a specific project. If the environment
variable is omitted, it defaults to `serverName=<project folder>`. For
example, if the project was cloned to `t3main`, the resulting variable
will be `serverName=t3main`.

Review

  • Code review CR -1
    • Stefan Bürk -1
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Elias Häußler uploaded patch set 1 09/03/25, 13:01

  2. core-ci voted on patch set 1 V +1 09/03/25, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84321

  3. Stefan Bürk commented on patch set 1 CR -1 09/03/25, 13:09

    Unresolved

    Got pinged -- need to have a look at a point when I have some time.
  4. Christian Kuhn commented on patch set 1 09/03/25, 13:25

    what's the reason here? ide's like phpstorm usually only have trouble matching an xdebug connection to a project when there are path issues. runTests.sh avoids those path issues by mapping the local patch to the same path in the container, so i never had issues with xdebug<->phpstorm finding the correct project. why and when does php-ide-config help here?
  5. Elias Häußler commented on patch set 1 09/03/25, 13:38

    Reply

    Actually, I don't really know why. If I have multiple projects open and each project listens for incoming requests (which normally isn't a problem, because I use DDEV everywhere, which defines the `PHP_IDE_CONFIG` variable and I have a path mapping in place for each project), I'll get prompted to select the appropriate project, when there's an incoming xdebug request. If there's a better way than using `PHP_IDE_CONFIG`, I'd happy to try it out 😊
  6. Christian Kuhn commented on patch set 1 06/11/26, 03:06

    runTests.sh:664 Unresolved

    hey. i fiddled with this for a while. the issue is that phpstorm tends to ignore the connection (default setting "Ignore external connections through unregistered server configurations") when serverName is given and does not match phpstorm configuration. breakpoints then aren't triggered at all. so 'inventing' a serverName and just adding some is worse than adding none and letting phpstorm pop up asking for the target. i understand this is cumbersome, but a change here should be tested well for various cases and should prefer 'just works somehow' if possible since that xdebug fiddling can easily become annoying, and it tends to not work when you need it the most. as such, i hope it is ok to abandon here for the moment. let's restart fresh if picked up again.
  7. Christian Kuhn abandoned the change 06/11/26, 03:06