Review main Merged

90557[TASK] Handle client-side errors of workspace dispatcher

Oliver Hader CR +2 V +2 Normal +148 −59 updated 09/03/26, 19:20

Commit message

Exceptions of the workspace ajax endpoints are now reported to the
client, which turns them into error notifications instead of failing
silently.

Server side:
* Both "workspace_dispatch" and "workspace_preview" share one call
  stack processing with identical error handling
* A response is always a list with one entry per call, carrying
  either a "result" or an "error" property
* A failing call no longer aborts the stack, results calculated
  already are kept, HTTP status 500 signals a partial failure
* Handled exceptions never reach the global exception handler and
  are therefore logged explicitly

Client side:
* sendRemoteRequest() keeps the rejection up after notifying, so
  callers do not continue with an error payload
* Failures without server side details, like an unreachable server
  or an error page that is no JSON, get a generic message
* Notification texts are taken from locallang.xlf

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1117

  1. Oliver Hader uploaded patch set 1 09/03/25, 14:49

  2. core-ci voted on patch set 1 V +1 09/03/25, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84327

  3. Oliver Hader updated the commit message in patch set 2 V +1 09/04/25, 06:05

  4. core-ci voted on patch set 2 V +1 09/04/25, 06:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84358

  5. Benni Mack uploaded patch set 3 V +1 07/31/26, 05:41

  6. core-ci voted on patch set 3 V +1 07/31/26, 05:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105730

  7. Benni Mack updated the commit message in patch set 4 V +1 08/06/26, 18:26

  8. Benni Mack marked it ready for review 08/06/26, 18:26

  9. core-ci voted on patch set 4 V +1 08/06/26, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106013

  10. Benni Mack rebased onto patch set 5 V +1 09/02/26, 16:06

  11. core-ci voted on patch set 5 V +1 09/02/26, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107652

  12. Benni Mack uploaded patch set 6 V +1 09/02/26, 20:13

  13. core-ci voted on patch set 6 V +1 09/02/26, 20:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107674

  14. Benni Mack voted on patch set 6 CR +1 V +1 09/03/26, 14:13

  15. Simon Schaufelberger voted on patch set 6 CR +1 V +1 09/03/26, 14:40

  16. Georg Ringer voted on patch set 6 CR +2 V +2 09/03/26, 17:30

  17. Georg Ringer merged patch set 7 09/03/26, 19:20