90559[BUGFIX] Show rootlevel=-1 tables in BE allowed exclude fields list
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1520
-
Markus Klein uploaded patch set 1 09/03/25, 20:06
-
core-ci voted on patch set 1 V +1 09/03/25, 20:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84329
-
Oli Bartsch commented on patch set 1 09/04/25, 06:36
Patch works, thanks! However, I would like to remove v12 here. This does not seem to be priority or security related. Let's please focus on main and v13. See also latest comment from Benni on this topic: > I want to remind you to a) only backport things to v12 that are critical or security-related or where you take the responsibility and b) you are sure it works > on v12. > We really really really need to focus on v14 and to work on other things that need to go in. If we open up this discussion again and again, we're wasting our own energies that we could put in v14. https://review.typo3.org/c/Packages/TYPO3.CMS/+/90497 -
Markus Klein commented on patch set 1 09/04/25, 06:58
Reply
Totally fine with me. Benni knows my opinion on that matter. ;-) -
Markus Klein updated the commit message in patch set 2
V +109/04/25, 06:58 -
core-ci voted on patch set 2 V +1 09/04/25, 07:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84359
-
Markus Klein updated the commit message in patch set 3
V +109/04/25, 07:21 -
core-ci voted on patch set 3 V +1 09/04/25, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84361
-
Stefan Froemken commented on patch set 3 09/05/25, 14:10
Patch is OK in generalTcaItemsProcessorFunctions.php:268This is so hard to read. I don't like that API. 3 negative combined variants: 1. negative: "ignore" in method name 2. negative: the condition check against false 3. negative: Skipping the process with "continue" negative + negative = positive + negative = negative, right?!?! Say that I'm getting old, but such a comment above that condition would be really helpful: // If the configuration option "[security][ignoreRootLevelRestriction]" is set to "false" (which is the default value), // regular users are not allowed to access any tables at the root level. A table configured with // "rootLevel = 1" will be restricted to the root level (pid = 0) and will be accessible only // to administrators. Considering this configuration setup, rendering exclude fields for such a table // is redundant and unnecessary. -
Markus Klein commented on patch set 4
V +109/05/25, 14:35Published edit on patch set 3. -
Markus Klein commented on patch set 4 09/05/25, 14:35
TcaItemsProcessorFunctions.php:268ReplyDone -
core-ci voted on patch set 4 V +1 09/05/25, 14:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84475
-
Stefan Froemken commented on patch set 4 09/05/25, 14:54
TcaItemsProcessorFunctions.php:268Thank you for providing a shorter version. But it completely skips the CTRL "security" part. What about? ```suggestion // Skip this table if it’s rootlevel-only and the rootlevel restriction applies // (unless ignoreRootLevelRestriction is enabled). ``` -
Markus Klein commented on patch set 5
V +109/05/25, 18:57Published edit on patch set 4. -
Markus Klein commented on patch set 5 09/05/25, 18:57
TcaItemsProcessorFunctions.php:268ReplyFix applied. -
core-ci voted on patch set 5 V +1 09/05/25, 19:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84493
-
Oli Bartsch commented on patch set 5 CR +1 V +1 09/09/25, 10:06
Thanks. Can be tested with `tx_styleguide_ctrl_common`. -
Benni Mack voted on patch set 5 CR +1 V +1 09/09/25, 10:48
-
Georg Ringer voted on patch set 5 CR +2 V +2 09/09/25, 13:16
-
Georg Ringer merged patch set 6 09/09/25, 13:16