Review 13.4 Merged

90560[BUGFIX] Show rootlevel=-1 tables in BE allowed exclude fields list

Markus Klein CR +2 V +2 Easy +1 −1 updated 09/10/25, 06:36

Commit message

If a table is defined to be visible on root page and
any page (ctrl|rootLevel=-1) the defined exclude fields
must be selectable in UI as well.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 1015

  1. Markus Klein uploaded patch set 1 09/03/25, 20:10

  2. core-ci voted on patch set 1 V -1 09/03/25, 20:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84330

  3. Markus Klein uploaded patch set 2 V -1 09/03/25, 20:31

  4. Markus Klein rebased onto patch set 3 09/03/25, 20:34

  5. core-ci voted on patch set 3 V +1 09/03/25, 20:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84332

  6. core-ci voted on patch set 2 V +1 09/03/25, 20:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84331

  7. Markus Klein updated the commit message in patch set 4 V +1 09/04/25, 06:59

  8. core-ci voted on patch set 4 V +1 09/04/25, 07:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84360

  9. Markus Klein updated the commit message in patch set 5 V +1 09/04/25, 07:22

  10. core-ci voted on patch set 5 V +1 09/04/25, 07:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84362

  11. Oli Bartsch commented on patch set 5 09/09/25, 10:11

    TcaItemsProcessorFunctions.php:260

    Why is the conditions order changed in comparison to the main patch?
  12. Markus Klein commented on patch set 5 09/09/25, 10:36

    TcaItemsProcessorFunctions.php:260 Reply

    Oli, not sure what do you mean. Can you please rephrase your question? thx.
  13. Oli Bartsch commented on patch set 5 CR +2 V +2 09/09/25, 14:22

    TcaItemsProcessorFunctions.php:260 Reply

    In main it is: ``` !$rootLevelCapability->shallIgnoreRootLevelRestriction() && $rootLevelCapability->getRootLevelType() === RootLevelCapability::TYPE_ONLY_ON_ROOTLEVEL ``` the `ignoreRootLevelRestriction` is executed before checking `rootLevel`. The order is changed. However, does not matter.
  14. Oli Bartsch merged patch set 6 09/09/25, 14:23

  15. Markus Klein commented on patch set 6 09/10/25, 06:36

    TcaItemsProcessorFunctions.php:260 Reply

    Yes, but that's wasn't done by me and not with this patch.