90562[TASK] Avoid costly database schema queries and class state
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Stefan Froemken +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Stefan Froemken +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 4
Review log 1927
Show 2 earlier messages
-
core-ci voted on patch set 1 V -1 09/04/25, 10:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84366
-
core-ci voted on patch set 2 V -1 09/04/25, 10:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84367
-
Stefan Bürk marked it work in progress 09/04/25, 10:43
-
Stefan Bürk uploaded patch set 3
V -109/04/25, 11:01 -
core-ci voted on patch set 3 V +1 09/04/25, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84368
-
Stefan Bürk marked it ready for review 09/04/25, 11:14
-
Stefan Bürk updated the commit message in patch set 4
V +109/04/25, 11:15 -
core-ci voted on patch set 4 V +1 09/04/25, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84370
-
Andreas Kienast commented on patch set 4 09/04/25, 11:26
-
Stefan Bürk uploaded patch set 5
V +109/04/25, 12:36 -
Stefan Bürk commented on patch set 5 09/04/25, 12:40
MetaDataRepositoryTest.php:28ReplyCorrect assumption. Removed. -
core-ci voted on patch set 5 V +1 09/04/25, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84372
-
Markus Klein updated the commit message in patch set 6
V +109/04/25, 13:02 -
core-ci voted on patch set 6 V +1 09/04/25, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84380
-
Stefan Bürk uploaded patch set 7 09/04/25, 18:38
Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 7 V +1 09/04/25, 18:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84393
-
Benni Mack voted on patch set 7 CR +1 V +1 09/05/25, 06:57
-
Stefan Bürk updated the commit message in patch set 8
CR +1V +109/05/25, 07:35 -
Benni Mack voted on patch set 8 CR +1 V +1 09/05/25, 07:38
-
core-ci voted on patch set 8 V +1 09/05/25, 07:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84432
-
Stefan Froemken commented on patch set 8 09/05/25, 08:23
SchemaInformation.php:77For those who are searching for the cache usage: It's here, within "introspectSchema": $schema = $this->connection->createSchemaManager()->introspectSchema(); $this->cache->set($identifier, $schema); -
Stefan Froemken commented on patch set 8 CR +1 V +1 09/05/25, 08:33
SchemaInformation.php:79I wondered about all these getName() calls as the column-name is already stored as array-key within Table->_columns, but Doctrines getColums() does an array_value before, that's why we (you) had to extract this information again. Njag...OK. -
Stefan Bürk voted on patch set 8 CR +2 V +2 09/05/25, 08:43
-
Stefan Bürk merged patch set 9 09/05/25, 08:43
-
Stefan Bürk wrote 09/06/25, 11:52
Created a revert of this change as I6da8b5e54b0e178fc2680e9335bfd6e9cbf64620
MetaDataRepositoryTest.php:28