Review main Merged

90575[TASK] Extend allowed list of uploadable text/misc files

Garvin Hicking CR +2 V +2 Easy +2 −2 updated 09/09/25, 20:28

Commit message

The default configuration for `textfile_ext` is extended to allow
upload and the plain-text recognition of the following file types
in the file list (for editing a file):

* json
* md
* rst
* rtf
* srt

Also, the list of files for `miscfile_ext` is extended to
allow upload of common file formats for setups where
`security.system.enforceAllowedFileExtensions` is enabled,
to provide convenience for editors in uploading files
that are common for web CMS systems:

* 7z, doc, docm, docx, dot, dotm, dotx, epub, gz, ics, mobi,
  odp, ods, odt, potm, potx, ppam, pps, ppsm, ppsx, ppt, pptm,
  pptx, rar, sldm, sldx, tar, vcard, vcf, xlam, xls, xlsb, xlsm
  xlsx, xlt, xltm, xltx

This allows to enable said security flag more easily for maintainers,
without denying too many file types that are broadly used.

Please note:

1. This adjusts the default list of `textfile_ext` and `miscfile_ext`
   only for installations that have no custom configuration.

2. This addition makes the listed text files editable from the
   file list. Since these are defined as ASCII files, this is
   considered to not have side-effects.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 6

Files 1

Review log 1216

  1. Garvin Hicking uploaded patch set 1 09/05/25, 09:55

  2. Garvin Hicking updated the commit message in patch set 2 09/05/25, 10:03

  3. core-ci voted on patch set 1 V +1 09/05/25, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84449

  4. core-ci voted on patch set 2 V +1 09/05/25, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84452

  5. Simon Schaufelberger voted on patch set 2 CR +1 V +1 09/05/25, 18:42

  6. Jörg Bösche voted on patch set 2 CR +1 09/07/25, 18:33

  7. Garvin Hicking uploaded patch set 3 CR +1 V +1 09/08/25, 17:33

  8. Garvin Hicking uploaded patch set 4 09/08/25, 17:34

  9. core-ci voted on patch set 3 V -1 09/08/25, 17:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84638

  10. core-ci voted on patch set 4 V +1 09/08/25, 17:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84639

  11. Benni Mack voted on patch set 4 CR +1 09/08/25, 18:00

  12. Stefan Bürk voted on patch set 4 CR +1 09/09/25, 00:03

  13. Oli Bartsch voted on patch set 4 CR +1 V +1 09/09/25, 17:59

  14. Simon Schaufelberger voted on patch set 4 CR +1 V +1 09/09/25, 18:57

  15. Garvin Hicking voted on patch set 4 CR +2 V +2 09/09/25, 20:27

  16. Garvin Hicking merged patch set 5 09/09/25, 20:28