Review main Merged

90583[TASK] Do not call non static test methods statically

Helmut Hummel CR +2 V +2 Expert +944 −924 updated 09/05/25, 15:11

Commit message

PHPUnit 11 changed some of the TestCase methods,
to not be static any more.
See: https://github.com/sebastianbergmann/phpunit/issues/5213

This change in PHPUnit is not directly reflected in
PHPCsFixer yet, but our config of the fixer, that we already use
can be changed, so that the non static method calls in our tests
are rewritten.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 164

Show 144 more files

Review log 68

  1. Helmut Hummel uploaded patch set 1 09/05/25, 12:15

  2. core-ci voted on patch set 1 V -1 09/05/25, 12:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84465

  3. Helmut Hummel uploaded patch set 2 V -1 09/05/25, 12:42

  4. core-ci voted on patch set 2 V +1 09/05/25, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84466

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 09/05/25, 13:00

  6. Oliver Klee voted on patch set 2 CR +1 V +1 09/05/25, 13:01

  7. Helmut Hummel voted on patch set 2 CR +2 V +2 09/05/25, 13:08

  8. Helmut Hummel merged patch set 3 09/05/25, 15:11