Review main Merged

9061[BUGFIX] Warnings in tcemain on iterating over unset columns

Mario Rimann CR +2 V +2 Easy +10 −3 updated 06/03/13, 20:49

Commit message

Adds a check if the TCA for the table has a columns setting at all
before iterating over the columns of that table.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Tolleiv Nietsch +2
    • Markus Klein +1
  • Verified V +2
    • Georg Ringer +2
    • Tolleiv Nietsch +2
    • Markus Klein +1

Files 1

Review log 10

  1. Tolleiv Nietsch commented on patch set 1 V 0 02/17/12, 07:52

    Whatever is motivating you for these patches - seems that it/he/she really got strange TCA issues ;)
  2. Markus Klein commented on patch set 1 02/17/12, 07:52

    I would prefer that you didn't submit this
    BUGFIX -> Fixes Please stick to the Commit Message Guidelines.
  3. Tolleiv Nietsch commented on patch set 2 V 0 02/17/12, 07:52

    by team member; Looks good to me, approved
  4. Markus Klein commented on patch set 2 02/17/12, 07:52

    Verified; Looks good to me, but someone else must approve
  5. Markus Klein uploaded patch set 2 02/17/12, 07:52

  6. Georg Ringer commented on patch set 1 02/17/12, 07:52

    Verified; Looks good to me, but someone else must approve
  7. Mr. Jenkins commented on patch set 1 02/17/12, 07:52

  8. Mr. Jenkins commented on patch set 2 02/17/12, 07:52

  9. Georg Ringer commented on patch set 2 V 0 02/17/12, 07:52

    by team member; Looks good to me, approved
  10. Georg Ringer merged patch set 2 02/17/12, 07:52