Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
90612[FEATURE] Adjust RTE configuration loading to allow different editors
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 45
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/12/90612/45 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/12/90612/45 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Issues 1
Files 28
- typo3/sysext/backend/Classes/Attribute/AsRichtextEditorBuilder.phpnew+31 −0
- typo3/sysext/backend/Classes/Controller/BrowseLinksController.phprenamed+16 −10
- typo3/sysext/backend/Classes/DependencyInjection/RichtextBuilderPass.phpnew+54 −0
- typo3/sysext/backend/Classes/Form/Element/RichTextElement.php8new+165 −0
- typo3/sysext/backend/Classes/Form/Resolver/RichTextNodeResolver.php2renamed+2 −2
- typo3/sysext/backend/Classes/Richtext/FallbackEditorBuilder.phpnew+137 −0
- typo3/sysext/backend/Classes/Richtext/RichtextEditorBuilderInterface.php2new+46 −0
- typo3/sysext/backend/Classes/Richtext/RichtextEditorConfiguration.php2new+33 −0
- typo3/sysext/backend/Classes/Richtext/RichtextEditorDefinition.phpnew+35 −0
- typo3/sysext/backend/Classes/Richtext/RichtextEditorRegistry.php3new+49 −0
- typo3/sysext/backend/Classes/Richtext/RichtextEditorService.php2new+83 −0
- typo3/sysext/backend/Classes/ServiceProvider.php+7 −0
- typo3/sysext/backend/Configuration/Backend/Routes.php2+6 −0
- typo3/sysext/backend/Configuration/Services.php+16 −0
- typo3/sysext/backend/Resources/Private/Language/locallang.xlf+6 −0
- typo3/sysext/backend/ext_localconf.php+8 −0
- typo3/sysext/core/Classes/Configuration/Richtext.php1+28 −60
- typo3/sysext/core/Classes/Utility/ArrayUtility.php+24 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-107421-EnableConfigurationOfMultipleIndependentRichtextEditorImplementations.rstnew+205 −0
- typo3/sysext/core/Tests/Functional/Configuration/Fixtures/TestRichtextEditorBuilder.phpnew+57 −0
Show 8 more files
- typo3/sysext/core/Tests/Functional/Configuration/RichtextTest.php+68 −68
- typo3/sysext/rte_ckeditor/Classes/Form/Element/RichTextElement.phpdeleted+0 −463
- typo3/sysext/rte_ckeditor/Classes/Richtext/CKEditorBuilder.php13new+423 −0
- typo3/sysext/rte_ckeditor/Configuration/Backend/Routes.phpdeleted+0 −15
- typo3/sysext/rte_ckeditor/Tests/Functional/Form/Element/RichTextElementTest.phpdeleted+0 −159
- typo3/sysext/rte_ckeditor/Tests/Functional/HtmlParser/HtmlParserProcessingTest.php+4 −4
- typo3/sysext/rte_ckeditor/Tests/Functional/RecordList/Controller/BrowseLinksControllerTest.php+2 −1
- typo3/sysext/rte_ckeditor/ext_localconf.php4+11 −18
Review log 75118
Show 5793 earlier messages
-
Andreas Nedbal uploaded patch set 1 09/09/25, 07:17
-
Andreas Nedbal marked it work in progress 09/09/25, 07:20
-
core-ci voted on patch set 1 V -1 09/09/25, 07:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84652
-
Andreas Nedbal uploaded patch set 2
V -109/09/25, 09:28 -
Andreas Nedbal updated the commit message in patch set 3 09/09/25, 09:33
-
core-ci voted on patch set 2 V -1 09/09/25, 09:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84685
-
core-ci voted on patch set 3 V -1 09/09/25, 09:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84687
-
Andreas Nedbal uploaded patch set 4
V -109/09/25, 09:48 -
core-ci voted on patch set 4 V -1 09/09/25, 10:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84691
-
Andreas Nedbal uploaded patch set 5
V -109/09/25, 10:30 -
core-ci voted on patch set 5 V +1 09/09/25, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84695
-
Andreas Nedbal uploaded patch set 6
V +109/10/25, 09:18 -
core-ci voted on patch set 6 V -1 09/10/25, 09:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84767
-
Andreas Nedbal uploaded patch set 7
V -109/11/25, 13:37 -
core-ci voted on patch set 7 V -1 09/11/25, 13:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84846
-
Benjamin Kott commented on patch set 7 09/12/25, 06:14
This change is ready for review.RichTextElement.php:92sounds good if we can pass information, propably we also need to do the same via js eventsRichTextElement.php:96todo? still hardcoded editorRichTextNodeResolver.php:52this feels wrong, when we have the core decoupled, we cannot set a default to a dependency we cannot fulfill.ext_localconf.php:9remove todoext_localconf.php:24not sure if we really should use globals here when we change it anyways. -
Benjamin Kott marked it work in progress 09/12/25, 07:21
-
Andreas Nedbal uploaded patch set 8
V -109/19/25, 17:03 -
Andreas Nedbal commented on patch set 8 09/19/25, 17:04
RichTextElement.php:96ReplyDone -
Andreas Nedbal commented on patch set 8 09/19/25, 17:04
RichTextNodeResolver.php:52ReplyDone -
core-ci voted on patch set 8 V -1 09/19/25, 17:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85180
-
Andreas Nedbal uploaded patch set 9
V -109/19/25, 17:35 -
core-ci voted on patch set 9 V -1 09/19/25, 17:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85181
-
Andreas Nedbal uploaded patch set 10
V -109/28/25, 17:39 -
core-ci voted on patch set 10 V -1 09/28/25, 17:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85664
-
Andreas Nedbal uploaded patch set 11
V -109/28/25, 17:53 -
core-ci voted on patch set 11 V -1 09/28/25, 18:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85665
-
Andreas Nedbal uploaded patch set 12
V -110/31/25, 14:31 -
core-ci voted on patch set 12 V -1 10/31/25, 14:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88265
-
Andreas Nedbal uploaded patch set 13
V -110/31/25, 15:02 -
core-ci voted on patch set 13 V -1 10/31/25, 15:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88270
-
Andreas Nedbal uploaded patch set 14
V -110/31/25, 15:27 -
core-ci voted on patch set 14 V -1 10/31/25, 15:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88273
-
Andreas Nedbal uploaded patch set 15
V -110/31/25, 15:45 -
core-ci voted on patch set 15 V -1 10/31/25, 15:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88275
-
Andreas Nedbal rebased onto patch set 16
V -111/10/25, 08:20The following files contain Git conflicts: * typo3/sysext/backend/Classes/ServiceProvider.php * typo3/sysext/rte_ckeditor/Classes/Form/Element/RichTextElement.php * typo3/sysext/rte_ckeditor/Tests/Functional/Form/Element/RichTextElementTest.php -
core-ci voted on patch set 16 V -1 11/10/25, 08:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88803
-
Andreas Nedbal uploaded patch set 17
V -111/10/25, 08:59 -
core-ci voted on patch set 17 V -1 11/10/25, 09:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88807
-
Andreas Nedbal uploaded patch set 18
V -111/10/25, 11:08 -
core-ci voted on patch set 18 V -1 11/10/25, 11:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88832
-
Matthias Vogel commented on patch set 18 11/12/25, 13:38
CKEditorBuilder.php:49Stateful services should be avoided. I see that you copied these two properties over, but I would suggest refactoring the code so that the newly created builder is stateless (i.e. a read-only class).CKEditorBuilder.php:63Shouldn't getConfiguration() return the fully resolved configuration? Thats what I would expect from the Builder if I look at the Interface.CKEditorBuilder.php:66Maybe we can also return the rteConfiguration. That would solve, https://review.typo3.org/c/Packages/TYPO3.CMS/+/91549 ```suggestion html: $this->getHTML(), configuration: $this->rteConfiguration, ``` -
Andreas Nedbal uploaded patch set 19
V -111/13/25, 11:37 -
core-ci voted on patch set 19 V -1 11/13/25, 11:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89476
-
Andreas Nedbal uploaded patch set 20
V -111/13/25, 12:01 -
core-ci voted on patch set 20 V -1 11/13/25, 12:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89486
-
Andreas Nedbal uploaded patch set 21
V -111/13/25, 12:49 -
core-ci voted on patch set 21 V -1 11/13/25, 13:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89493
-
Andreas Nedbal rebased onto patch set 22
V -101/23/26, 10:56The following files contain Git conflicts: * typo3/sysext/backend/Configuration/Services.php * typo3/sysext/backend/Resources/Private/Language/locallang.xlf * typo3/sysext/backend/ext_localconf.php * typo3/sysext/rte_ckeditor/Classes/Form/Element/RichTextElement.php -
core-ci voted on patch set 22 V -1 01/23/26, 11:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94149
-
Andreas Nedbal uploaded patch set 23
V -101/23/26, 12:14 -
core-ci voted on patch set 23 V -1 01/23/26, 12:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94167
-
Andreas Nedbal uploaded patch set 24
V -101/23/26, 13:34 -
core-ci voted on patch set 24 V -1 01/23/26, 13:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94171
-
Andreas Nedbal uploaded patch set 25
V -101/23/26, 13:52 -
core-ci voted on patch set 25 V -1 01/23/26, 14:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94173
-
Andreas Nedbal uploaded patch set 26
V -101/23/26, 14:46 -
core-ci voted on patch set 26 V -1 01/23/26, 15:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94179
-
Andreas Nedbal uploaded patch set 27
V -101/23/26, 16:24 -
core-ci voted on patch set 27 V -1 01/23/26, 16:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94187
-
Andreas Nedbal marked it ready for review 01/26/26, 13:19
-
Andreas Nedbal commented on patch set 27 01/26/26, 13:24
CKEditorBuilder.php:49ReplyDoneCKEditorBuilder.php:63ReplyDone -
Garvin Hicking commented on patch set 27 01/26/26, 21:30
We'll also probably want to add the new defaultEditor oreference to DefaultConfiguration.php / yaml (using a list of available editors)RichTextElement.php:67```suggestion * Renders the RTE element via specific implementation like CKEditor ```RichTextElement.php:135Use language domain here (it's copy and paste I know, but lets try to make new code use the language domains)FallbackEditorBuilder.php:67Use new language domain labelling of 14.1 here (also few lines below)FallbackEditorBuilder.php:109Could we use DI here instead of GUmI?RichtextEditorDefinition.php:20Maybe readonly? Final? Maybe add phpdoc array shapes ("string[]")?RichtextEditorRegistry.php:23Final? Internal?RichtextEditorRegistry.php:26Unneeded type hintFeature-107421-EnableConfigurationOfMultipleIndependentRichtextEditorImplementations.rst:122Please add a :caption: with an example filename and locationFeature-107421-EnableConfigurationOfMultipleIndependentRichtextEditorImplementations.rst:182As a reader I wonder, how is RTEProc with HTML input/output processing affected? As this is often defined within the processing YAML of ckeditor. I assume the specific implementations would then need to take care of transforming/creating TSconfig for orocessing based on their own systems? If so, a paragraph about that would helpCKEditorBuilder.php:74inject this?CKEditorBuilder.php:79Inject this?CKEditorBuilder.php:202Use kanguage domain syntax here -
Andreas Nedbal commented on patch set 27 01/28/26, 09:43
Feature-107421-EnableConfigurationOfMultipleIndependentRichtextEditorImplementations.rst:182ReplyAs this concerns a bit more than documentation (possibly) I moved this dicussion into Forge with my thoughts on it! https://forge.typo3.org/issues/107421#note-28 -
Garvin Hicking commented on patch set 27 01/28/26, 11:01
Feature-107421-EnableConfigurationOfMultipleIndependentRichtextEditorImplementations.rst:182ReplySure, I commented there. -
Benni Mack commented on patch set 27 01/30/26, 18:23
there are several things that need consideration and I suggest to put this into multiple smaller patches: a) Introduce the attribute + registry etc (I think you should move this to EXT:core, as we could use RichText in other places than FormEngine?) b) move / rename the various FormEngine adaptions into EXT:backend then c) think about configuration (your actual original plan, because I think we should carefully evaluate RteHtmlParser and RTE.proc etc) WDYT? -
Andreas Nedbal rebased onto patch set 28
V -102/02/26, 11:28The following files contain Git conflicts: * typo3/sysext/backend/Configuration/Services.php * typo3/sysext/core/Classes/Utility/ArrayUtility.php -
core-ci voted on patch set 28 V -1 02/02/26, 11:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94811
-
Andreas Nedbal uploaded patch set 29
V -102/02/26, 11:33 -
Andreas Nedbal marked it ready for review 02/02/26, 11:34
-
core-ci voted on patch set 29 V -1 02/02/26, 11:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94812
-
Andreas Nedbal uploaded patch set 30
V -102/02/26, 14:34 -
Andreas Nedbal commented on patch set 30 02/02/26, 14:39
RichTextElement.php:67ReplyDoneRichTextElement.php:135ReplyDoneFallbackEditorBuilder.php:67ReplyDoneFallbackEditorBuilder.php:109ReplyDoneRichtextEditorDefinition.php:20ReplyDoneRichtextEditorRegistry.php:23ReplyDoneRichtextEditorRegistry.php:26ReplyDoneCKEditorBuilder.php:74ReplyDoneCKEditorBuilder.php:79ReplyDoneCKEditorBuilder.php:202ReplyDone -
core-ci voted on patch set 30 V -1 02/02/26, 14:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94822
-
Andreas Nedbal uploaded patch set 31
V -102/02/26, 17:00 -
core-ci voted on patch set 31 V -1 02/02/26, 17:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94831
-
Andreas Nedbal uploaded patch set 32
V -102/03/26, 14:48 -
core-ci voted on patch set 32 V -1 02/03/26, 14:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94919
-
Andreas Nedbal uploaded patch set 33
V -102/03/26, 14:57 -
core-ci voted on patch set 33 V +1 02/03/26, 15:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94921
-
Garvin Hicking commented on patch set 33 02/03/26, 16:41
RichtextEditorUtility.php:23i think this should be @internalRichtextEditorUtility.php:30Can we do this as a injectable service class, or add to the registry as utility method Or even dierectly into the UriBulder class? It hurts a bit to have a single static utility class.RichtextTest.php:98Maybe instead use the canonicalizing equals assertion? -
Andreas Nedbal uploaded patch set 34
V +102/03/26, 19:53 -
core-ci voted on patch set 34 V -1 02/03/26, 20:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94939
-
Andreas Nedbal commented on patch set 34 02/03/26, 20:21
Reply
I don't think we should. In the future setting that by default in `rte_ckeditor` shouldn't be done anyway. This pretty much is a compatibility setting as in "if rte_ckeditor is installed, it's enabled" Also, no idea if this can be hooked into, but unless the registry is queried in the configuration, there is no "default list of editors" available.RichtextEditorUtility.php:23ReplyNot really, this utility is supposed to make it easier to generate a link to the linkbrowser for a configured RTE, working mainly off the TCA data array (with optionally being able to override options inside)RichtextEditorUtility.php:30ReplyThat could be a possibility, I guess? I just had no sensible place for this utility in anything that existed as of yet. Also, there might be other things that could be moved in here (like sanitizeFieldName maybe)Feature-107421-EnableConfigurationOfMultipleIndependentRichtextEditorImplementations.rst:122ReplyDoneFeature-107421-EnableConfigurationOfMultipleIndependentRichtextEditorImplementations.rst:182ReplyDoneRichtextTest.php:98ReplyTried using that, the currently working assertions then failed (because of other array elements). -
Andreas Nedbal uploaded patch set 35
V -102/03/26, 20:28 -
core-ci voted on patch set 35 V +1 02/03/26, 20:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94945
-
Andreas Nedbal commented on patch set 35 02/03/26, 21:05
Reply
a) We considered this possibility, but the current implementations have bundled code that is only relevant in the backend (linkbrowser) and splitting that bundle to make CKEditor usable in any other context is too much work to be worth it (and people would be limited to CKEditor functionality from our release cycles). b) I'm not exactly sure which FormEngine adaptations you mean here. c) This current code barely touches (existing) configuration logic. CKEditor is still configured as is, and aside of the requirement to have a `processing` section, other RTEs are free to do what they want. So, I think for 15 we can tackle the RteHtmlParser and configuration separately and find a nice way to use that across TCA and DataHandler. So, for whats it worth I wouldn't split up this patch as it is. It allows people to test the implementation of custom RTEs and also works the same way as before, not introducing any breaking behaviour as of now. -
Garvin Hicking commented on patch set 35 02/03/26, 21:49
RichtextEditorUtility.php:30ReplyI just think we try to stay away from static utility methods, so maybe a service class would then be more ... servicable? ;)RichtextEditorUtility.php:32```suggestion if ($data === []) { ``` -
Andreas Nedbal uploaded patch set 36
V +102/04/26, 09:55 -
core-ci voted on patch set 36 V +1 02/04/26, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94989
-
Andreas Nedbal uploaded patch set 37
V +102/04/26, 10:44 -
Andreas Nedbal uploaded patch set 38 02/04/26, 10:46
-
Andreas Nedbal uploaded patch set 39 02/04/26, 10:52
-
Andreas Nedbal commented on patch set 39 02/04/26, 10:53
RichTextElement.php:92ReplyAcknowledgedRichtextEditorUtility.php:30ReplyDoneRichtextEditorUtility.php:32ReplyDoneext_localconf.php:9ReplyDoneext_localconf.php:24ReplyI think we should leave this as-is for now, general configuration/preset handling is probably a larger task ahead that we should tackle in the next version. -
Simon Schaufelberger commented on patch set 39 02/04/26, 11:10
Feature-107421-EnableConfigurationOfMultipleIndependentRichtextEditorImplementations.rst:77use `.. code-block:: php` (with more spaces) -
core-ci voted on patch set 39 V +1 02/04/26, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95007
-
Andreas Nedbal uploaded patch set 40
V +102/04/26, 11:22 -
Andreas Nedbal commented on patch set 40 02/04/26, 11:22
Feature-107421-EnableConfigurationOfMultipleIndependentRichtextEditorImplementations.rst:77ReplyDone -
core-ci voted on patch set 40 V +1 02/04/26, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95013
-
Andreas Nedbal commented on patch set 40 02/04/26, 14:14
CKEditorBuilder.php:66ReplyThe configuration that's resolved here is built using field TCA config passed to it, and the resulting configuration also contains backend paths/references and so forth. If you just want to have an instance of CKEditor somewhere else in the backend, you can use the result from CKEditorBuilder->buildDefinition to assemble the markup and load the required CSS/JS yourself, that should be relatively straight-forward. Using the resulting config (or the entire definition) outside of the backend is not recommended, because it most likely won't work either. -
Andreas Nedbal uploaded patch set 41
V +102/05/26, 11:20 -
Andreas Nedbal uploaded patch set 42 02/05/26, 11:26
-
core-ci voted on patch set 41 V -1 02/05/26, 11:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95134
-
core-ci voted on patch set 42 V +1 02/05/26, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95136
-
Andreas Nedbal commented on patch set 42 02/05/26, 16:08
Reply
To amend on this a bit, I talked with Oli Bartsch on this and wanted to initially rebuke with "RTEs need FormEngine field array information to work". I however deduced (required) information and added a new `RichtextEditorConfiguration` DTO that can be either handcrafted or built from FormEngine field data using RichtextEditorService. With this change implementations are now mostly independent from FormEngine. CKEditor still uses it to preserve existing event functionality and the fallback editor uses the field data for reasoning on why the configured editor hasn't been loaded. To reflect this, the classes have been moved into the `Backend/Richtext/` namespace instead. I don't think EXT:core is the correct place for this, as the RTEs are part of the backend experience. -
Benni Mack commented on patch set 42 02/05/26, 18:10
RichtextEditorBuilderInterface.php:22maybe you can add some info / context to the interface? This is IMHO the thing that people need to implement, and thus, to understand.RichtextEditorService.php:53you can inject UriBuilder -
Garvin Hicking commented on patch set 42 02/05/26, 20:36
Richtext.php:134UnresolvedThis method moved to ArrayUtility does not seem to have foreign usages, is it really needed to introduce a new static method there? Otherwise I wonder if we should instead utililze the similar method in TypoScriptService (and add a new argument for the `_typoScriptNodeValue` special treatment as a switch)?Feature-107421-EnableConfigurationOfMultipleIndependentRichtextEditorImplementations.rst:6Please harmonize with paragraph below, so either "richtext editor" or "Rich Text Editor"Feature-107421-EnableConfigurationOfMultipleIndependentRichtextEditorImplementations.rst:16Mention TipTap here, if that is our go-to implementation?Feature-107421-EnableConfigurationOfMultipleIndependentRichtextEditorImplementations.rst:83The "YAML:" suggests that an example follows where no YAML file is used, but in fact it is. I would remove the ":", end the sentence, and add a new one: "Here is an example usual preset configuration:"Feature-107421-EnableConfigurationOfMultipleIndependentRichtextEditorImplementations.rst:117Please also add an example for this processing key to avoid confusion which one it might be: processing... RTE.processing... RTE.default.processing RTE.default.richtextEditor.processingFeature-107421-EnableConfigurationOfMultipleIndependentRichtextEditorImplementations.rst:122```suggestion Example implementation of a custom RTE builder ``` (also adjust number of dashes then, I could'nt easily suggest it, sorry 😄CKEditorBuilder.php:394Unresolvedplease use `@deprecated` so it can be found later -
Josua Vogel commented on patch set 42 02/16/26, 13:42
RichtextEditorRegistry.php:31add void as return typeRichtextEditorRegistry.php:44Unresolvedmaybe we should use the ContainerInterface ( $this->container->get() ) instead of makeInstance? same belowRoutes.php:305Can we rename this route (or is this breaking)? I think it shouldn´t contain rteckeditor... maybe just rte_wizard_browse_links -
Josua Vogel commented on patch set 42 02/16/26, 13:49
RichtextEditorConfiguration.php:22I think this is meant to be a DTO, so it should be readonly -
Andreas Nedbal commented on patch set 42 02/16/26, 14:15
Routes.php:305Reply UnresolvedI decided to not rename the route as to not make it breaking, if there even is outside usage of the route at all (which I should search for). -
Benni Mack wrote 04/21/26, 14:51
Removed cc Benni Mack. -
Benni Mack uploaded patch set 43
V +107/23/26, 12:41 -
core-ci voted on patch set 43 V -1 07/23/26, 12:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105247
-
Benni Mack uploaded patch set 44
V -109/16/26, 07:54 -
Benni Mack commented on patch set 44 09/16/26, 07:57
RichtextEditorBuilderInterface.php:22ReplyDoneRichtextEditorConfiguration.php:22ReplyDoneRichtextEditorRegistry.php:31ReplyDoneRichtextEditorService.php:53ReplyDoneFeature-107421-EnableConfigurationOfMultipleIndependentRichtextEditorImplementations.rst:6ReplyDoneFeature-107421-EnableConfigurationOfMultipleIndependentRichtextEditorImplementations.rst:16ReplyDoneFeature-107421-EnableConfigurationOfMultipleIndependentRichtextEditorImplementations.rst:83ReplyDoneFeature-107421-EnableConfigurationOfMultipleIndependentRichtextEditorImplementations.rst:117ReplyDoneFeature-107421-EnableConfigurationOfMultipleIndependentRichtextEditorImplementations.rst:122ReplyDone -
core-ci voted on patch set 44 V -1 09/16/26, 08:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108661
-
Andreas Nedbal uploaded patch set 45
V -111/13/26, 12:57 -
core-ci voted on patch set 45 V -1 11/13/26, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114315