Review 13.4 Merged

90623[SECURITY] Prevent information disclosure via filesystem E_WARNING errors

Oliver Hader CR +2 V +2 Normal +35 −20 updated 09/09/25, 08:35

Commit message

FAL's `LocalDriver` executes several filesystem operations and stores
their results for further evaluation. Unfortunately, due to how PHP
works internally, besides returning `false` also a PHP warning is
emitted, exposing absolute paths of the TYPO3 installation, when the
warnings are transformed into exceptions by the TYPO3 error handler.

All filesystem operations in `LocalDriver` are now silenced via a
prepended `@` to ensure that error handlers skip these warnings.

Also, when renaming a file, the result is now compared to the original
file name to check for any differences. An error is assumed if the file
name did not change after attempting to rename it.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 3

Review log 34

  1. Oliver Hader uploaded patch set 1 09/09/25, 08:01

  2. Oliver Hader commented on patch set 1 CR +2 V +2 09/09/25, 08:01

    Auto-approved
  3. Oliver Hader merged patch set 2 09/09/25, 08:01

  4. core-ci voted on patch set 1 V +1 09/09/25, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84665