Review main Merged

90640[TASK] Deprecate getRelativePath(to) methods in PathUtility

Benni Mack CR +2 V +2 Normal +138 −111 updated 09/10/25, 11:01

Commit message

Various methods are not needed anymore as TYPO3's path
handling is simplified due to the unification of
the entry point URLs.

The following methods have been deprecated:
* PathUtility::getRelativePath()
* PathUtility::getRelativePathTo()

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1929

Show 24 earlier messages
  1. Benni Mack uploaded patch set 1 09/09/25, 10:21

  2. core-ci voted on patch set 1 V -1 09/09/25, 10:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84693

  3. Benni Mack uploaded patch set 2 V -1 09/09/25, 10:49

  4. core-ci voted on patch set 2 V -1 09/09/25, 10:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84696

  1. Benni Mack updated the commit message in patch set 3 V -1 09/09/25, 10:59

  2. Benni Mack uploaded patch set 4 09/09/25, 11:03

  3. core-ci voted on patch set 3 V -1 09/09/25, 11:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84697

  4. core-ci voted on patch set 4 V +1 09/09/25, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84698

  5. Benni Mack uploaded patch set 5 V +1 09/09/25, 11:52

  6. Benni Mack updated the commit message in patch set 6 09/09/25, 11:52

  7. core-ci voted on patch set 6 V -1 09/09/25, 12:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84700

  8. core-ci voted on patch set 5 V -1 09/09/25, 12:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84699

  9. Helmut Hummel uploaded patch set 7 V -1 09/09/25, 12:54

  10. core-ci voted on patch set 7 V -1 09/09/25, 13:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84704

  11. Andreas Kienast uploaded patch set 8 V -1 09/09/25, 13:47

  12. core-ci voted on patch set 8 V +1 09/09/25, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84707

  13. Garvin Hicking commented on patch set 8 09/09/25, 18:32

    MethodCallStaticMatcher.php:1717

    addPiFlexformValue feels wrong 🤓 (should be two entries, too)
  14. Benni Mack commented on patch set 9 V +1 09/09/25, 20:49

    Published edit on patch set 8.
  15. core-ci voted on patch set 9 V +1 09/09/25, 20:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84747

  16. Benni Mack commented on patch set 9 09/09/25, 21:27

    MethodCallStaticMatcher.php:1717 Reply

    Done
  17. Oli Bartsch uploaded patch set 10 V +1 09/10/25, 10:31

  18. Oli Bartsch voted on patch set 10 CR +1 V +1 09/10/25, 10:32

  19. core-ci voted on patch set 10 V +1 09/10/25, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84770

  20. Stefan Bürk voted on patch set 10 CR +1 09/10/25, 10:41

  21. Garvin Hicking commented on patch set 10 CR +1 V +1 09/10/25, 10:49

    Tested in composer-mode which also seeems to work fine for me.
  22. Stefan Bürk voted on patch set 10 V +1 09/10/25, 10:55

  23. Benni Mack commented on patch set 10 CR +2 V +2 09/10/25, 10:55

    thx
  24. Benni Mack merged patch set 11 09/10/25, 10:55

  25. Oli Bartsch commented on patch set 11 09/10/25, 11:01

    Reply

    Great, thanks!