90645[BUGFIX] Fix url check in GeneralUtility::sanitizeLocalUrl
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oliver Hader +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oliver Hader +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1215
-
Thomas Hohn uploaded patch set 1 09/09/25, 15:07
-
core-ci voted on patch set 1 V +1 09/09/25, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84719
-
Oliver Klee commented on patch set 1 09/09/25, 15:36
Could we cover this with a regression test? -
Thomas Hohn commented on patch set 1 09/09/25, 16:13
Reply
I would like to see if the approach is ok first 😊 -
Thomas Hohn uploaded patch set 2
V +109/09/25, 17:04 -
core-ci voted on patch set 2 V +1 09/09/25, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84736
-
Thomas Hohn commented on patch set 2 09/09/25, 18:42
Reply
Done -
Benjamin Franzke commented on patch set 2 CR -1 09/10/25, 07:48
Thanks for the patch! I'm on it to review this -
Benjamin Franzke uploaded patch set 3
CR -1V +109/10/25, 09:12 -
Benjamin Franzke commented on patch set 3 09/10/25, 09:12
Reply
reworked a bit, lgtm now. thx!GeneralUtilityTest.php:1406The test below tries to use the plain URL and an explicitly encoded one, that means these cases must not be encoded. I've changed it accordingly. -
core-ci voted on patch set 3 V +1 09/10/25, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84766
-
Thomas Hohn commented on patch set 3 09/10/25, 10:02
Reply
Thx - just testet it and it works as before -
Oliver Hader voted on patch set 3 CR +1 V +1 09/15/25, 09:15
-
Benjamin Franzke voted on patch set 3 CR +2 V +2 09/15/25, 12:59
-
Benjamin Franzke merged patch set 4 09/15/25, 13:21