Review main Merged

90652[BUGFIX] Allow editing site settings without root page being present

Elias Häußler CR +2 V +2 Easy +2 −2 updated 09/10/25, 12:55

Commit message

If a site is configured for a non-existing root page id, an exception is
thrown when trying to edit site settings. Although the configured root
page should exist, especially during development it might be possible
that this is not the case (yet).

With this patch, this behavior is now hardened: A configured root page
is no longer expected to actually exist, and related meta information is
not populated to the docheader component in this case.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benjamin Franzke +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Elias Häußler uploaded patch set 1 09/10/25, 07:34

  2. core-ci voted on patch set 1 V +1 09/10/25, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84761

  3. Mathias Brodala commented on patch set 1 09/10/25, 07:44

    SiteSettingsController.php:284

    Would it be beneficial if we'd pass an empty array as fallback instead? Also if we keep this, it should use an early return instead.
  4. Elias Häußler uploaded patch set 2 V +1 09/10/25, 08:14

  5. Elias Häußler commented on patch set 2 09/10/25, 08:14

    SiteSettingsController.php:284 Reply

    Good point, thanks. An empty array works here as well.
  6. core-ci voted on patch set 2 V +1 09/10/25, 08:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84765

  7. Mathias Brodala voted on patch set 2 CR +1 09/10/25, 08:53

  8. Benjamin Franzke voted on patch set 2 CR +1 V +1 09/10/25, 09:14

  9. Garvin Hicking voted on patch set 2 CR +2 V +2 09/10/25, 12:45

  10. Garvin Hicking merged patch set 3 09/10/25, 12:55