Review main Merged

90657[TASK] Add json examples to the styleguide

Georg Ringer CR +2 V +2 Normal +82 −1 updated 09/11/25, 12:36

Commit message

Add examples of TCA type "json" to the styleguide.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1420

  1. Georg Ringer uploaded patch set 1 09/10/25, 18:42

  2. Georg Ringer commented on patch set 1 09/10/25, 18:42

    This change is ready for review.
  3. Georg Ringer commented on patch set 2 09/10/25, 18:46

    Published edit on patch set 1.
  4. core-ci voted on patch set 1 V -1 09/10/25, 18:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84795

  5. Georg Ringer commented on patch set 3 09/10/25, 18:51

    Published edit on patch set 2.
  6. core-ci voted on patch set 2 V -1 09/10/25, 18:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84796

  7. core-ci voted on patch set 3 V +1 09/10/25, 19:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84798

  8. Garvin Hicking commented on patch set 3 09/10/25, 19:30

    Services.yaml:75

    ```suggestion # General type=json generator ```
  9. Garvin Hicking commented on patch set 4 V +1 09/10/25, 19:30

    Published edit on patch set 3.
  10. Garvin Hicking commented on patch set 4 CR +1 09/10/25, 19:31

    Oh I did not notice this was missing. Will check out tomorrow :)

    Services.yaml:75 Reply

    Fix applied.
  11. core-ci voted on patch set 4 V +1 09/10/25, 19:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84800

  12. Simon Schaufelberger commented on patch set 4 09/11/25, 00:36

    KauderwelschService.php:144

    this comment is very confusing as nothing is true. no object and no string?!
  13. Georg Ringer commented on patch set 5 CR +1 V +1 09/11/25, 05:36

    Published edit on patch set 4.
  14. core-ci voted on patch set 5 V +1 09/11/25, 05:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84816

  15. Simon Schaufelberger commented on patch set 5 CR +1 V +1 09/11/25, 08:43

    KauderwelschService.php:144 Reply

    Done
  16. Oli Bartsch uploaded patch set 6 CR +1 V +1 09/11/25, 09:06

  17. Oli Bartsch voted on patch set 6 CR +1 V +1 09/11/25, 09:06

  18. core-ci voted on patch set 6 V +1 09/11/25, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84822

  19. Garvin Hicking voted on patch set 6 CR +2 V +2 09/11/25, 12:23

  20. Garvin Hicking merged patch set 7 09/11/25, 12:36