90657[TASK] Add json examples to the styleguide
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Oli Bartsch +1
-
Verified V +2 Done
- Garvin Hicking +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/styleguide/Classes/Service/KauderwelschService.php2+17 −0
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeJson.phpnew+44 −0
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGeneratorInterface.php+1 −1
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_elements_basic.php+17 −0
- typo3/sysext/styleguide/Configuration/Services.yaml2+3 −0
Review log 1420
-
Georg Ringer uploaded patch set 1 09/10/25, 18:42
-
Georg Ringer commented on patch set 1 09/10/25, 18:42
This change is ready for review. -
Georg Ringer commented on patch set 2 09/10/25, 18:46
Published edit on patch set 1. -
core-ci voted on patch set 1 V -1 09/10/25, 18:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84795
-
Georg Ringer commented on patch set 3 09/10/25, 18:51
Published edit on patch set 2. -
core-ci voted on patch set 2 V -1 09/10/25, 18:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84796
-
core-ci voted on patch set 3 V +1 09/10/25, 19:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84798
-
Garvin Hicking commented on patch set 3 09/10/25, 19:30
Services.yaml:75```suggestion # General type=json generator ``` -
Garvin Hicking commented on patch set 4
V +109/10/25, 19:30Published edit on patch set 3. -
Garvin Hicking commented on patch set 4 CR +1 09/10/25, 19:31
Oh I did not notice this was missing. Will check out tomorrow :)Services.yaml:75ReplyFix applied. -
core-ci voted on patch set 4 V +1 09/10/25, 19:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84800
-
Simon Schaufelberger commented on patch set 4 09/11/25, 00:36
KauderwelschService.php:144this comment is very confusing as nothing is true. no object and no string?! -
Georg Ringer commented on patch set 5
CR +1V +109/11/25, 05:36Published edit on patch set 4. -
core-ci voted on patch set 5 V +1 09/11/25, 05:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84816
-
Simon Schaufelberger commented on patch set 5 CR +1 V +1 09/11/25, 08:43
KauderwelschService.php:144ReplyDone -
Oli Bartsch uploaded patch set 6
CR +1V +109/11/25, 09:06 -
Oli Bartsch voted on patch set 6 CR +1 V +1 09/11/25, 09:06
-
core-ci voted on patch set 6 V +1 09/11/25, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84822
-
Garvin Hicking voted on patch set 6 CR +2 V +2 09/11/25, 12:23
-
Garvin Hicking merged patch set 7 09/11/25, 12:36