90658[!!!][FEATURE] Use symfony/translation for translatable labels
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Garvin Hicking +1
-
Verified V +2 Done
- Georg Ringer +2
- Garvin Hicking +1
Issues 1
Files 31
- Build/phpstan/phpstan-baseline.neon+0 −12
- typo3/sysext/core/Classes/Localization/Loader/XliffLoader.php6new+170 −0
- typo3/sysext/core/Classes/Localization/Parser/AbstractXmlParser.php+6 −0
- typo3/sysext/core/Classes/Localization/Parser/LocalizationParserInterface.php+1 −0
- typo3/sysext/core/Classes/Localization/Parser/XliffParser.php+2 −1
- typo3/sysext/core/Classes/Localization/LanguageService.php+2 −2
- typo3/sysext/core/Classes/Localization/LanguageStore.phpdeleted+0 −265
- typo3/sysext/core/Classes/Localization/Locales.php+1 −1
- typo3/sysext/core/Classes/Localization/LocalizationFactory.php+342 −62
- typo3/sysext/core/Classes/ServiceProvider.php+11 −8
- typo3/sysext/core/Configuration/DefaultConfiguration.php+12 −11
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml5+16 −7
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-107436-LocalizationSystemChanges.rstnew+104 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Deprecation-107436-LocalizationParsers.rstnew+65 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107436-SymfonyTranslationIntegration.rstnew+76 −0
- typo3/sysext/core/Tests/Functional/Localization/LanguageServiceTest.php+8 −6
- typo3/sysext/core/Tests/Unit/Localization/Loader/Fixtures/fr.locallang.xlfrenamed+0 −0
- typo3/sysext/core/Tests/Unit/Localization/Loader/Fixtures/locallang.xlfrenamed+0 −0
- typo3/sysext/core/Tests/Unit/Localization/Loader/XliffLoaderTest.phpnew+142 −0
- typo3/sysext/core/Tests/Unit/Localization/Parser/XliffParserTest.phpdeleted+0 −67
Show 11 more files
- typo3/sysext/core/Tests/Unit/Localization/LocalizationFactoryTest.php+54 −18
- typo3/sysext/core/Tests/Unit/Page/PageRendererFactoryTrait.php+5 −3
- typo3/sysext/core/composer.json+1 −0
- typo3/sysext/install/Classes/Controller/MaintenanceController.php+4 −4
- typo3/sysext/install/Classes/Service/LanguagePackService.php2+2 −2
- typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php+65 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+35 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+16 −0
- typo3/sysext/install/Tests/Functional/Service/SilentConfigurationUpgradeServiceTest.php+124 −0
- composer.json+1 −1
- composer.lock+179 −174
Review log 3451
Show 1426 earlier messages
-
Benni Mack uploaded patch set 1 09/10/25, 20:31
-
Benni Mack marked it work in progress 09/10/25, 20:31
-
core-ci voted on patch set 1 V -1 09/10/25, 20:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84801
-
Benni Mack uploaded patch set 2
V -109/10/25, 20:51 -
core-ci voted on patch set 2 V -1 09/10/25, 20:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84802
-
Benni Mack uploaded patch set 3
V -109/10/25, 21:08 -
core-ci voted on patch set 3 V +1 09/10/25, 21:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84803
-
Benni Mack uploaded patch set 4
V +109/11/25, 09:37 -
core-ci voted on patch set 4 V +1 09/11/25, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84826
-
Benni Mack uploaded patch set 5
V +109/11/25, 10:22 -
core-ci voted on patch set 5 V -1 09/11/25, 10:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84827
-
Benni Mack uploaded patch set 6
V -109/11/25, 11:07 -
core-ci voted on patch set 6 V -1 09/11/25, 11:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84833
-
Benni Mack uploaded patch set 7
V -109/11/25, 11:41 -
core-ci voted on patch set 7 V -1 09/11/25, 11:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84836
-
Benni Mack uploaded patch set 8
V -109/11/25, 13:17 -
core-ci voted on patch set 8 V -1 09/11/25, 13:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84844
-
Garvin Hicking updated the commit message in patch set 9
V -109/11/25, 13:38 -
Benni Mack uploaded patch set 10 09/11/25, 13:45
-
Garvin Hicking uploaded patch set 11 09/11/25, 13:46
-
Benni Mack uploaded patch set 12 09/11/25, 13:47
-
core-ci voted on patch set 9 V -1 09/11/25, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84847
-
core-ci voted on patch set 10 V -1 09/11/25, 14:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84848
-
core-ci voted on patch set 11 V -1 09/11/25, 14:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84849
-
core-ci voted on patch set 12 V -1 09/11/25, 14:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84850
-
Garvin Hicking uploaded patch set 13
V -109/11/25, 14:05
-
Benni Mack marked it ready for review 09/11/25, 14:06
-
Garvin Hicking commented on patch set 13 09/11/25, 14:13
-
core-ci voted on patch set 13 V -1 09/11/25, 14:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84852
-
Benni Mack uploaded patch set 14
V -109/11/25, 14:37 -
core-ci voted on patch set 14 V -1 09/11/25, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84853
-
Benni Mack commented on patch set 14 09/11/25, 15:02
LanguagePackService.php:80ReplyDone -
Benni Mack uploaded patch set 15
V -109/11/25, 15:19 -
core-ci voted on patch set 15 V +1 09/11/25, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84855
-
Garvin Hicking commented on patch set 15 09/11/25, 16:51
XliffLoader.php:40due to this method only accepting strings, the resource check is moot? because this would throw an exception on a resource? Hiw about throwing directly if $resource is not a string...? -
Garvin Hicking commented on patch set 15 09/11/25, 17:24
I think we could add these arrays to the extension scanner array matcher? Silent migration applied to write context but not reading, so catching these would help for people accessing these in extensions -
Garvin Hicking commented on patch set 15 09/11/25, 17:37
XliffLoader.php:36This could be final readonly if we want to lock it down, and private methods? -
Benni Mack commented on patch set 15 09/11/25, 17:59
XliffLoader.php:40Replywe could do this, yes. -
Garvin Hicking uploaded patch set 16
V +109/11/25, 18:06 -
Garvin Hicking commented on patch set 16 09/11/25, 18:07
Reply
Added this.XliffLoader.php:40ReplyDone -
Garvin Hicking commented on patch set 16 09/11/25, 18:12
DefaultConfigurationDescription.yaml:249Both these "array" types could instead use the new "element-list" type (https://review.typo3.org/c/Packages/TYPO3.CMS/+/89040) - what do you think? -
core-ci voted on patch set 16 V +1 09/11/25, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84858
-
Benni Mack commented on patch set 16 09/11/25, 19:25
XliffLoader.php:36Replygo ahead.DefaultConfigurationDescription.yaml:249Replyyes please! -
Garvin Hicking uploaded patch set 17
V +109/11/25, 19:38 -
Garvin Hicking commented on patch set 17 CR +1 V +1 09/11/25, 19:39
XliffLoader.php:36ReplyDoneDefaultConfigurationDescription.yaml:249ReplyDone -
Georg Ringer voted on patch set 17 CR +2 V +2 09/11/25, 19:50
-
Georg Ringer merged patch set 18 09/11/25, 19:50
-
core-ci voted on patch set 17 V +1 09/11/25, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84860
-
Benjamin Franzke commented on patch set 18 09/12/25, 08:51
DefaultConfigurationDescription.yaml:243It seems this should have been type `map` since it is using string-indexed values (currently `'xlf'` in `DefaultConfiguration.php`) -
Benjamin Franzke commented on patch set 18 09/12/25, 08:57
DefaultConfigurationDescription.yaml:243Reply90671: [BUGFIX] Make sure SYS/LANG/loader is a map | https://review.typo3.org/c/Packages/TYPO3.CMS/+/90671 -
Lina Wolf commented on patch set 18 09/20/25, 05:49
Please review Documentation at https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/pull/6047
LanguagePackService.php:80