Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
90667[BUGFIX] Skip invalid parameters while creating editing form
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 7
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/67/90667/7 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/67/90667/7 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 1
Files 2
Review log 3037
Show 1112 earlier messages
-
Georg Ringer uploaded patch set 1 09/11/25, 19:36
-
Georg Ringer commented on patch set 1 09/11/25, 19:36
This change is ready for review. -
Markus Klein commented on patch set 1 09/11/25, 19:51
EditDocumentController.php:418maybe check validity even here, before assigning it?EditDocumentController.php:577needed here as well? -
core-ci voted on patch set 1 V +1 09/11/25, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84859
-
Georg Ringer commented on patch set 1 09/12/25, 07:55
@markus.klein@typo3.org yeah in theory this should be done far earlier but I fear missing some magic once done there. this whole code would need far more changes to convert those [table][id]=action magic into some DTOs - therefore I just wanted to fix this bug -
Markus Klein voted on patch set 1 CR +1 V +1 09/12/25, 08:02
-
Nikita Hovratov commented on patch set 1 CR +1 V +1 09/12/25, 08:13
Works, I get a flash message "Edit form could not be loaded" now. -
Garvin Hicking commented on patch set 1 09/12/25, 08:16
EditDocumentController.php:958I don't feel good about this explicit phpstan rule. I think we should adjust the phpdoc comment above: ``` * @var array<string,array> ``` to include that its `string|int` because of userinput. Otherwise we should iterate the input GET var and do explicit (string) casting...? -
Nikita Hovratov commented on patch set 1 09/12/25, 08:16
EditDocumentController.php:2100We could also adjust the type hint for editconf as array<string|int, array> I don't know if this might cause more stan errors at other places though. -
Garvin Hicking voted on patch set 1 CR -1 09/12/25, 08:16
-
Oli Bartsch commented on patch set 1 09/12/25, 08:26
EditDocumentController.php:418Reply+1 -
Georg Ringer uploaded patch set 2
CR +1V +109/12/25, 08:44
-
core-ci voted on patch set 2 V +1 09/12/25, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84893
-
Nikita Hovratov uploaded patch set 3
V +109/12/25, 08:59 -
core-ci voted on patch set 3 V +1 09/12/25, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84898
-
Markus Klein commented on patch set 3 09/12/25, 09:16
EditDocumentController.php:577ReplyDone -
Markus Klein voted on patch set 3 CR +1 09/12/25, 09:16
-
Nikita Hovratov voted on patch set 3 CR +1 V +1 09/12/25, 09:25
-
Nikita Hovratov commented on patch set 3 09/12/25, 09:25
EditDocumentController.php:2100ReplyDone -
Garvin Hicking commented on patch set 3 CR -1 09/12/25, 10:52
EditDocumentController.php:419'edit' can even be a string. Needs further restriction, on it.EditDocumentController.php:958ReplyDone -
Garvin Hicking commented on patch set 4
CR +1V +109/12/25, 11:16Published edit on patch set 3. -
Garvin Hicking commented on patch set 4 09/12/25, 11:17
EditDocumentController.php:419ReplyThis had a few other cases, updated commit message and code. I don't feel too confident right now, happy for review. -
core-ci voted on patch set 4 V +1 09/12/25, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84906
-
Oli Bartsch commented on patch set 4 09/12/25, 11:42
EditDocumentController.php:418ReplyDoneEditDocumentController.php:419Why do we expect that to be an array while we check `$queryParams`? Can we get some code comment here? Using array_filter with a mix of ternary and null coalescing operators is really hard to understand..EditDocumentController.php:478Do we know the reason for not using `$this->editconf` here?EditDocumentController.php:2293Do we know the reason for not using `$this->editconf` here? -
Georg Ringer commented on patch set 4 09/16/25, 18:48
@oli feel free to fix the other findings, but IMHO really not part of this patch -
Benni Mack updated the commit message in patch set 5
V +104/22/26, 06:31 -
core-ci voted on patch set 5 V -1 04/22/26, 07:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100722
-
Georg Ringer uploaded patch set 6
V -109/16/26, 20:59 -
Georg Ringer commented on patch set 3 09/16/26, 21:05
EditDocumentController.php:419ReplyHandled, a non-array edit parameter is caught before sanitizeEditConf() now. -
Georg Ringer commented on patch set 4 09/16/26, 21:05
EditDocumentController.php:419ReplyRewritten after the rebase, the array_filter is gone and there is a comment now.EditDocumentController.php:478ReplyprepareColumnsOnlyConfigurationFromRequest() still reads the raw query params. Using $this->editconf would additionally pull in parsedBody and the sanitizeEditConf() filtering (TCA existence, tables_modify).EditDocumentController.php:2293ReplyGone with the rebase, the doc header title is built from FormElementData now. -
core-ci voted on patch set 6 V +1 09/16/26, 21:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108727
-
Simon Schaufelberger commented on patch set 6 09/17/26, 09:11
EditDocumentController.php:415should we not throw an exception if it's not a string instead of casting here? -
Benni Mack commented on patch set 6 10/22/26, 15:45
what to do with this issue? -
Benni Mack uploaded patch set 7
V +110/22/26, 16:32 -
Benni Mack marked it ready for review 10/22/26, 16:33
-
Benni Mack commented on patch set 7 10/22/26, 16:33
EditDocumentController.php:415ReplyDoneEditDocumentController.php:419ReplyDone -
core-ci voted on patch set 7 V +1 10/22/26, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112151