90675[!!!][FEATURE] Introduce System Resource API to resolve files/assets
Commit message
Review
-
Code review CR +2 Done
- Helmut Hummel +2
- Garvin Hicking +1
- Simon Praetorius +1
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Helmut Hummel +2
- Garvin Hicking +1
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 5
- Bug #107537Create preliminary SystemResource API to unify extension resource URI generation
- Bug #82574Inconsistent support of config.absRefPrefix in fluid/extbase
- Bug #97733Test mail setup fails with resources from fileadmin
- Bug #96063custom Backend Login Logo within fileadmin breaks MAIL functionality
- Feature #97671File versioning in query string
Files 192
- typo3/sysext/adminpanel/Classes/Controller/MainController.php+2 −2
- typo3/sysext/adminpanel/Classes/Utility/ResourceUtility.php2+11 −10
- typo3/sysext/backend/Classes/Backend/Avatar/Avatar.php+1 −1
- typo3/sysext/backend/Classes/Controller/Wizard/EditController.php+8 −11
- typo3/sysext/backend/Classes/Controller/AbstractFormEngineAjaxController.php3+2 −6
- typo3/sysext/backend/Classes/Controller/BackendController.php+20 −18
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+5 −5
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+5 −4
- typo3/sysext/backend/Classes/Form/Utility/FormEngineUtility.php+15 −15
- typo3/sysext/backend/Classes/Template/PageRendererBackendSetupTrait.php+34 −27
- typo3/sysext/backend/Tests/Functional/Controller/LiveSearchControllerTest.php+13 −4
- typo3/sysext/backend/Tests/Functional/Template/Components/Buttons/Action/ShortcutButtonTest.php+2 −2
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordList.htmldeleted+0 −15
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordList.phpnew+33 −0
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListCopyToClipboard.phprenamed+22 −4
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListSingleTable.htmldeleted+0 −13
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListSingleTable.phpnew+31 −0
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListSingleTableCopyToClipboard.phprenamed+22 −4
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifier.htmldeleted+0 −15
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifier.phpnew+33 −0
Show 172 more files
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifierWithArguments.htmldeleted+0 −15
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifierWithArguments.phpnew+33 −0
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifierWithArgumentsCopyToClipboard.phprenamed+22 −4
- typo3/sysext/core/Classes/Http/Security/ReferrerEnforcer.php+4 −3
- typo3/sysext/core/Classes/Http/ServerRequestFactory.php+2 −1
- typo3/sysext/core/Classes/Imaging/IconProvider/AbstractSvgIconProvider.php1+26 −11
- typo3/sysext/core/Classes/Imaging/IconProvider/BitmapIconProvider.php+1 −5
- typo3/sysext/core/Classes/Imaging/IconProvider/SvgIconProvider.php+0 −6
- typo3/sysext/core/Classes/Imaging/IconProvider/SvgSpriteIconProvider.php+0 −6
- typo3/sysext/core/Classes/Package/Resource/ResourceCollection.phpnew+58 −0
- typo3/sysext/core/Classes/Package/Resource/ResourceCollectionInterface.phpnew+30 −0
- typo3/sysext/core/Classes/Package/Package.php+10 −0
- typo3/sysext/core/Classes/Package/PackageInterface.php+7 −0
- typo3/sysext/core/Classes/Page/AssetRenderer.php+6 −7
- typo3/sysext/core/Classes/Page/ImportMap.php1+15 −12
- typo3/sysext/core/Classes/Page/JavaScriptRenderer.php+2 −0
- typo3/sysext/core/Classes/Page/PageRenderer.php1+27 −27
- typo3/sysext/core/Classes/Resource/File.php+38 −1
- typo3/sysext/core/Classes/Resource/ResourceCompressor.php+125 −72
- typo3/sysext/core/Classes/Resource/ResourceFactory.php+10 −15
- typo3/sysext/core/Classes/Resource/StorageRepository.php+2 −2
- typo3/sysext/core/Classes/SystemResource/Exception/CanNotGenerateUriException.phpnew+23 −0
- typo3/sysext/core/Classes/SystemResource/Exception/CanNotResolvePublicResourceException.phpnew+23 −0
- typo3/sysext/core/Classes/SystemResource/Exception/CanNotResolveSystemResourceException.php1new+23 −0
- typo3/sysext/core/Classes/SystemResource/Exception/InvalidSystemResourceIdentifierException.phpnew+23 −0
- typo3/sysext/core/Classes/SystemResource/Exception/SystemResourceDoesNotExistException.phpnew+24 −0
- typo3/sysext/core/Classes/SystemResource/Exception/SystemResourceException.phpnew+27 −0
- typo3/sysext/core/Classes/SystemResource/Http/CacheBustingUri.php+14 −3
- typo3/sysext/core/Classes/SystemResource/Identifier/FalResourceIdentifier.phpnew+53 −0
- typo3/sysext/core/Classes/SystemResource/Identifier/PackageResourceIdentifier.phpnew+68 −0
- typo3/sysext/core/Classes/SystemResource/Identifier/SystemResourceIdentifier.phpnew+37 −0
- typo3/sysext/core/Classes/SystemResource/Identifier/SystemResourceIdentifierFactory.php6new+130 −0
- typo3/sysext/core/Classes/SystemResource/Package/ProjectResourceCollection.phpnew+65 −0
- typo3/sysext/core/Classes/SystemResource/Package/VirtualAppPackage.phpnew+43 −0
- typo3/sysext/core/Classes/SystemResource/Publishing/DefaultSystemResourcePublisher.php2new+92 −0
- typo3/sysext/core/Classes/SystemResource/Publishing/DefaultSystemResourceUriGenerator.php1new+92 −0
- typo3/sysext/core/Classes/SystemResource/Publishing/SystemResourcePublisherInterface.phpnew+37 −0
- typo3/sysext/core/Classes/SystemResource/Publishing/SystemResourceUriGeneratorInterface.phpnew+35 −0
- typo3/sysext/core/Classes/SystemResource/Publishing/UriGenerationOptions.phpnew+37 −0
- typo3/sysext/core/Classes/SystemResource/Type/PackageResource.phpnew+114 −0
- typo3/sysext/core/Classes/SystemResource/Type/PublicPackageFile.phpnew+55 −0
- typo3/sysext/core/Classes/SystemResource/Type/PublicResourceInterface.phpnew+40 −0
- typo3/sysext/core/Classes/SystemResource/Type/StaticResourceInterface.phpnew+35 −0
- typo3/sysext/core/Classes/SystemResource/Type/SystemResourceInterface.phpnew+39 −0
- typo3/sysext/core/Classes/SystemResource/Type/UriResource.php2new+43 −0
- typo3/sysext/core/Classes/SystemResource/SystemResourceFactory.phpnew+233 −0
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+1 −0
- typo3/sysext/core/Classes/Utility/PathUtility.php+31 −9
- typo3/sysext/core/Classes/ViewHelpers/NormalizedUrlViewHelper.php+15 −6
- typo3/sysext/core/Classes/ServiceProvider.php+32 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-107537-UrlGenerationSystemResources.rst17new+159 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Deprecation-107537-CreateVersionNumberedFileName.rst2new+73 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Deprecation-107537-FilePathSanitizer.rst4new+77 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Deprecation-107537-GetDataPath.rst2new+61 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Deprecation-107537-getPublicResourcesWebPath.rst5new+64 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst34new+252 −0
- typo3/sysext/core/Resources/Public/Icons/Extension.svg+5 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_system_resources/Resources/Private/Icons/Extension.svgnew+5 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_system_resources/Resources/Public/Icons/Extension.svgnew+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_system_resources/composer.jsonnew+14 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_system_resources/ext_emconf.phpnew+21 −0
- typo3/sysext/core/Tests/Functional/Fixtures/DummyFileCreationService.php1new+69 −0
- typo3/sysext/core/Tests/Functional/Imaging/IconProvider/BitmapIconProviderTest.phprenamed+16 −12
- typo3/sysext/core/Tests/Functional/Imaging/IconProvider/SvgIconProviderTest.phpnew+95 −0
- typo3/sysext/core/Tests/Functional/Imaging/IconProvider/SvgSpriteIconProviderTest.phpnew+138 −0
- typo3/sysext/core/Tests/Functional/Imaging/IconFactoryTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Imaging/IconTest.phprenamed+4 −3
- typo3/sysext/core/Tests/Functional/Page/Fixtures/ImportMap/test_importmap_core/Configuration/JavaScriptModules.phpnew+15 −0
- typo3/sysext/core/Tests/Functional/Page/Fixtures/ImportMap/test_importmap_core/Resources/Public/JavaScript/Contrib/lit/directive.jsrenamed+0 −0
- typo3/sysext/core/Tests/Functional/Page/Fixtures/ImportMap/test_importmap_core/Resources/Public/JavaScript/Contrib/lit/index.jsrenamed+0 −0
- typo3/sysext/core/Tests/Functional/Page/Fixtures/ImportMap/test_importmap_core/Resources/Public/JavaScript/nested/module.jsrenamed+0 −0
- typo3/sysext/core/Tests/Functional/Page/Fixtures/ImportMap/test_importmap_core/Resources/Public/JavaScript/Module1.jsrenamed+0 −0
- typo3/sysext/core/Tests/Functional/Page/Fixtures/ImportMap/test_importmap_core/Resources/Public/JavaScript/module2.esm.jsrenamed+0 −0
- typo3/sysext/core/Tests/Functional/Page/Fixtures/ImportMap/test_importmap_core/composer.jsonnew+14 −0
- typo3/sysext/core/Tests/Functional/Page/Fixtures/ImportMap/test_importmap_core/ext_emconf.phpnew+21 −0
- typo3/sysext/core/Tests/Functional/Page/Fixtures/ImportMap/test_importmap_package1/Resources/Public/JavaScript/NonEsmModule.jsrenamed+0 −0
- typo3/sysext/core/Tests/Functional/Page/Fixtures/ImportMap/test_importmap_package1/composer.jsonnew+14 −0
- typo3/sysext/core/Tests/Functional/Page/Fixtures/ImportMap/test_importmap_package1/ext_emconf.phpnew+21 −0
- typo3/sysext/core/Tests/Functional/Page/Fixtures/ImportMap/test_importmap_package2/Configuration/JavaScriptModules.phpnew+10 −0
- typo3/sysext/core/Tests/Functional/Page/Fixtures/ImportMap/test_importmap_package2/Resources/Public/JavaScript/File.jsrenamed+0 −0
- typo3/sysext/core/Tests/Functional/Page/Fixtures/ImportMap/test_importmap_package2/composer.jsonnew+14 −0
- typo3/sysext/core/Tests/Functional/Page/Fixtures/ImportMap/test_importmap_package2/ext_emconf.phpnew+21 −0
- typo3/sysext/core/Tests/Functional/Page/Fixtures/ImportMap/test_importmap_package3/Configuration/JavaScriptModules.phpnew+21 −0
- typo3/sysext/core/Tests/Functional/Page/Fixtures/ImportMap/test_importmap_package3/Resources/Public/JavaScript/Overrides/Package2/File.jsrenamed+0 −0
- typo3/sysext/core/Tests/Functional/Page/Fixtures/ImportMap/test_importmap_package3/composer.jsonnew+14 −0
- typo3/sysext/core/Tests/Functional/Page/Fixtures/ImportMap/test_importmap_package3/ext_emconf.phpnew+21 −0
- typo3/sysext/core/Tests/Functional/Page/Fixtures/ImportMap/test_importmap_package4/Configuration/JavaScriptModules.phpnew+7 −0
- typo3/sysext/core/Tests/Functional/Page/Fixtures/ImportMap/test_importmap_package4/composer.jsonnew+14 −0
- typo3/sysext/core/Tests/Functional/Page/Fixtures/ImportMap/test_importmap_package4/ext_emconf.phpnew+21 −0
- typo3/sysext/core/Tests/Functional/Page/Fixtures/dummy.jscopied+0 −0
- typo3/sysext/core/Tests/Functional/Page/AssetRendererTest.php+54 −64
- typo3/sysext/core/Tests/Functional/Page/ImportMapTest.phpnew+207 −0
- typo3/sysext/core/Tests/Functional/Page/PageRendererTest.php+95 −31
- typo3/sysext/core/Tests/Functional/Resource/ResourceCompressorTest.php+2 −2
- typo3/sysext/core/Tests/Functional/Resource/ResourceFactoryTest.phprenamed+11 −4
- typo3/sysext/core/Tests/Functional/SystemResource/Publishing/DefaultResourcePublisherTest.phpnew+193 −0
- typo3/sysext/core/Tests/Functional/SystemResource/SystemResourceFactoryTest.phpnew+270 −0
- typo3/sysext/core/Tests/Functional/Utility/PathUtilityPublicPathsTest.phprenamed+21 −40
- typo3/sysext/core/Tests/Functional/ViewHelpers/IconViewHelperTest.php+15 −8
- typo3/sysext/core/Tests/Unit/Imaging/IconProvider/SvgIconProviderTest.phpdeleted+0 −81
- typo3/sysext/core/Tests/Unit/Imaging/IconProvider/SvgSpriteIconProviderTest.phpdeleted+0 −93
- typo3/sysext/core/Tests/Unit/Page/Fixtures/ImportMap/core/Configuration/JavaScriptModules.phpdeleted+0 −15
- typo3/sysext/core/Tests/Unit/Page/Fixtures/ImportMap/package2/Configuration/JavaScriptModules.phpdeleted+0 −10
- typo3/sysext/core/Tests/Unit/Page/Fixtures/ImportMap/package3/Configuration/JavaScriptModules.phpdeleted+0 −21
- typo3/sysext/core/Tests/Unit/Page/Fixtures/ImportMap/package4/Configuration/JavaScriptModules.phpdeleted+0 −7
- typo3/sysext/core/Tests/Unit/Page/AssetRendererTest.php+5 −1
- typo3/sysext/core/Tests/Unit/Page/ImportMapTest.phpdeleted+0 −254
- typo3/sysext/core/Tests/Unit/Page/PageRendererFactoryTrait.php+11 −4
- typo3/sysext/core/Tests/Unit/Resource/ResourceCompressorTest.php+98 −12
- typo3/sysext/core/Tests/Unit/SystemResource/Identifier/SystemResourceIdentifierFactoryTest.php1new+133 −0
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+4 −0
- typo3/sysext/dashboard/Classes/DashboardInitializationService.php+2 −2
- typo3/sysext/extensionmanager/Classes/Command/DeactivateExtensionCommand.php+4 −1
- typo3/sysext/extensionmanager/Classes/Utility/ListUtility.php+10 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ResourceViewHelper.php7+73 −45
- typo3/sysext/fluid/Classes/ViewHelpers/ResourceViewHelper.php2new+58 −0
- typo3/sysext/fluid/Classes/ServiceProvider.php+27 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/svg_image_test/Resources/Public/Icons/Extension.svgnew+1 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/svg_image_test/Resources/Public/Images/ImageViewHelperTest1.svgrenamed+0 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/svg_image_test/Resources/Public/Images/ImageViewHelperTest2.svgrenamed+0 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/svg_image_test/Resources/Public/Images/ImageViewHelperTest3.svgrenamed+0 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/svg_image_test/Resources/Public/Images/ImageViewHelperTest4.svgrenamed+0 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/svg_image_test/Resources/Public/Images/ImageViewHelperTest5.svgrenamed+0 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/svg_image_test/composer.jsonnew+14 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/svg_image_test/ext_emconf.phpnew+18 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Be/PageRendererViewHelperTest.php+2 −2
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/ImageViewHelperTest.php+4 −4
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/ResourceViewHelperTest.php+90 −35
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/ImageViewHelperTest.php+4 −4
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/SvgImageViewHelperTest.php+15 −12
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+11 −14
- typo3/sysext/frontend/Classes/ContentObject/ScalableVectorGraphicsContentObject.php+32 −16
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+28 −34
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php+1 −30
- typo3/sysext/frontend/Classes/Middleware/StaticRouteResolver.php+14 −20
- typo3/sysext/frontend/Classes/Page/FrontendUrlPrefix.php+4 −10
- typo3/sysext/frontend/Classes/Resource/FilePathSanitizer.php+9 −1
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+41 −16
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_resource_rendering/composer.jsonnew+14 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_resource_rendering/ext_emconf.phpnew+22 −0
- typo3/sysext/frontend/Tests/Functional/Middleware/StaticRouteResolverTest.phprenamed+7 −19
- typo3/sysext/frontend/Tests/Functional/Rendering/Fixtures/AbsoluteUriPrefixRenderingTest.typoscript+3 −8
- typo3/sysext/frontend/Tests/Functional/Rendering/Fixtures/UriPrefixRenderingTest.typoscript+3 −8
- typo3/sysext/frontend/Tests/Functional/Rendering/AbsoluteUriPrefixRenderingTest.php+42 −75
- typo3/sysext/frontend/Tests/Functional/Rendering/ScriptAndLinkTagRenderingTest.php+34 −30
- typo3/sysext/frontend/Tests/Functional/Rendering/UriPrefixRenderingTest.php+5 −67
- typo3/sysext/frontend/Tests/Functional/Resource/FilePathSanitizerTest.phprenamed+12 −13
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+0 −15
- typo3/sysext/frontend/Tests/Unit/Http/RequestHandlerTest.php+18 −5
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportPageAndRecords.php+31 −25
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportPageAndRecordsWithSoftRefs.php+23 −17
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportRecords.php+8 −5
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportTable.php+13 −9
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecords.php+16 −12
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsByUpdate.php+12 −8
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsByUpdateWithDiff.php+31 −28
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsWithDiff.php+31 −28
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsWithSoftRefs.php+9 −6
- typo3/sysext/impexp/Tests/Functional/ExportTest.php+2 −1
- typo3/sysext/impexp/Tests/Functional/ImportTest.php+2 −8
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+1 −1
- typo3/sysext/install/Classes/Service/LanguagePackService.php+6 −4
- typo3/sysext/install/Classes/ServiceProvider.php+3 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+5 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+14 −0
- typo3/sysext/rte_ckeditor/Classes/Form/Element/RichTextElement.php+15 −9
- typo3/sysext/rte_ckeditor/Tests/Functional/Form/Element/RichTextElementTest.php+45 −30
- typo3/sysext/seo/Classes/XmlSitemap/XmlSitemapRenderer.php+31 −19
- typo3/sysext/seo/Tests/Functional/Fixtures/sitemap-xsl1.typoscript+1 −1
- typo3/sysext/seo/Tests/Functional/Fixtures/sitemap-xsl2.typoscript+1 −1
- typo3/sysext/seo/Tests/Functional/Fixtures/sitemap-xsl3.typoscript+2 −2
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapXslTest.php+6 −6
Review log 129211
Show 105186 earlier messages
-
Helmut Hummel uploaded patch set 1 09/12/25, 12:51
-
Helmut Hummel marked it work in progress 09/12/25, 12:51
-
core-ci voted on patch set 1 V -1 09/12/25, 13:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84915
-
Helmut Hummel uploaded patch set 2
V -109/17/25, 21:09 -
Helmut Hummel uploaded patch set 3 09/17/25, 21:16
-
core-ci voted on patch set 2 V -1 09/17/25, 21:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85097
-
core-ci voted on patch set 3 V -1 09/17/25, 21:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85101
-
Helmut Hummel uploaded patch set 4
V -109/22/25, 21:26 -
Helmut Hummel uploaded patch set 5 09/22/25, 21:27
-
core-ci voted on patch set 4 V -1 09/22/25, 21:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85348
-
core-ci voted on patch set 5 V -1 09/22/25, 21:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85349
-
Helmut Hummel uploaded patch set 6
V -109/29/25, 07:21 -
core-ci voted on patch set 6 V -1 09/29/25, 07:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85682
-
Helmut Hummel uploaded patch set 7
V -110/01/25, 20:40 -
core-ci voted on patch set 7 V -1 10/01/25, 20:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85841
-
Helmut Hummel uploaded patch set 8
V -110/02/25, 08:03 -
Helmut Hummel rebased onto patch set 9 10/02/25, 08:04
-
core-ci voted on patch set 8 V -1 10/02/25, 08:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85880
-
core-ci voted on patch set 9 V -1 10/02/25, 08:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85881
-
Helmut Hummel uploaded patch set 10
V -110/02/25, 09:17 -
core-ci voted on patch set 10 V -1 10/02/25, 09:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85891
-
Helmut Hummel uploaded patch set 11
V -110/02/25, 09:46 -
core-ci voted on patch set 11 V -1 10/02/25, 09:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85894
-
Helmut Hummel uploaded patch set 12
V -110/02/25, 11:00 -
core-ci voted on patch set 12 V -1 10/02/25, 11:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85904
-
Helmut Hummel uploaded patch set 13
V -110/02/25, 11:45 -
core-ci voted on patch set 13 V -1 10/02/25, 11:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85914
-
Helmut Hummel uploaded patch set 14
V -110/02/25, 13:11 -
core-ci voted on patch set 14 V -1 10/02/25, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85919
-
Helmut Hummel uploaded patch set 15
V -110/07/25, 19:26 -
core-ci voted on patch set 15 V -1 10/07/25, 19:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86182
-
Helmut Hummel uploaded patch set 16
V -110/07/25, 21:01 -
core-ci voted on patch set 16 V +1 10/07/25, 21:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86189
-
Helmut Hummel uploaded patch set 17
V +110/08/25, 08:27 -
core-ci voted on patch set 17 V -1 10/08/25, 08:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86210
-
Helmut Hummel uploaded patch set 18
V -110/08/25, 10:41 -
core-ci voted on patch set 18 V +1 10/08/25, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86219
-
Helmut Hummel uploaded patch set 19
V +110/12/25, 19:52 -
core-ci voted on patch set 19 V -1 10/12/25, 19:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86495
-
Helmut Hummel uploaded patch set 20
V -110/12/25, 21:39 -
core-ci voted on patch set 20 V +1 10/12/25, 21:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86496
-
Helmut Hummel uploaded patch set 21
V +110/12/25, 22:02 -
core-ci voted on patch set 21 V -1 10/12/25, 22:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86497
-
Helmut Hummel uploaded patch set 22
V -110/12/25, 22:33 -
Helmut Hummel marked it ready for review 10/12/25, 22:33
-
Helmut Hummel uploaded patch set 23 10/12/25, 22:36
-
core-ci voted on patch set 22 V -1 10/12/25, 22:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86498
-
core-ci voted on patch set 23 V +1 10/12/25, 22:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86499
-
Benni Mack commented on patch set 23 10/13/25, 06:14
UriResource.php:27is it a UriResource or a ResourceUri :)ResourceViewHelper.php:25I'd assume this is just a systemResource VH now?TypoScriptFrontendController.php:207this is a good example: Reading the docs, I dont fully understand if it's OK to use the EXT: syntax anymore and in what places exactly. -
Oliver Hader commented on patch set 23 10/13/25, 09:38
SystemResourceUri.php:41Should we be explicitly distinguish extension from package here? e.g. * `t3://resource?extension=core` * `t3://resource?package=typo3/cms-core` (actually `...?package=typo3%2Fcms-core` url-encoded) -
Oliver Hader commented on patch set 23 10/13/25, 10:14
FalFileUri.php:28In case `uid` is numeric-only, it probably should be `%1$d`SystemUri.php:27Our `Uri` implementation is very HTTP-centric. Maybe we should have a dedicated implementation for non-HTTP cases (thus, not extending `TYPO3\CMS\Core\Http\Uri`, but still being compatible to `UriInterface`).SystemUri.php:66I don't understand that condition yet (maybe I'll find a corresponding counterpart later during the review).FakeProjectPackage.php:29`Fake` does sound "suspicious" to me 😊 What about `Virtual`, `Emulated`, `Artificial`, ...? -
Helmut Hummel uploaded patch set 24
V +110/14/25, 13:04 -
core-ci voted on patch set 24 V -1 10/14/25, 13:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86630
-
Helmut Hummel uploaded patch set 25
V -110/14/25, 15:41 -
core-ci voted on patch set 25 V -1 10/14/25, 15:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86651
-
Helmut Hummel uploaded patch set 26
V -110/14/25, 15:54 -
core-ci voted on patch set 26 V +1 10/14/25, 16:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86652
-
Garvin Hicking commented on patch set 26 CR -1 10/14/25, 17:58
On it for some ReST changes -
Garvin Hicking uploaded patch set 27
CR -1V +110/14/25, 18:34 -
Garvin Hicking commented on patch set 27 10/14/25, 18:39
Reply
Done - hope I conserved your intention everywhere, otherwise feel free to revert wherever I made a mistakeFeature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:50As a reader, this is a bit confusing to me, that I have three possibilities here to reference a resource. I think we should state "EXT:" is the legacy notation which will be dropped in the future (or remain as "legacy" for...long?). Why though is "PKG:ext_name" something we want to support then? This feels like another upcoming legacy to me, when I believe we probably want to promote the `PKG:vendor/name` syntax I guess? Another idea for terminology came to my mind when writing this, how about using `EXT<vendor/name>:/Resources...`? We could then parse this on `EXT<` as a prefix, and people might not need to get used to "PKG", and keeping around the "non-composer" EXT:... syntax would be more understandable (sorry if I open up pandoras box of "naming things" again, feel free to resolve if this discussion is annoying).Feature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:74This is not yet mentioned in the breaking ReST I believe?Feature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:91I did not properly understand this. You want to state something like "Missing files in the scope of the legacy exemptions mentioned above will not add a cache busting URI argument"? Maybe this can be rephrased. -
core-ci voted on patch set 27 V -1 10/14/25, 18:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86654
-
Helmut Hummel uploaded patch set 28
V -110/14/25, 19:11 -
core-ci voted on patch set 28 V -1 10/14/25, 19:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86655
-
Helmut Hummel commented on patch set 28 10/14/25, 19:25
SystemResourceUri.php:41Replythe syntax changed. but in any case, in current state, no, we can't distinguish, as the composer names are always aliased to the extension key. so PackageManager->getPackage() will always return the same package for both, the key and the composer name. also: we can't really promote composer names only, as there is non composer mode, where there sometimes are no composer namesFakeProjectPackage.php:29Replythanks. went for VirtualFakeProjectPackage.php:41Reply😊Feature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:50Replyas long as there is no composer mode and composer.json files for extensions are not mandatory for this mode, we can not easily promote composer names. if we manage to achieve enforced composer.json in all modes, then yes, we can go all in on composer names -
Helmut Hummel uploaded patch set 29
V -110/14/25, 20:23 -
core-ci voted on patch set 29 V +1 10/14/25, 20:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86658
-
Helmut Hummel rebased onto patch set 30
V +110/14/25, 20:33 -
core-ci voted on patch set 30 V -1 10/14/25, 20:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86659
-
Helmut Hummel rebased onto patch set 31
V -110/14/25, 20:42 -
core-ci voted on patch set 31 V +1 10/14/25, 20:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86660
-
Helmut Hummel uploaded patch set 32
V +110/15/25, 07:56 -
Garvin Hicking commented on patch set 31 10/15/25, 07:57
Feature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:50ReplyI'm sorry then, I really thought composer.json files were mandatory even for non-compose mode for internal discovery. I always read https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ExtensionArchitecture/FileStructure/ComposerJson.html#about-the-composer-json-file as a very hard recommendation. Couldn't we take this step in v14 now and make that file mandatory as a breaking change? This would make us bear considerably less cruft with a fresh new API like this one here. Maybe we could even internally create a "fake" (hehe) composer.json in case it's missing which just bears an internal composer name like "typo3-project/[extensionkey]"? Then such a scope could be used for resource links with `EXT<typo3-project/my_extension_key>:/Resources/...` and it wouldn't even sound bad to classic users with such a generic typo3-project fake key? -
core-ci voted on patch set 32 V +1 10/15/25, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86690
-
Helmut Hummel uploaded patch set 33
V +110/15/25, 13:13 -
core-ci voted on patch set 33 V -1 10/15/25, 13:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86728
-
Helmut Hummel uploaded patch set 34
V -110/15/25, 19:46 -
core-ci voted on patch set 34 V -1 10/15/25, 19:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86765
-
Helmut Hummel uploaded patch set 35
V -110/16/25, 12:51 -
core-ci voted on patch set 35 V -1 10/16/25, 13:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86813
-
Helmut Hummel uploaded patch set 36
V -110/16/25, 15:49 -
core-ci voted on patch set 36 V -1 10/16/25, 16:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86830
-
Christian Kuhn commented on patch set 36 10/19/25, 14:25
huge one. i read through it, but must admit i didn't grasp all details. i also have some dedicated questions, for instance related to fal getPublicUrl() - i recently stumbled there hard since this it one of the places that *obviously* needs the request (but does not receive it) and currently relies on quirky logic to circumvent the situation. reading the implications of getPublicUrl() alone, i came to the same conclusion we'll have to have a construct that can generate uri/url's based on given request, plus that FAL itself needs to be freed from this job entirely. i'm very glad this change materialized taking care of this need. also, i'm currently actively fiddling with tsfe absRefPrefix and i'd need at least an intermediate solution, somehow depending on how/if/when this change makes it. maybe we could align in a voice chat regarding that detail?ResourceUtility.php:38considering the fact this method is used exactly once and only in MainController, and since adminpanel is FE request related in many places, I think we can very well make $request non-optional and "soft break" here, maybe even without further notice. and while we are at it, we could then make this a non-static service and get the proper service api injected instead of using the intermediate method from PathUtility, or is this too early for your taste?AbstractFormEngineAjaxController.php:63this abstract could use inject* methods instead of makeInstance(), can't it? i'm fine if you say "this too early / too much with this patch", though. -
Helmut Hummel uploaded patch set 37
V -110/19/25, 18:35 -
core-ci voted on patch set 37 V -1 10/19/25, 18:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87021
-
Helmut Hummel uploaded patch set 38
V -110/19/25, 18:50 -
core-ci voted on patch set 38 V -1 10/19/25, 19:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87022
-
Helmut Hummel uploaded patch set 39
V -110/19/25, 19:31 -
core-ci voted on patch set 39 V -1 10/19/25, 19:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87023
-
Helmut Hummel uploaded patch set 40
V -110/19/25, 20:22 -
core-ci voted on patch set 40 V -1 10/19/25, 20:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87024
-
Helmut Hummel uploaded patch set 41
V -110/19/25, 20:57 -
core-ci voted on patch set 41 V -1 10/19/25, 21:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87025
-
Helmut Hummel uploaded patch set 42
V -110/19/25, 21:35 -
Helmut Hummel uploaded patch set 43 10/19/25, 21:40
-
Helmut Hummel uploaded patch set 44 10/19/25, 21:44
-
core-ci voted on patch set 42 V -1 10/19/25, 21:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87026
-
core-ci voted on patch set 44 V -1 10/19/25, 22:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87028
-
Helmut Hummel uploaded patch set 45
V -110/20/25, 08:09 -
core-ci voted on patch set 45 V -1 10/20/25, 08:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87057
-
Helmut Hummel uploaded patch set 46
V -110/20/25, 09:05 -
core-ci voted on patch set 46 V -1 10/20/25, 09:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87063
-
Helmut Hummel uploaded patch set 47
V -110/20/25, 10:13 -
core-ci voted on patch set 47 V -1 10/20/25, 10:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87068
-
Helmut Hummel uploaded patch set 48
V -110/20/25, 11:32 -
core-ci voted on patch set 48 V -1 10/20/25, 11:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87071
-
Helmut Hummel uploaded patch set 49
V -110/20/25, 12:45 -
core-ci voted on patch set 49 V +1 10/20/25, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87078
-
Helmut Hummel uploaded patch set 50
V +110/20/25, 13:44 -
core-ci voted on patch set 50 V -1 10/20/25, 13:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87084
-
Helmut Hummel uploaded patch set 51
V -110/20/25, 14:35 -
Helmut Hummel uploaded patch set 52 10/20/25, 14:35
-
Helmut Hummel uploaded patch set 53 10/20/25, 14:38
-
core-ci voted on patch set 52 V -1 10/20/25, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87090
-
core-ci voted on patch set 53 V -1 10/20/25, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87091
-
Helmut Hummel uploaded patch set 54
V -110/20/25, 15:59 -
Helmut Hummel uploaded patch set 55 10/20/25, 16:01
-
core-ci voted on patch set 55 V +1 10/20/25, 16:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87096
-
core-ci voted on patch set 54 V -1 10/20/25, 16:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87095
-
Helmut Hummel uploaded patch set 56
V +110/21/25, 06:10 -
Helmut Hummel commented on patch set 56 10/21/25, 06:13
Feature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:50ReplyMaking composer.json required for classic mode would be a valuable change and the proposal here would indeed then benefit from some gained clarity. That still is some other cup of tea and not strictly tied to this proposal. However, I think you have valid concerns and, though not feasible to strictly enforce this, we can recommend using Composer package names for the PKG syntax. I will adapt the tests and docs accordingly -
core-ci voted on patch set 56 V -1 10/21/25, 06:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87135
-
Helmut Hummel uploaded patch set 57
V -110/21/25, 06:42 -
core-ci voted on patch set 57 V -1 10/21/25, 06:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87138
-
Helmut Hummel commented on patch set 57 10/21/25, 06:49
ResourceUtility.php:38ReplyYes, absolutely considered this option. However, doing so for (currently) 21 usages takes significant time and also increases the size of this patch significantly. Therefore I propose to postpone this refactoring, which then remains a fun and relatively easy to do task to tackle usages one by oneAbstractFormEngineAjaxController.php:63ReplyDoneSystemResourceUri.php:41Replythis basically is the same comment as from Garvin, so I adapted the PKG: syntax to always only use composer names (except for classic projects with extensions without composer name)Feature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:74ReplyDoneFeature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:91ReplyDone -
Helmut Hummel commented on patch set 57 10/21/25, 07:02
FalFileUri.php:28Replyfixed, by changed identifier syntaxSystemUri.php:27ReplyFixed by changing the syntax and the naming and the implementationSystemUri.php:66Replythis overly complicated condition was due to the misuse of our Uri implementation for identifiers. this is fixed by changing the identifier syntaxUriResource.php:27ReplyIt still is a resource. This abiguity is fixed by changed identifiers and naming for them in codeResourceViewHelper.php:25ReplyDoneTypoScriptFrontendController.php:207Replysome ambiguity is now resolved by using composer names only for PKG syntax and also by using the API throughout all user facing resource references. This means: EXT syntax will continue to work and at the same time PKG syntax will work in all places. I'll try my best to explain this in more detail in the docs -
Helmut Hummel commented on patch set 57 10/21/25, 07:07
AbstractFormEngineAjaxController.php:63ReplyI stand corrected here. I switched to PathUtility because of https://git.typo3.org/typo3/CI/cms/-/jobs/4868973 Let's tackle this in an additional effort -
Helmut Hummel uploaded patch set 58
V -110/21/25, 07:14 -
core-ci voted on patch set 58 V -1 10/21/25, 07:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87141
-
Helmut Hummel uploaded patch set 59
V -110/21/25, 07:32 -
core-ci voted on patch set 59 V +1 10/21/25, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87144
-
Helmut Hummel uploaded patch set 60
V +110/21/25, 07:51 -
core-ci voted on patch set 60 V -1 10/21/25, 08:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87146
-
Helmut Hummel uploaded patch set 61
V -110/21/25, 08:22 -
core-ci voted on patch set 61 V +1 10/21/25, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87153
-
Helmut Hummel uploaded patch set 62
V +110/21/25, 10:21 -
core-ci voted on patch set 62 V -1 10/21/25, 10:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87162
-
Helmut Hummel uploaded patch set 63
V -110/21/25, 11:09 -
core-ci voted on patch set 63 V -1 10/21/25, 11:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87173
-
Helmut Hummel uploaded patch set 64
V -110/21/25, 18:37 -
core-ci voted on patch set 64 V +1 10/21/25, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87196
-
Helmut Hummel uploaded patch set 65
V +110/22/25, 10:02 -
Helmut Hummel rebased onto patch set 66 10/22/25, 10:02
-
core-ci voted on patch set 65 V -1 10/22/25, 10:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87234
-
Markus Klein commented on patch set 66 10/22/25, 10:21
.gitignore:7Not sure about this line and the 2 following. IMO none of these are needed. the .gitkeep is added to version control once and then not affected by the ignore file -
core-ci voted on patch set 66 V -1 10/22/25, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87235
-
Helmut Hummel uploaded patch set 67
V -110/22/25, 11:01 -
Helmut Hummel commented on patch set 67 10/22/25, 11:03
Reply
other than, I'd say this is correct, no?Reply
I WILL rewrite the commit message, stay tuned 😊 -
Helmut Hummel commented on patch set 67 10/22/25, 11:06
.gitignore:7Replyto my understanding this is needed. what I want is: exclude everything, except a few files. but I can remove this from here and create a separate patch, as this isn't some key thing in this change -
Markus Klein commented on patch set 67 10/22/25, 11:08
Reply
then it should be "…of resource publishing strategies other than symlinking…" (but I'm no English teacher :-D ) -
core-ci voted on patch set 67 V +1 10/22/25, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87245
-
Markus Klein commented on patch set 67 10/22/25, 11:09
.gitignore:7ReplyNormally I'd say "keep it", but this change is already so big that it's probably best to move this out. Thanks. -
Helmut Hummel uploaded patch set 68
V +110/22/25, 18:36 -
core-ci voted on patch set 68 V -1 10/22/25, 18:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87288
-
Helmut Hummel uploaded patch set 69
V -110/22/25, 19:41 -
core-ci voted on patch set 69 V +1 10/22/25, 19:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87295
-
Helmut Hummel uploaded patch set 70
V +110/23/25, 06:19 -
core-ci voted on patch set 70 V +1 10/23/25, 06:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87374
-
Benni Mack uploaded patch set 71
V +110/23/25, 11:08 -
core-ci voted on patch set 71 V +1 10/23/25, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87406
-
Helmut Hummel uploaded patch set 72
V +110/23/25, 12:08 -
Helmut Hummel commented on patch set 72 10/23/25, 12:09
Reply
done -
Helmut Hummel uploaded patch set 73 10/23/25, 12:15
-
core-ci voted on patch set 72 V +1 10/23/25, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87413
-
Helmut Hummel commented on patch set 73 10/23/25, 12:21
Reply
done -
Helmut Hummel uploaded patch set 74 10/23/25, 12:23
-
core-ci voted on patch set 73 V -1 10/23/25, 12:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87414
-
Helmut Hummel uploaded patch set 75 10/23/25, 12:24
-
Helmut Hummel uploaded patch set 76 10/23/25, 12:31
-
core-ci voted on patch set 74 V -1 10/23/25, 12:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87416
-
core-ci voted on patch set 75 V -1 10/23/25, 12:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87417
-
core-ci voted on patch set 76 V +1 10/23/25, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87418
-
Helmut Hummel uploaded patch set 77
V +110/23/25, 12:41 -
core-ci voted on patch set 77 V +1 10/23/25, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87420
-
Helmut Hummel uploaded patch set 78
V +110/23/25, 12:54 -
core-ci voted on patch set 78 V +1 10/23/25, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87424
-
Garvin Hicking uploaded patch set 79
V +110/24/25, 18:37 -
core-ci voted on patch set 79 V -1 10/24/25, 18:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87530
-
Helmut Hummel uploaded patch set 80
V -110/25/25, 10:03 -
Helmut Hummel uploaded patch set 81 10/25/25, 10:05
-
Helmut Hummel uploaded patch set 82 10/25/25, 10:08
-
core-ci voted on patch set 80 V -1 10/25/25, 10:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87565
-
core-ci voted on patch set 81 V -1 10/25/25, 10:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87566
-
core-ci voted on patch set 82 V -1 10/25/25, 10:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87567
-
Helmut Hummel uploaded patch set 83 10/25/25, 10:25
Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 83 V -1 10/25/25, 10:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87568
-
Helmut Hummel uploaded patch set 84
V -110/25/25, 10:53 -
core-ci voted on patch set 84 V +1 10/25/25, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87570
-
Benni Mack voted on patch set 84 CR +1 V +1 10/25/25, 11:12
-
Christian Kuhn commented on patch set 84 CR -1 10/25/25, 11:30
on it. -
Garvin Hicking commented on patch set 84 10/25/25, 12:56
Deprecation-107537-getPublicResourcesWebPath.rst:62Should we explicitly say "please do not use $GLOBALS['TYPO3_REQUEST']"? And maybe also give an example how to "create" a fake request for CLI usage, utilizing a specific site? -
Helmut Hummel commented on patch set 84 10/25/25, 13:18
Deprecation-107537-getPublicResourcesWebPath.rst:62ReplyBoth are good advice, yet they are not specifically related to this change imho. Especially for CLI usage, we should actually work on API to create a request and site from a given --site argument, as many already existing core commands would benefit from it already -
Garvin Hicking commented on patch set 84 10/25/25, 13:46
Deprecation-107537-getPublicResourcesWebPath.rst:62ReplyAbout the second thing, yes, definitely. However I'm a bit afraid that people might think "Hm, whats $request?! Let me use the global one then". I think it would help to mention this at this place (unless you think using the global var is fine, too - I can't tell). -
Garvin Hicking commented on patch set 84 10/25/25, 14:23
Some doc notes - I love what you wrote up, this is very detailed and helpful. I did not want to push over the patch while others review/vote.Breaking-107537-UrlGenerationSystemResources.rst:23UnresolvedThis bullet point has no later details with an example or "affected installations". I must admit as a reader I wouldn't immediately know what is meant with that to judge if I'm affected and it sounds a bit serious ;). Is this when using `f:uri.image src=` or `f:image src` I suppose, then we could maybe add this there? I would suppose if I had a directory like "/aws-mirror" set as a FAL storage (outside "fileadmin") and then used `f:image src="/aws-mirror/somefile.jpg"` this worked before, but now no longer works? We also don't have a suggestion/migration mentioned for this bulletpoint on what to do in such cases, unless I'm missing something?Breaking-107537-UrlGenerationSystemResources.rst:30```suggestion .. _breaking-107537-gettext-path: getText "path" in TypoScript ``` Having anchors here will allow us to reference to that easily, which might be helpful for future pointers of the docsBreaking-107537-UrlGenerationSystemResources.rst:55```suggestion .. _breaking-107537-fluid-uri-resource: f:uri.resource view helper in Fluid ```Breaking-107537-UrlGenerationSystemResources.rst:73```suggestion .. _breaking-107537-cache-busting: All generated URLs now contain cache busting ```Breaking-107537-UrlGenerationSystemResources.rst:79```suggestion .. _breaking-107537-query-strings: Additional query strings applied to the resource identifier ```Breaking-107537-UrlGenerationSystemResources.rst:105```suggestion .. _breaking-107537-impact-gettext-path: getText "path" in TypoScript ```Breaking-107537-UrlGenerationSystemResources.rst:115```suggestion .. _breaking-107537-impact-fluid-uri-resource: f:uri.resource view helper in Fluid ```Breaking-107537-UrlGenerationSystemResources.rst:121```suggestion .. _breaking-107537-impact-cache-busting: All generated URLs now contain cache busting ```Breaking-107537-UrlGenerationSystemResources.rst:127```suggestion .. _breaking-107537-impact-query-strings: Additional query strings applied to the resource identifier ```Deprecation-107537-CreateVersionNumberedFileName.rst:62I think for consistency, the same note about $request can be null like in the other deprecation could be stated here.Deprecation-107537-FilePathSanitizer.rst:50This might not have had the `$request` passed in before?Deprecation-107537-FilePathSanitizer.rst:75I think for consistency, the same note about `$request can be null` like in the other deprecation could be stated here.Deprecation-107537-GetDataPath.rst:14```suggestion TypoScript :typoscript:`getData` has two ways to get a URL for a system resource, ```Deprecation-107537-getPublicResourcesWebPath.rst:6```suggestion Deprecation: #107537 - `TYPO3\CMS\Core\Utility\PathUtility::getPublicResourceWebPath` ``` Otherwise it gets munged to `TYPO3CMSCoreUtilityPathUtility` (also please adjust length of the `===...` for two more, gerrit suggestions can only span one row)Feature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:62```suggestion #. composer name of the package (also possible for "classic mode" when using extensions that contain a :file:`composer.json`) ``` We could mention something like this to indicate that a package can have a composer name, even when the project itself runs in classic mode (right?)Feature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:74```suggestion An app resource is a file or folder within your TYPO3 installation. ```Feature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:86```suggestion it can be configured to be a different directory (e.g. `web`, `html` or `htdocs`). In that case, the correct public ``` Maybe mentioning these other well-known alternatives helps to understand.Feature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:92```suggestion While users are encouraged to prefer using package and app resources, ```Feature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:160```suggestion The :php:`TYPO3\CMS\Core\SystemResource\SystemResourceFactory` and an implementation of a system resource publisher is injected via ``` (this will allow the rendered doc page directly link to the API of the docs)Feature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:162```suggestion the interface :php:`TYPO3\CMS\Core\SystemResource\Publishing\SystemResourcePublisherInterface`. ```Feature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:165```suggestion In the future, different publishing strategies might be implemented, e.g. directly ```Feature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:166```suggestion publishing resources to a CDN and then generating CDN URIs directly. In one TYPO3 installation ```Feature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:168```suggestion when the interface is referenced. ```Feature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:185```suggestion Currently only the `<f:uri.resource>` ViewHelper accepts such resource objects, but more ```Feature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:245```suggestion public resource folders or files. ```Feature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:247```suggestion * Using this API in all areas, that consume private resources, most notably Fluid template files. ```Feature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:250```suggestion like Fluid templates, CSS files, logos, images, or even complete themes. ``` -
Simon Praetorius commented on patch set 84 10/25/25, 14:37
AbstractSvgIconProvider.php:82Unresolvedin the original code, there was a todo to deprecate certain variants. was this left out intentionally? And when would isExtensionPath() be true here?ImportMap.php:269Unresolvedmaybe split into two lines and/or explain what is happening here and why? I'd guess that a public path without leading / is needed here?DefaultSystemResourceUriGenerator.php:76Unresolvedshould the port also be added here if set?SystemResourceIdentifierFactoryTest.php:88Unresolvedthese values are not used, are they?ResourceViewHelper.php:61should we trigger a deprecation then? -
Garvin Hicking commented on patch set 84 10/25/25, 15:27
PageRenderer.php:2022UnresolvedIs "Url" right here or should it be "Uri"?CanNotResolveSystemResourceException.php:23UnresolvedMay be personal taste ofc, but I think "UnresolvableSystemResourceException" would fit better with other exceptions in TYPO3 coreSystemResourceIdentifierFactory.php:52```suggestion throw new InvalidSystemResourceIdentifierException(sprintf('Can not resolve URI %s', $resourceIdentifier), 1758700314); ```SystemResourceIdentifierFactory.php:106```suggestion throw new InvalidSystemResourceIdentifierException(sprintf('Can not create system URI from "%s"', $extensionPath), 1758884297, $e); ```SystemResourceIdentifierFactory.php:127```suggestion throw new InvalidSystemResourceIdentifierException(sprintf('Can not create system URI. Unknown package "%s"', $packageKey), 1760989723, $e); ```DefaultSystemResourcePublisher.php:55```suggestion throw new CanNotGenerateUriException(sprintf('Can not generate URI for an unpublished resource %s', $publicResource), 1761211273); ```DummyFileCreationService.php:25Nice and helpful one! :)ResourceViewHelper.php:41UnresolvedI find the new example a bit confusing because it uses f:resource() here and f:uri.resource only later; my first thought was I have an "identifier" attribute on f:uri.resource. So this viewhelper more shows the use of 'f:resource' and not 'f:uri.resource'. Not sure right now if two examples would help or if an additional sentence could mention that using 'f:resource' here for chaining is useful. -
Garvin Hicking commented on patch set 84 10/25/25, 15:37
I tried to test this. My v14 setup is a rather special one: I use a wrapped composer setup, and I use composer packages, especially EXT:bootrap_package for my frontend. My frontend currently fails with an exception: ``` (1/1) ScssPhp\ScssPhp\Exception\CompilerException `/var/www/html/public/PKG:bk2k/bootstrap-package:Resources/Public/Scss/bootstrap5/theme.scss` file not found for @import: PKG:bk2k/bootstrap-package:Resources/Public/Scss/bootstrap5/theme.scss on line 1, at column 0 ``` the ext specifies the file via: ``` page { includeCSS { theme = EXT:bootstrap_package/Resources/Public/Scss/bootstrap5/theme.scss } } ``` if I uncomment this it starts working, but I have the feeling the notation should be good here?! The frontend is broken though for me of course; also I suppose because Scss compiling is involved the reason here is that bootstrap_packages internally evaluates this TypoScript and passes it along. But since the API tries to be backward compatible at this point I wonder if it's worth looking into. Second thing: For testing I had this Page TS Config: ``` page.includeCSS { 1=https://garv.in/css/style.css 1.external=0 2=https://google.com/nothing 2.external=0 3=/test.css 3.external=0 4=/nothing.css 4.external=0 5=../test2.css 1.external=0 6=../nothing2.css 6.external=0 10=https://garv.in/css/style.css?external=1 10.external=1 20=https://google.com/nothing?external=1 20.external=1 30=/test-external.css 30.external=1 } ``` This worked previously, but it breaks now with a TypeError: ``` TYPO3\CMS\Core\Utility\GeneralUtility::isValidUrl(): Argument #1 ($url) must be of type string, null given, called in /var/www/html/typo3-core/typo3/sysext/core/Classes/Resource/ResourceCompressor.php on line 259 ``` So I wonder if that needs to be added to the breaking changes document that certain includeCSS/JS configurations with invalid URIs may now fail, which previously silently worked. -
Helmut Hummel commented on patch set 84 10/25/25, 16:15
ResourceViewHelper.php:61Replywell, deprecation means it works, but is deprecated. However this has no effect setting it to false. I think though that the impact is pretty low, isn't it? -
Simon Praetorius commented on patch set 84 10/25/25, 17:14
ResourceViewHelper.php:61ReplyYes, it's low-impact. However, I'd like the argument to be removed eventually, since it will still appear in documentation and auto-completion. Currently, there isn't a better way: Either we just remove it or we let users know that it will be removed in the future via a deprecation in render(). -
Christian Kuhn voted on patch set 84 CR +1 V +1 10/25/25, 18:25
-
Christian Kuhn voted on patch set 84 V 0 10/25/25, 18:29
-
Helmut Hummel commented on patch set 84 10/25/25, 18:32
Reply Unresolved
the problem here are the hooks. yes, this maybe needs to be mentioned in the breaking rst. All page renderer hooks need to be touched, when they search for certain existing (added) files and try to replace them. The fail to find them, because all added files in pageRenderer are now in PKG syntax. The second typoscript I will check out -
Simon Praetorius commented on patch set 84 10/25/25, 18:33
ResourceViewHelper.php:61ReplyI've pushed a draft for the deprecation, if we want to take this route in a follow-up: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91251 -
Christian Kuhn voted on patch set 84 V +1 10/25/25, 18:38
-
Helmut Hummel commented on patch set 84 10/25/25, 19:06
ResourceViewHelper.php:61ReplyAh, I think I get it. Using the argument will otherwise throw an exception when it is removed later on. So rather remove it now or deprecate it. I'm fine either way -
Simon Praetorius voted on patch set 84 CR +1 10/25/25, 19:13
-
Garvin Hicking commented on patch set 84 CR +1 V +1 10/25/25, 19:22
To not lose votes lets get it in and address the ReSt files, other BCs and VH argument as a followup. This is a great one, this brings us forward by a lot - thanks! -
Helmut Hummel commented on patch set 84 CR +2 V +2 10/25/25, 19:23
Thank you so much for your detailed reviews. All comments will be tackled in followup changes! -
Helmut Hummel merged patch set 85 10/25/25, 19:31
-
Garvin Hicking commented on patch set 85 10/25/25, 20:26
I have resolved some of these in this follow-up: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91252SystemResourceIdentifierFactory.php:52ReplyDoneSystemResourceIdentifierFactory.php:106ReplyDoneSystemResourceIdentifierFactory.php:127ReplyDoneDefaultSystemResourcePublisher.php:55ReplyDoneBreaking-107537-UrlGenerationSystemResources.rst:30ReplyDoneBreaking-107537-UrlGenerationSystemResources.rst:55ReplyDoneBreaking-107537-UrlGenerationSystemResources.rst:73ReplyDoneBreaking-107537-UrlGenerationSystemResources.rst:79ReplyDoneBreaking-107537-UrlGenerationSystemResources.rst:105ReplyDoneBreaking-107537-UrlGenerationSystemResources.rst:115ReplyDoneBreaking-107537-UrlGenerationSystemResources.rst:121ReplyDoneBreaking-107537-UrlGenerationSystemResources.rst:127ReplyDoneDeprecation-107537-CreateVersionNumberedFileName.rst:62ReplyDoneDeprecation-107537-FilePathSanitizer.rst:50ReplyDoneDeprecation-107537-FilePathSanitizer.rst:75ReplyDoneDeprecation-107537-GetDataPath.rst:14ReplyDoneDeprecation-107537-getPublicResourcesWebPath.rst:6ReplyDoneFeature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:62ReplyDoneFeature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:74ReplyDoneFeature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:86ReplyDoneFeature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:92ReplyDoneFeature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:160ReplyDoneFeature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:162ReplyDoneFeature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:165ReplyDoneFeature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:166ReplyDoneFeature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:168ReplyDoneFeature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:185ReplyDoneFeature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:245ReplyDoneFeature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:247ReplyDoneFeature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:250ReplyDone -
Helmut Hummel commented on patch set 85 10/28/25, 09:12
deprecation removed in https://review.typo3.org/c/Packages/TYPO3.CMS/+/91287ResourceViewHelper.php:61ReplyDone
FakeProjectPackage.php:41