Review main Merged

90678[TASK] Use more precise return type for `StringUtility::getUniqueId`

Elias Häußler CR +2 V +2 Easy +2 −0 updated 09/14/25, 10:02

Commit message

PHP's `uniqid`, which is used in `StringUtility::getUniqueId`, always
returns a non-empty-string. Thus, we can safely adapt the return type
annotation of said method. This makes it easier for consumers to rely
on a more precise type inference when using static code analyzers.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Elias Häußler uploaded patch set 1 09/12/25, 20:36

  2. core-ci voted on patch set 1 V +1 09/12/25, 20:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84930

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 09/12/25, 21:35

  4. Oliver Klee voted on patch set 1 CR +1 V +1 09/13/25, 07:51

  5. Garvin Hicking voted on patch set 1 CR +2 V +2 09/14/25, 06:49

  6. Garvin Hicking merged patch set 2 09/14/25, 10:02