Review main Merged

9068[BUGFIX] getAllowedItems called with one parameter too much

Stefan Neufeind CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

getAllowedItems() is called with two parameters. However
the second one is not in the function-definition and not used.

Review

  • Code review CR +2
    • Stanislas Rolland +2
    • Philipp Gampe +1
  • Verified V +2
    • Stanislas Rolland +2

Files 1

Review log 5

  1. Stanislas Rolland commented on patch set 1 V 0 02/18/12, 03:39

    by team member; Looks good to me, approved
  2. Stefan Neufeind commented on patch set 1 02/18/12, 03:39

    that second parameter is not in the function-definition for getAllowedItems() and never has been (validated this down to at least the 4.4-branch). So we can safely drop it in the call and still keep BC.
  3. Philipp Gampe commented on patch set 1 02/18/12, 03:39

    Looks good to me, but someone else must approve
  4. Mr. Jenkins commented on patch set 1 02/18/12, 03:39

  5. Stanislas Rolland merged patch set 1 02/18/12, 03:39