Review main Merged

90680[TASK] Extract Label File Resolving into separate service

Benni Mack CR +2 V +2 Hard +304 −220 updated 10/17/25, 21:53

Commit message

This change moves the detection of the label file
resolving (XLF) from LocalizationFactory into
a separate LabelFileResolver class.

LabelFileResolver is internal,
it is more a matter of separation of concerns for the
time being, so it can be replaced / phased out
at some point if we find something better.

The new class should not be called from external
services and APIs.

At the same time this patch also moves some code
around to simplify e.g. LanguageService.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1318

  1. Benni Mack uploaded patch set 1 09/14/25, 11:40

  2. core-ci voted on patch set 1 V +1 09/14/25, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84957

  3. Benni Mack updated the commit message in patch set 2 V +1 09/15/25, 13:34

  4. core-ci voted on patch set 2 V +1 09/15/25, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84988

  5. Benni Mack uploaded patch set 3 V +1 09/15/25, 15:24

  6. core-ci voted on patch set 3 V -1 09/15/25, 15:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84990

  7. Benni Mack uploaded patch set 4 V -1 09/15/25, 16:09

  8. Benni Mack uploaded patch set 5 09/15/25, 16:10

  9. core-ci voted on patch set 4 V -1 09/15/25, 16:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84993

  10. core-ci voted on patch set 5 V +1 09/15/25, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84994

  11. Georg Ringer voted on patch set 5 CR +1 V +1 09/15/25, 19:02

  12. Stefan Bürk voted on patch set 5 CR +1 09/16/25, 08:54

  13. Stefan Bürk voted on patch set 5 V +1 09/16/25, 09:20

  14. Oli Bartsch voted on patch set 5 CR +1 V +1 09/16/25, 09:24

  15. Benni Mack voted on patch set 5 CR +2 V +2 09/16/25, 09:45

  16. Benni Mack merged patch set 6 09/16/25, 09:45

  17. Simon Schaufelberger commented on patch set 6 10/17/25, 20:58

    LocalizationFactory.php:68

    @benni@typo3.org I'm expecting a breaking Rst file here because calling the method with 3 parameters will break now. I'm just creating a Rector Rule for this one: https://review.typo3.org/c/Packages/TYPO3.CMS/+/90658 and noticed that the method got adjusted again.
  18. Benni Mack commented on patch set 6 10/17/25, 21:53

    LocalizationFactory.php:68 Reply