90680[TASK] Extract Label File Resolving into separate service
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oli Bartsch +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oli Bartsch +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/Localization/LabelFileResolver.phpnew+241 −0
- typo3/sysext/core/Classes/Localization/LanguageService.php+16 −25
- typo3/sysext/core/Classes/Localization/LocalizationFactory.php2+26 −190
- typo3/sysext/core/Classes/ServiceProvider.php+7 −1
- typo3/sysext/core/Tests/Unit/Localization/LocalizationFactoryTest.php+4 −3
- typo3/sysext/core/Tests/Unit/Page/PageRendererFactoryTrait.php+2 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/TranslateViewHelperTest.php+8 −0
Review log 1318
-
Benni Mack uploaded patch set 1 09/14/25, 11:40
-
core-ci voted on patch set 1 V +1 09/14/25, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84957
-
Benni Mack updated the commit message in patch set 2
V +109/15/25, 13:34 -
core-ci voted on patch set 2 V +1 09/15/25, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84988
-
Benni Mack uploaded patch set 3
V +109/15/25, 15:24 -
core-ci voted on patch set 3 V -1 09/15/25, 15:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84990
-
Benni Mack uploaded patch set 4
V -109/15/25, 16:09 -
Benni Mack uploaded patch set 5 09/15/25, 16:10
-
core-ci voted on patch set 4 V -1 09/15/25, 16:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84993
-
core-ci voted on patch set 5 V +1 09/15/25, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84994
-
Georg Ringer voted on patch set 5 CR +1 V +1 09/15/25, 19:02
-
Stefan Bürk voted on patch set 5 CR +1 09/16/25, 08:54
-
Stefan Bürk voted on patch set 5 V +1 09/16/25, 09:20
-
Oli Bartsch voted on patch set 5 CR +1 V +1 09/16/25, 09:24
-
Benni Mack voted on patch set 5 CR +2 V +2 09/16/25, 09:45
-
Benni Mack merged patch set 6 09/16/25, 09:45
-
Simon Schaufelberger commented on patch set 6 10/17/25, 20:58
-
Benni Mack commented on patch set 6 10/17/25, 21:53
LocalizationFactory.php:68ReplySee https://review.typo3.org/c/Packages/TYPO3.CMS/+/90755 where I adjusted the RST again
LocalizationFactory.php:68