90684[BUGFIX] Fix FAL getFileReferenceData method return signature
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Christian Kuhn +1
-
Verified V +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1215
-
Garvin Hicking uploaded patch set 1 09/15/25, 09:11
-
core-ci voted on patch set 1 V +1 09/15/25, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84977
-
Oliver Klee voted on patch set 1 CR +1 09/15/25, 09:52
-
Oliver Klee commented on patch set 1 09/15/25, 09:53
Is there any way to cover this with a regression test? -
Garvin Hicking updated the commit message in patch set 2
CR +1V +109/15/25, 10:12 -
Garvin Hicking commented on patch set 2 09/15/25, 10:13
Reply
I'll have a look, maybe this can even be done in a functional test without mocking by requesting a non-existant record and doing an expectation on receiving an exception -
core-ci voted on patch set 2 V +1 09/15/25, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84980
-
Garvin Hicking uploaded patch set 3
V +109/15/25, 10:49 -
Garvin Hicking commented on patch set 3 09/15/25, 10:49
Reply
Done -
Oliver Klee voted on patch set 3 CR +1 V +1 09/15/25, 10:55
-
core-ci voted on patch set 3 V +1 09/15/25, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84981
-
Ingo Hollmann commented on patch set 3 09/16/25, 11:28
It seems like the patch fixed our problem completely. As our extension already catches the now thrown exception, everything works now as expected. -
Christian Kuhn voted on patch set 3 CR +1 V +1 09/17/25, 15:39
-
Georg Ringer voted on patch set 3 CR +2 V +2 09/17/25, 18:25
-
Georg Ringer merged patch set 4 09/17/25, 18:25