Review main Abandoned

90686[WIP][REUPLOAD][TASK] Avoid costly database schema queries and class state

Benjamin Franzke CR 0 V 0 Normal +24 −33 updated 10/01/25, 09:16

Commit message

Some places in our code base need to deal with database schema
information, which are quite costly doing them over and over again.

This change streamlines occurrences to use the internal cached
schema information (`Connection->getSchemaInformation()`) to
replace the occurrences and centralizing them to one place. With
that, instance state can be removed in two cases and in one case
the uncached usage replaced by the cached schema information.

`SchemaInformation->listTableColumns()` is added to mimic the
`AbstractSchemaManager->listTableColumns()` method and return
same structure `array<string, Column>` instead of `Column[]`,
considerable not a feature and doable as task because the
complete class is marked as `@internal`.

Note that `SchemaInformation` uses only a code cache right now
and will get a second level (`runtime`) cache in a dedicated
change eliminating the need to read it from PHP files over and
over again.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 4

Review log 24

  1. Benjamin Franzke uploaded patch set 1 09/15/25, 11:56

  2. core-ci voted on patch set 1 V +1 09/15/25, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84983

  3. core-ci commented on patch set 1 09/15/25, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84984

  4. Stefan Bürk abandoned the change 10/01/25, 09:16