Review main Merged

90693[TASK] Centralize code in EXT:core/Localization

Benni Mack CR +2 V +2 Hard +238 −302 updated 09/23/25, 05:44

Commit message

Some code parts that have been around in Extbase
+ EXT:form have now been moved into LanguageService.

This way, a special ConfigurationManager is now "gone"
and we rely on $GLOBALS[TYPO3_REQUEST] to reduce
dependencies on pure Extbase, making the option
globally available.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 2640

Show 815 earlier messages
  1. Benni Mack uploaded patch set 1 09/16/25, 09:59

  2. Benni Mack commented on patch set 2 09/16/25, 09:59

    Published edit on patch set 1.
  3. core-ci voted on patch set 1 V -1 09/16/25, 10:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85018

  4. core-ci voted on patch set 2 V -1 09/16/25, 10:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85019

  5. Benni Mack uploaded patch set 3 V -1 09/16/25, 10:25

  6. core-ci voted on patch set 3 V -1 09/16/25, 10:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85022

  7. Benni Mack rebased onto patch set 4 V -1 09/19/25, 09:08

  8. core-ci voted on patch set 4 V -1 09/19/25, 09:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85153

  9. Benni Mack uploaded patch set 5 V -1 09/20/25, 09:08

  10. Benni Mack updated the commit message in patch set 6 09/20/25, 09:14

  11. core-ci voted on patch set 5 V -1 09/20/25, 09:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85201

  12. core-ci voted on patch set 6 V -1 09/20/25, 09:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85202

  13. Benni Mack uploaded patch set 7 V -1 09/20/25, 09:33

  14. core-ci voted on patch set 7 V +1 09/20/25, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85203

  15. Christian Kuhn commented on patch set 7 09/20/25, 14:08

    LanguageService.php:323

    could we make $request non-optional here and move the fallback to globals to the consumers? this would avoid a globals access in ext:core.
  1. Benni Mack commented on patch set 7 09/20/25, 21:33

    LanguageService.php:323 Reply

    thought about that too, however EXT:form does not provide the request, and cleaning up TranslationService to get a valid request object is a bubble where I went down 3 layers. I can change it and have $GLOBALS[TYPO3_REQUEST] hand in from EXT:form where I need to check for TYPO3_REQUEST 2 times, or one layer further where I'd need to check 27 times (and clean up GeneralUtility on the way). Yes, doable, but actually, I wanted to focus on LLL not on cleaning up EXT:form ;)
  2. Christian Kuhn commented on patch set 7 09/20/25, 23:12

    LanguageService.php:323 Reply

    yeah. my stake is here that LanguageService is library and ext:form is "just" application. i'd prefer to not add a new globals access to a lib class (at least for new code), but (if i have the chance) to app code instead: app code can be often changed & adapted more easily, especially when people use it later.
  3. Christian Kuhn uploaded patch set 8 V +1 09/20/25, 23:26

  4. core-ci voted on patch set 8 V -1 09/20/25, 23:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85220

  5. Christian Kuhn uploaded patch set 9 V -1 09/20/25, 23:43

  6. core-ci voted on patch set 9 V +1 09/20/25, 23:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85221

  7. Christian Kuhn uploaded patch set 10 V +1 09/20/25, 23:59

  8. core-ci voted on patch set 10 V +1 09/21/25, 00:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85222

  9. Christian Kuhn commented on patch set 10 09/21/25, 00:10

    LanguageService.php:323 Reply

    i pushed a version that implements the 'first' layer: ext:core LanugageService request is now non-optional and ext:form and (static) ext:extbase do the mess they have to do to provide it. i think that's better: it reduces the impact to these higher level places. what do you think?
  10. Christian Kuhn commented on patch set 10 09/21/25, 00:17

    LanguageService.php:326

    looking at this, we could even change that method a bit more: the check for application-frontend is semi useful - it "only" prevents using / abusing TS language overrides in BE context in a quite brutal way. We could skip this line and instead of handing over full $request, hand over typo3\cms\core\typoscript\frontendtyposcript (request attribute frontend.typoscript) directly. this way, it would still be quite clear this method is for FE label overloading (we should comment on that in the method header), and the impact would be lower since only the object that is *really* needed here is hand over instead of full request. this would be a quite straight change, too. do you wont me to push a version to see how it looks?
  11. Benni Mack uploaded patch set 11 V +1 09/22/25, 05:52

  12. core-ci voted on patch set 11 V -1 09/22/25, 06:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85271

  13. Benni Mack uploaded patch set 12 V -1 09/22/25, 06:14

  14. core-ci voted on patch set 12 V +1 09/22/25, 06:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85275

  15. Benni Mack uploaded patch set 13 V +1 09/22/25, 15:20

  16. Benni Mack commented on patch set 13 09/22/25, 15:20

    LanguageService.php:323 Reply

    Done

    LanguageService.php:326 Reply

    Done
  17. core-ci voted on patch set 13 V +1 09/22/25, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85312

  18. Christian Kuhn voted on patch set 13 CR +1 V +1 09/22/25, 17:57

  19. Christian Kuhn commented on patch set 13 09/22/25, 17:58

    TranslationService.php:122

    not critical, but i think '$request instanceof ServerRequestInterface' check could be left out here. maybe adapt if the change needs to be pushed again.
  20. Benni Mack uploaded patch set 14 CR +1 V +1 09/22/25, 18:29

  21. core-ci voted on patch set 14 V +1 09/22/25, 18:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85334

  22. Georg Ringer voted on patch set 14 CR +1 V +1 09/22/25, 19:07

  23. Christian Kuhn voted on patch set 14 CR +1 V +1 09/22/25, 22:08

  24. Georg Ringer voted on patch set 14 CR +2 V +2 09/23/25, 05:09

  25. Benni Mack merged patch set 15 09/23/25, 05:44