Review main Merged

90694[FEATURE] Implement accessible combobox pattern

Benjamin Kott CR +2 V +2 Expert +1390 −138 updated 10/16/25, 12:26

Commit message

This change introduces a new ARIA 1.2 compliant
combobox web component that replaces the legacy
valuepicker select pattern. The implementation
follows W3C accessibility guidelines and includes
comprehensive keyboard navigation support.

The component provides full keyboard navigation
support with Arrow keys, Enter, Tab, and Escape
keys. It includes visual selection indicators with
checkmarks and a clear button for resetting the
input value.

FormEngine elements including EmailElement,
InputTextElement, and NumberElement have been
updated to use the new combobox component instead
of the previous valuepicker implementation.

The link browser components have been adapted
to use the combobox pattern as well.

see: https://www.w3.org/WAI/ARIA/apg/patterns/combobox/
see: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Roles/combobox_role

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 23

Show 3 more files

Review log 5895

Show 3970 earlier messages
  1. Benjamin Kott uploaded patch set 1 09/16/25, 10:46

  2. core-ci voted on patch set 1 V +1 09/16/25, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85023

  3. Benjamin Kott uploaded patch set 2 V +1 10/01/25, 10:40

  4. core-ci voted on patch set 2 V -1 10/01/25, 10:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85800

  5. Benjamin Kott uploaded patch set 3 V -1 10/01/25, 10:56

  6. Benjamin Kott updated the commit message in patch set 4 10/01/25, 10:58

  7. core-ci voted on patch set 3 V -1 10/01/25, 11:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85801

  8. core-ci voted on patch set 4 V -1 10/01/25, 11:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85802

  9. Benjamin Kott uploaded patch set 5 V -1 10/01/25, 11:10

  10. Benjamin Kott uploaded patch set 6 10/01/25, 11:14

  11. core-ci voted on patch set 5 V -1 10/01/25, 11:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85805

  12. core-ci voted on patch set 6 V -1 10/01/25, 11:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85806

  13. Benjamin Kott uploaded patch set 7 V -1 10/02/25, 05:22

  14. Benjamin Kott rebased onto patch set 8 10/02/25, 05:35

  15. core-ci voted on patch set 7 V -1 10/02/25, 05:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85856

  16. core-ci voted on patch set 8 V -1 10/02/25, 05:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85858

  17. Benjamin Kott uploaded patch set 9 V -1 10/02/25, 05:57

  18. core-ci voted on patch set 9 V -1 10/02/25, 06:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85861

  19. Benjamin Kott rebased onto patch set 10 V -1 10/02/25, 07:05

  20. core-ci voted on patch set 10 V -1 10/02/25, 07:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85873

  21. Benjamin Kott uploaded patch set 11 V -1 10/02/25, 09:41

  22. core-ci voted on patch set 11 V -1 10/02/25, 09:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85892

  23. Benjamin Kott rebased onto patch set 12 V -1 10/02/25, 10:13

  24. core-ci voted on patch set 12 V -1 10/02/25, 10:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85898

  25. Benjamin Kott uploaded patch set 13 V -1 10/02/25, 11:15

  26. core-ci voted on patch set 13 V -1 10/02/25, 11:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85908

  27. Benjamin Kott uploaded patch set 14 V -1 10/02/25, 12:16

  28. core-ci voted on patch set 14 V -1 10/02/25, 12:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85917

  29. Benjamin Kott uploaded patch set 15 V -1 10/02/25, 13:01

  30. core-ci voted on patch set 15 V -1 10/02/25, 13:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85918

  31. Benjamin Kott updated the commit message in patch set 16 V -1 10/02/25, 13:17

  32. core-ci voted on patch set 16 V -1 10/02/25, 13:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85920

  33. Benjamin Kott uploaded patch set 17 V -1 10/06/25, 06:57

  34. Benjamin Kott uploaded patch set 18 10/06/25, 07:01

  35. core-ci voted on patch set 17 V -1 10/06/25, 07:32 Copied votes on follow-up patch sets have been updated: * Verified-1 has been copied to patch set 18 (copy condition: "changekind:NO_CHANGE"). Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86058

  36. core-ci voted on patch set 18 V -1 10/06/25, 07:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86062

  37. Benjamin Kott uploaded patch set 19 V -1 10/10/25, 10:24

  38. Benjamin Kott uploaded patch set 20 10/10/25, 10:35

  39. core-ci voted on patch set 19 V -1 10/10/25, 10:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86384

  40. core-ci voted on patch set 20 V +1 10/10/25, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86386

  41. Benjamin Kott updated the commit message in patch set 21 V +1 10/10/25, 11:19

  42. core-ci voted on patch set 21 V +1 10/10/25, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86395

  43. Garvin Hicking commented on patch set 21 10/10/25, 12:29

    When I open the select dropdown the first time and click outside to close it, the combobox works. However, when I click on the chavron icon again, the combobox opens and closes immediately. See video: https://www.dropbox.com/scl/fi/qlpnktodnwgwnmwuhtkwc/Screen-Recording-2025-10-10-at-14.23.51.mov?rlkey=i7n3dg48bkkzmw43dvclz8pv0&dl=0

    tx_styleguide_elements_basic.php:221

    I think we need to document the removal of thise valuePicker.append/prepend functionality, and could not break this in v13 backport. @stefan@buerk.tech will report also usage in third party extensions where this would hurt a bit later. It's currently documented in: https://docs.typo3.org/permalink/t3tca:confval-input-valuepicker
  44. Oli Bartsch uploaded patch set 22 V +1 10/10/25, 13:01

  45. core-ci voted on patch set 22 V -1 10/10/25, 13:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86401

  46. Benjamin Franzke rebased onto patch set 23 V -1 10/10/25, 13:53

  47. core-ci voted on patch set 23 V -1 10/10/25, 14:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86410

  48. Benjamin Franzke uploaded patch set 24 V -1 10/10/25, 15:27

  49. Benjamin Franzke uploaded patch set 25 10/10/25, 15:33

  50. core-ci voted on patch set 24 V +1 10/10/25, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86415

  51. core-ci voted on patch set 25 V +1 10/10/25, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86416

  52. Stefan Bürk commented on patch set 25 CR -1 10/10/25, 20:22

    tx_styleguide_elements_basic.php:221 Reply

    Like @garvin@hick.ing already mentioned, the current state is heavily breaking, because * valuePicker mode: "append" * valuePicker mode: "prevent" is completly removed without replacement. Until now, valuePicker with these modes could be used to allow defining a "free-text" field adding values from the picker on the left side or the right side. These modes may seem not that use-full on the first look, but we uses this in public extension(s) and a lot in project internal extensions. Let me try to sketch one of the use-cases we have implemented: Let's assume we want to provide a input field to define a format-pattern, let's say for "page title" to be used to generate a page title based on the pattern allowing placeholders and set using the meta-tag / pageTitle API. ``` $pattern1 = 'Userprofile: %%PROFILE__FIRST_NAME%% %%PROFILE__LAST_NAME%%' $pattern2 = 'Userprofile: %%PROFILE__LAST_NAME%%, %%PROFILE__LAST_NAME%%' ``` The system provides fields of a model/models as valuePicker items: ``` $valuePickerItems = [ [ 'value' => '%%PROFILE_FIRST_NAME%%', 'label' => 'LLL:EXT:.....label_identifier1', ], [ 'value' => '%%PROFILE_LAST_NAME%%', 'label' => 'LLL:EXT:.....label_identifier2', ], // ... [ 'value' => '%%PROFILE_SOME_OTHER_TABLE_FIELD_NAME%%', 'label' => 'LLL:EXT:.....label_identifierXYZ', ], ]; ``` The goal is, that the full pattern value can either be entered manually or "composed", for example: 1. Enter `Userprofile: ` into the input field 2. Select LAST_NAME from value picker, appending `%%PROFILE__LAST_NAME%%` to the input text field value 3. Add manually `, ` (comma and a space character) to the input field 4. Select FIRST_NAME from value picker, appending `%%PROFILE__FIRST_NAME%%` to input field value. The 4 steps as "string" representation ``` $v = 'Userprofile: '; // 1. => 'Userprofile: ' $v.= '%%PROFILE__LAST_NAME%%'; // 2. => 'Userprofile: %%PROFILE__LAST_NAME%%' $v.= ', '; // 3. => 'Userprofile: %%PROFILE__LAST_NAME%%, ' $v.= '%%PROFILE__FIRST_NAME%%';// 4. => 'Userprofile: %%PROFILE__LAST_NAME%%, %%PROFILE__FIRST_NAME%%' ``` With tis change, modes are completly ignored and selection always replaces the complete value .. at least for input-field with valuePicker definition. Not sure if that can be provided in a good way for accessibility reasons, and dropping the modes **must** be done - than this can only be a breaking change for v14. I guess the valuePicker modes was simply missed as a rare case, maybe not to much people are really using valuePicker except TYPO3 core - and the additional modes on top, still we should not "silently" breaking that silently as backported task to a active LTS version. To make that sure, I don't want to blame here anyone - just wanted to make clear that really used feature are removed with that and at least needs to be discussed and properly communicated. From that side current state is a -1 from my side, as this should be target but the work generally has not to be blocked.
  53. Benjamin Franzke uploaded patch set 26 CR -1 V +1 10/11/25, 08:30

  54. Benjamin Franzke commented on patch set 26 10/11/25, 08:30

    tx_styleguide_elements_basic.php:221 Reply

    We are aware and discussed this alot and still think that this needs to vanish, but I agree it cannot be removed in v13. I haven't discused with Benji we he removed this in this patchset (i guess he just wanted the accessibility issues to be gone and remove), but decided to readd it for now. The usability of the prepend/append modes is pretty blunt and awful, especially your step "3" depicts that, it is not untuitiveley clear what a prepend/append valuePicker will do, before trying it and it is hardly useful in it's current state, given that strings are just concatenated. The usability is bad and it is not accessible and the usecase at least questionable, this is why we'd like to remove that – but again, that'll be a main-only task. For type number and email any other mode than `replace` makes no sense, these are left-overs from the type-splits where it was missed to remove these options, so we will completely replace the implementation in here. Also please note that we left it in place for the textarea element, as that needs a very different pattern as well
  55. Benjamin Franzke commented on patch set 26 CR -1 10/11/25, 08:31

    Reply

    thx, fixed.
    still on it and we need to discuss some details, no review needed yet.
  56. Benjamin Franzke uploaded patch set 27 CR -1 10/11/25, 08:32

  57. core-ci voted on patch set 27 V +1 10/11/25, 08:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86459

  58. core-ci voted on patch set 26 V -1 10/11/25, 08:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86458

  59. Benjamin Kott commented on patch set 27 CR -1 10/13/25, 06:37

    tx_styleguide_elements_basic.php:221 Reply

    Hey, i missed removing the v13 flag on this patch - it needs to go into main only. I also overlooked the breaking RST for prepend, append - this option needs to go in general will prepare a dedicated patch for this.
  60. Benjamin Kott uploaded patch set 28 CR -1 V +1 10/13/25, 07:21

  61. Benjamin Kott voted on patch set 28 CR -2 10/13/25, 07:21

  62. Benjamin Kott uploaded patch set 29 10/13/25, 07:23

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  63. core-ci voted on patch set 28 V +1 10/13/25, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86516

  64. core-ci voted on patch set 29 V -1 10/13/25, 07:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86518

  65. Benjamin Kott commented on patch set 30 V -1 10/13/25, 09:39

    Published edit on patch set 29. Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  66. core-ci voted on patch set 30 V +1 10/13/25, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86522

  67. Stefan Bürk commented on patch set 30 10/13/25, 10:43

    tx_styleguide_elements_basic.php:221 Reply

    Sorry, still not happy with the "decision" to drop this without any replacement. From a agency side using this a lot in several projects successfully and with customer (editors) being happy enough with it and the fact that no "custom" backend form engine type/rendering/java-script/tca things has to be maintained this is not really understandable and sell to customers why this is dropped replacement-less. Sure, the behaviour was not the "best", but it was good enough and a cost effective way to provide a free-text mixed with placeholder as selection to be choosed from allowing editors to make this easy enough to use without the need to "lookup" placeholders in external documentation or making typos when entering them manually. From agency and customer perspectivte I would really like to know what the plan is for an alternative of a dropped working solution.
  68. Benjamin Kott commented on patch set 30 CR -2 10/14/25, 07:06

    tx_styleguide_elements_basic.php:221 Reply

    You are looking for something else here, and i cannot agree that this should be a solution for your suggested problem. The outcome is barely usable from that i understand and needs explanation and training for editors i consider the current use case you are describing in combination with the implementation as a low effort hack and not a solution at all. Also, in the talks with Michael Telkamp about A11Y patterns in that area - this solution is something you cannot explain to anyone. The goal is to have the best user experience for anyone using TYPO3. And we have to prioritize this. We often hear TYPO3 is too complicated, not accessible, etc. It´s this kind of solutions not providing suitable interfaces for the job that lead to that impression that is bad for the product overall. While i agree and can understand certain use cases and standpoints - this is why we have the open discussions here, we rolled back on our plans also to delete it for certain types altogether and will provide better proper solutions for that instead. And we have a lot of stuff like this in the form engine and need address this finally. I also think this is a perfect place for an edge case where any extension can step in and provide a good interface for that, something that's really edgy.
  69. Benjamin Franzke uploaded patch set 31 V +1 10/14/25, 09:45

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  70. core-ci voted on patch set 31 V +1 10/14/25, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86610

  1. Stefan Bürk commented on patch set 31 10/14/25, 10:34

    tx_styleguide_elements_basic.php:221 Reply

    Done
  2. Benjamin Franzke uploaded patch set 32 CR -1 V +1 10/14/25, 12:26

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  3. core-ci voted on patch set 32 V +1 10/14/25, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86627

  4. Benjamin Franzke uploaded patch set 33 V +1 10/14/25, 15:32

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  5. core-ci voted on patch set 33 V +1 10/14/25, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86649

  6. Benjamin Kott voted on patch set 33 CR 0 10/15/25, 07:32

  7. Benjamin Franzke uploaded patch set 34 V +1 10/15/25, 08:35

  8. core-ci voted on patch set 34 V +1 10/15/25, 08:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86697

  9. Georg Ringer commented on patch set 34 10/15/25, 09:35

    wouldn't it clarify as a feature?
  10. Benjamin Franzke commented on patch set 34 10/15/25, 09:44

    Reply

    well, it's a highlight, but not new functionality, existing functionality is fixed/reworked. But to include it in our "release highlights" it could be marked as a Feature – but it is actually an a11y BUGFIX.
  11. Benjamin Franzke commented on patch set 34 CR -1 10/15/25, 09:47

    on it
  12. Benjamin Franzke uploaded patch set 35 CR -1 V +1 10/15/25, 12:07

  13. Benjamin Franzke commented on patch set 35 10/15/25, 12:07

    Reply

    Done

    Reply

    Done

    Reply

    Done
  14. core-ci voted on patch set 35 V +1 10/15/25, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86718

  15. Andreas Kienast commented on patch set 35 10/15/25, 12:43

    combobox-element.ts:81

    This method looks unused. Is this a preparation for something else or a left over?

    combobox-element.ts:615

    This is superfluous thanks to the `HTMLElementTagNameMap`.

    combobox-element.ts:686

    This is superfluous thanks to the `HTMLElementTagNameMap`.
  16. Benjamin Franzke uploaded patch set 36 CR +1 V +1 10/15/25, 12:55

  17. Benjamin Franzke commented on patch set 36 10/15/25, 12:55

    combobox-element.ts:81 Reply

    Acknowledged

    combobox-element.ts:615 Reply

    Done

    combobox-element.ts:686 Reply

    Done
  18. Michael Telgkamp commented on patch set 36 V -1 10/15/25, 13:04

    combobox-element.ts:491

    This should also remove the visual indication of the current selection in the listbox in order to clarify the text will be used when activation the value by pressing enter or leaving the form element. The visual focus should be reactivated on press of an arrow key.
  19. core-ci voted on patch set 36 V +1 10/15/25, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86725

  20. Benjamin Franzke uploaded patch set 37 CR +1 V +1 10/15/25, 15:30

  21. Benjamin Franzke commented on patch set 37 10/15/25, 15:30

    combobox-element.ts:491 Reply

    ack, I agree! This is implemented now.
  22. core-ci voted on patch set 37 V +1 10/15/25, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86744

  23. Benni Mack voted on patch set 37 CR +1 V +1 10/16/25, 12:25

  24. Benjamin Kott voted on patch set 37 CR +2 V +2 10/16/25, 12:26

  25. Benjamin Kott merged patch set 38 10/16/25, 12:26