Review main Abandoned

90698[WIP][TASK] Use a static default for the install tool session path

Benjamin Franzke CR 0 V 0 Easy +6 −2 updated 09/17/25, 07:45

Commit message

There are some reasons why we want to avoid a dependency
between DefaultConfiguration.php and dynamic environment-related
paths:

 * We want to streamline site settings and system settings with
   a unified settings API and the current design does not permit
   dynamic defaults.
   * TODO: We could also dicuss to change the API design (don't know
     how yet) based on this "requirement"
   * This is to be taken with a grain of salt, since this specific
     configuration is (probably) not intended to be configurable via
     GUI at all (since a value change causes an immediate logout)
 * a dynamic default does not allow to decide if a settings value is
   actually a custom value (e.g. from a settings editor) and is to be
   stored in system/settings.php explicitly or not, since the default
   value is not stable across different deployment environments
 * more?

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Benjamin Franzke uploaded patch set 1 09/17/25, 06:48

  2. core-ci voted on patch set 1 V +1 09/17/25, 06:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85060

  3. Benjamin Franzke marked it work in progress 09/17/25, 07:43

  4. Benjamin Franzke abandoned the change 09/17/25, 07:45